[fix] Update 0.72-stable with rncore podspec fix by hoxyq · Pull Request #36588 · react/react-native

hoxyq · 2023-03-22T19:10:05Z

cherry-picking #36571 into 0.72-stable

Summary: Pull Request resolved: #36571 Changelog: [Internal] The problem is related to the way we use `js_srcs_dir` & `output_dir` options, one requires just relative path from current ruby script, other requires relative path from iOS root project (where the Podfile located) output_dir was introduced in D43304641 resulted into the issue, described in https://discord.com/channels/514829729862516747/1087736932953509958 allow-large-files Reviewed By: cipolleschi Differential Revision: D44294112 fbshipit-source-id: 47fcf510e203d0880e1f92ab6ead09f4b79cb4dd

github-actions · 2023-03-22T19:11:08Z

	Fails
🚫	❔ This pull request needs a description.
🚫	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

	Warnings
⚠️	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 08b61e9

analysis-bot · 2023-03-22T19:34:02Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,519,141	-10
android	hermes	armeabi-v7a	7,834,736	-494
android	hermes	x86	8,998,993	-168
android	hermes	x86_64	8,854,061	-257
android	jsc	arm64-v8a	9,141,836	+1,326
android	jsc	armeabi-v7a	8,333,483	+833
android	jsc	x86	9,196,423	+1,205
android	jsc	x86_64	9,454,250	+1,082

Base commit: cf43f9c
Branch: main

cipolleschi · 2023-03-27T10:27:12Z

I think we need to look at all the CI failures before we can merge this. :(

hoxyq · 2023-03-27T10:40:33Z

I think we need to look at all the CI failures before we can merge this. :(

To fix JS ones we need to run prettier, or maybe cherry-pick #36568, where this line is changed

kelset · 2023-03-27T12:47:01Z

yeah don't worry too much about fixing CI with this PR, I was planning to try and tackle it with some local commits

cipolleschi · 2023-03-29T14:02:11Z

@hoxyq @kelset:

Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

hoxyq · 2023-03-29T14:06:09Z

@hoxyq @kelset:
Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

Yes
Will do it today

kelset · 2023-03-29T14:52:17Z

headsup: no need for this PR anymore, took care of cherry-picking directly while preparing the branch for RC1: https://github.com/facebook/react-native/commits/0.72-stable

CP here: 7700d7f

hoxyq · 2023-03-22T19:10:05Z

cherry-picking #36571 into 0.72-stable

Summary: Pull Request resolved: #36571 Changelog: [Internal] The problem is related to the way we use `js_srcs_dir` & `output_dir` options, one requires just relative path from current ruby script, other requires relative path from iOS root project (where the Podfile located) output_dir was introduced in D43304641 resulted into the issue, described in https://discord.com/channels/514829729862516747/1087736932953509958 allow-large-files Reviewed By: cipolleschi Differential Revision: D44294112 fbshipit-source-id: 47fcf510e203d0880e1f92ab6ead09f4b79cb4dd

github-actions · 2023-03-22T19:11:08Z

	Fails
🚫	❔ This pull request needs a description.
🚫	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

	Warnings
⚠️	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 08b61e9

analysis-bot · 2023-03-22T19:34:02Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,519,141	-10
android	hermes	armeabi-v7a	7,834,736	-494
android	hermes	x86	8,998,993	-168
android	hermes	x86_64	8,854,061	-257
android	jsc	arm64-v8a	9,141,836	+1,326
android	jsc	armeabi-v7a	8,333,483	+833
android	jsc	x86	9,196,423	+1,205
android	jsc	x86_64	9,454,250	+1,082

Base commit: cf43f9c
Branch: main

cipolleschi · 2023-03-27T10:27:12Z

I think we need to look at all the CI failures before we can merge this. :(

hoxyq · 2023-03-27T10:40:33Z

I think we need to look at all the CI failures before we can merge this. :(

To fix JS ones we need to run prettier, or maybe cherry-pick #36568, where this line is changed

kelset · 2023-03-27T12:47:01Z

yeah don't worry too much about fixing CI with this PR, I was planning to try and tackle it with some local commits

cipolleschi · 2023-03-29T14:02:11Z

@hoxyq @kelset:

Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

hoxyq · 2023-03-29T14:06:09Z

@hoxyq @kelset:
Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

Yes
Will do it today

kelset · 2023-03-29T14:52:17Z

headsup: no need for this PR anymore, took care of cherry-picking directly while preparing the branch for RC1: https://github.com/facebook/react-native/commits/0.72-stable

CP here: 7700d7f

hoxyq · 2023-03-22T19:10:05Z

cherry-picking #36571 into 0.72-stable

Summary: Pull Request resolved: #36571 Changelog: [Internal] The problem is related to the way we use `js_srcs_dir` & `output_dir` options, one requires just relative path from current ruby script, other requires relative path from iOS root project (where the Podfile located) output_dir was introduced in D43304641 resulted into the issue, described in https://discord.com/channels/514829729862516747/1087736932953509958 allow-large-files Reviewed By: cipolleschi Differential Revision: D44294112 fbshipit-source-id: 47fcf510e203d0880e1f92ab6ead09f4b79cb4dd

github-actions · 2023-03-22T19:11:08Z

	Fails
🚫	❔ This pull request needs a description.
🚫	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

	Warnings
⚠️	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 08b61e9

analysis-bot · 2023-03-22T19:34:02Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,519,141	-10
android	hermes	armeabi-v7a	7,834,736	-494
android	hermes	x86	8,998,993	-168
android	hermes	x86_64	8,854,061	-257
android	jsc	arm64-v8a	9,141,836	+1,326
android	jsc	armeabi-v7a	8,333,483	+833
android	jsc	x86	9,196,423	+1,205
android	jsc	x86_64	9,454,250	+1,082

Base commit: cf43f9c
Branch: main

cipolleschi · 2023-03-27T10:27:12Z

I think we need to look at all the CI failures before we can merge this. :(

hoxyq · 2023-03-27T10:40:33Z

I think we need to look at all the CI failures before we can merge this. :(

To fix JS ones we need to run prettier, or maybe cherry-pick #36568, where this line is changed

kelset · 2023-03-27T12:47:01Z

yeah don't worry too much about fixing CI with this PR, I was planning to try and tackle it with some local commits

cipolleschi · 2023-03-29T14:02:11Z

@hoxyq @kelset:

Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

hoxyq · 2023-03-29T14:06:09Z

@hoxyq @kelset:
Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

Yes
Will do it today

kelset · 2023-03-29T14:52:17Z

headsup: no need for this PR anymore, took care of cherry-picking directly while preparing the branch for RC1: https://github.com/facebook/react-native/commits/0.72-stable

CP here: 7700d7f

hoxyq · 2023-03-22T19:10:05Z

cherry-picking #36571 into 0.72-stable

Summary: Pull Request resolved: #36571 Changelog: [Internal] The problem is related to the way we use `js_srcs_dir` & `output_dir` options, one requires just relative path from current ruby script, other requires relative path from iOS root project (where the Podfile located) output_dir was introduced in D43304641 resulted into the issue, described in https://discord.com/channels/514829729862516747/1087736932953509958 allow-large-files Reviewed By: cipolleschi Differential Revision: D44294112 fbshipit-source-id: 47fcf510e203d0880e1f92ab6ead09f4b79cb4dd

github-actions · 2023-03-22T19:11:08Z

	Fails
🚫	❔ This pull request needs a description.
🚫	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

	Warnings
⚠️	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 08b61e9

analysis-bot · 2023-03-22T19:34:02Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,519,141	-10
android	hermes	armeabi-v7a	7,834,736	-494
android	hermes	x86	8,998,993	-168
android	hermes	x86_64	8,854,061	-257
android	jsc	arm64-v8a	9,141,836	+1,326
android	jsc	armeabi-v7a	8,333,483	+833
android	jsc	x86	9,196,423	+1,205
android	jsc	x86_64	9,454,250	+1,082

Base commit: cf43f9c
Branch: main

cipolleschi · 2023-03-27T10:27:12Z

I think we need to look at all the CI failures before we can merge this. :(

hoxyq · 2023-03-27T10:40:33Z

I think we need to look at all the CI failures before we can merge this. :(

To fix JS ones we need to run prettier, or maybe cherry-pick #36568, where this line is changed

kelset · 2023-03-27T12:47:01Z

yeah don't worry too much about fixing CI with this PR, I was planning to try and tackle it with some local commits

cipolleschi · 2023-03-29T14:02:11Z

@hoxyq @kelset:

Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

hoxyq · 2023-03-29T14:06:09Z

@hoxyq @kelset:
Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

Yes
Will do it today

kelset · 2023-03-29T14:52:17Z

headsup: no need for this PR anymore, took care of cherry-picking directly while preparing the branch for RC1: https://github.com/facebook/react-native/commits/0.72-stable

CP here: 7700d7f

hoxyq · 2023-03-22T19:10:05Z

cherry-picking #36571 into 0.72-stable

Summary: Pull Request resolved: #36571 Changelog: [Internal] The problem is related to the way we use `js_srcs_dir` & `output_dir` options, one requires just relative path from current ruby script, other requires relative path from iOS root project (where the Podfile located) output_dir was introduced in D43304641 resulted into the issue, described in https://discord.com/channels/514829729862516747/1087736932953509958 allow-large-files Reviewed By: cipolleschi Differential Revision: D44294112 fbshipit-source-id: 47fcf510e203d0880e1f92ab6ead09f4b79cb4dd

github-actions · 2023-03-22T19:11:08Z

	Fails
🚫	❔ This pull request needs a description.
🚫	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

	Warnings
⚠️	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 08b61e9

analysis-bot · 2023-03-22T19:34:02Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,519,141	-10
android	hermes	armeabi-v7a	7,834,736	-494
android	hermes	x86	8,998,993	-168
android	hermes	x86_64	8,854,061	-257
android	jsc	arm64-v8a	9,141,836	+1,326
android	jsc	armeabi-v7a	8,333,483	+833
android	jsc	x86	9,196,423	+1,205
android	jsc	x86_64	9,454,250	+1,082

Base commit: cf43f9c
Branch: main

cipolleschi · 2023-03-27T10:27:12Z

I think we need to look at all the CI failures before we can merge this. :(

hoxyq · 2023-03-27T10:40:33Z

I think we need to look at all the CI failures before we can merge this. :(

To fix JS ones we need to run prettier, or maybe cherry-pick #36568, where this line is changed

kelset · 2023-03-27T12:47:01Z

yeah don't worry too much about fixing CI with this PR, I was planning to try and tackle it with some local commits

cipolleschi · 2023-03-29T14:02:11Z

@hoxyq @kelset:

Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

hoxyq · 2023-03-29T14:06:09Z

@hoxyq @kelset:
Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

Yes
Will do it today

kelset · 2023-03-29T14:52:17Z

headsup: no need for this PR anymore, took care of cherry-picking directly while preparing the branch for RC1: https://github.com/facebook/react-native/commits/0.72-stable

CP here: 7700d7f

hoxyq · 2023-03-22T19:10:05Z

cherry-picking #36571 into 0.72-stable

Summary: Pull Request resolved: #36571 Changelog: [Internal] The problem is related to the way we use `js_srcs_dir` & `output_dir` options, one requires just relative path from current ruby script, other requires relative path from iOS root project (where the Podfile located) output_dir was introduced in D43304641 resulted into the issue, described in https://discord.com/channels/514829729862516747/1087736932953509958 allow-large-files Reviewed By: cipolleschi Differential Revision: D44294112 fbshipit-source-id: 47fcf510e203d0880e1f92ab6ead09f4b79cb4dd

github-actions · 2023-03-22T19:11:08Z

	Fails
🚫	❔ This pull request needs a description.
🚫	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

	Warnings
⚠️	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 08b61e9

analysis-bot · 2023-03-22T19:34:02Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,519,141	-10
android	hermes	armeabi-v7a	7,834,736	-494
android	hermes	x86	8,998,993	-168
android	hermes	x86_64	8,854,061	-257
android	jsc	arm64-v8a	9,141,836	+1,326
android	jsc	armeabi-v7a	8,333,483	+833
android	jsc	x86	9,196,423	+1,205
android	jsc	x86_64	9,454,250	+1,082

Base commit: cf43f9c
Branch: main

cipolleschi · 2023-03-27T10:27:12Z

I think we need to look at all the CI failures before we can merge this. :(

hoxyq · 2023-03-27T10:40:33Z

I think we need to look at all the CI failures before we can merge this. :(

To fix JS ones we need to run prettier, or maybe cherry-pick #36568, where this line is changed

kelset · 2023-03-27T12:47:01Z

yeah don't worry too much about fixing CI with this PR, I was planning to try and tackle it with some local commits

cipolleschi · 2023-03-29T14:02:11Z

@hoxyq @kelset:

Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

hoxyq · 2023-03-29T14:06:09Z

@hoxyq @kelset:
Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

Yes
Will do it today

kelset · 2023-03-29T14:52:17Z

headsup: no need for this PR anymore, took care of cherry-picking directly while preparing the branch for RC1: https://github.com/facebook/react-native/commits/0.72-stable

CP here: 7700d7f

hoxyq · 2023-03-22T19:10:05Z

cherry-picking #36571 into 0.72-stable

Summary: Pull Request resolved: #36571 Changelog: [Internal] The problem is related to the way we use `js_srcs_dir` & `output_dir` options, one requires just relative path from current ruby script, other requires relative path from iOS root project (where the Podfile located) output_dir was introduced in D43304641 resulted into the issue, described in https://discord.com/channels/514829729862516747/1087736932953509958 allow-large-files Reviewed By: cipolleschi Differential Revision: D44294112 fbshipit-source-id: 47fcf510e203d0880e1f92ab6ead09f4b79cb4dd

github-actions · 2023-03-22T19:11:08Z

	Fails
🚫	❔ This pull request needs a description.
🚫	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

	Warnings
⚠️	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 08b61e9

analysis-bot · 2023-03-22T19:34:02Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,519,141	-10
android	hermes	armeabi-v7a	7,834,736	-494
android	hermes	x86	8,998,993	-168
android	hermes	x86_64	8,854,061	-257
android	jsc	arm64-v8a	9,141,836	+1,326
android	jsc	armeabi-v7a	8,333,483	+833
android	jsc	x86	9,196,423	+1,205
android	jsc	x86_64	9,454,250	+1,082

Base commit: cf43f9c
Branch: main

cipolleschi · 2023-03-27T10:27:12Z

I think we need to look at all the CI failures before we can merge this. :(

hoxyq · 2023-03-27T10:40:33Z

I think we need to look at all the CI failures before we can merge this. :(

To fix JS ones we need to run prettier, or maybe cherry-pick #36568, where this line is changed

kelset · 2023-03-27T12:47:01Z

yeah don't worry too much about fixing CI with this PR, I was planning to try and tackle it with some local commits

cipolleschi · 2023-03-29T14:02:11Z

@hoxyq @kelset:

Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

hoxyq · 2023-03-29T14:06:09Z

@hoxyq @kelset:
Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

Yes
Will do it today

kelset · 2023-03-29T14:52:17Z

headsup: no need for this PR anymore, took care of cherry-picking directly while preparing the branch for RC1: https://github.com/facebook/react-native/commits/0.72-stable

CP here: 7700d7f

hoxyq · 2023-03-22T19:10:05Z

cherry-picking #36571 into 0.72-stable

Summary: Pull Request resolved: #36571 Changelog: [Internal] The problem is related to the way we use `js_srcs_dir` & `output_dir` options, one requires just relative path from current ruby script, other requires relative path from iOS root project (where the Podfile located) output_dir was introduced in D43304641 resulted into the issue, described in https://discord.com/channels/514829729862516747/1087736932953509958 allow-large-files Reviewed By: cipolleschi Differential Revision: D44294112 fbshipit-source-id: 47fcf510e203d0880e1f92ab6ead09f4b79cb4dd

github-actions · 2023-03-22T19:11:08Z

	Fails
🚫	❔ This pull request needs a description.
🚫	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

	Warnings
⚠️	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 08b61e9

analysis-bot · 2023-03-22T19:34:02Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,519,141	-10
android	hermes	armeabi-v7a	7,834,736	-494
android	hermes	x86	8,998,993	-168
android	hermes	x86_64	8,854,061	-257
android	jsc	arm64-v8a	9,141,836	+1,326
android	jsc	armeabi-v7a	8,333,483	+833
android	jsc	x86	9,196,423	+1,205
android	jsc	x86_64	9,454,250	+1,082

Base commit: cf43f9c
Branch: main

cipolleschi · 2023-03-27T10:27:12Z

I think we need to look at all the CI failures before we can merge this. :(

hoxyq · 2023-03-27T10:40:33Z

I think we need to look at all the CI failures before we can merge this. :(

To fix JS ones we need to run prettier, or maybe cherry-pick #36568, where this line is changed

kelset · 2023-03-27T12:47:01Z

yeah don't worry too much about fixing CI with this PR, I was planning to try and tackle it with some local commits

cipolleschi · 2023-03-29T14:02:11Z

@hoxyq @kelset:

Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

hoxyq · 2023-03-29T14:06:09Z

@hoxyq @kelset:
Do we still need this?
If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

Yes
Will do it today

kelset · 2023-03-29T14:52:17Z

headsup: no need for this PR anymore, took care of cherry-picking directly while preparing the branch for RC1: https://github.com/facebook/react-native/commits/0.72-stable

CP here: 7700d7f

hoxyq requested review from cipolleschi and kelset March 22, 2023 19:10