Support font-variant-ligatures values

[finnp]

Summary

The text style prop fontVariant in React Native is supposed to map to the CSS font-variant property. The CSS property is a short-hand for the following CSS properties:

• font-variant-alternates
• ✅ font-variant-caps
• font-variant-east-asian
• font-variant-emoji
• This PR 👉 font-variant-ligatures
• ✅ font-variant-numeric
• font-variant-position

Currently React Native only supports a subset of the values from font-variant-numeric and font-variant-caps.

This change increases the font-variant support by adding all values from font-variant-ligatures.

Changelog:

[iOS] [Added] - Add all fontVariant values for font-variant-ligatures
[Android] [Added] - Add all fontVariant values for font-variant-ligatures

Test Plan:

See #36740 (comment)

Resources

• Apple True Type Reference
• Webkit Source Code
• MDN Documentation
• Android TextView Documentation

[facebook-github-bot]

Hi @finnp!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[finnp]

This change is related to increasing compability with web, linking #34425

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[finnp]

Here's a table of all the values:

Name	Android TextView setting	iOS Feature Type	iOS Feature Selector
common-ligatures	'liga', 'clig'	kLigaturesType	kCommonLigaturesOnSelector
no-common-ligatures	'liga' off, 'clig' off	kLigaturesType	kCommonLigaturesOffSelector
discretionary-ligatures	'dlig'	kLigaturesType	kRareLigaturesOnSelector
no-discretionary-ligatures	'dlig' off	kLigaturesType	kRareLigaturesOffSelector
historical-ligatures	'hlig'	kLigaturesType	kHistoricalLigaturesOnSelector
no-historical-ligatures	'hlig' off	kLigaturesType	kHistoricalLigaturesOffSelector
contextual	'calt'	kContextualAlternatesType	kContextualAlternatesOnSelector
no-contextual	'calt off'	kContextualAlternatesType	kContextualAlternatesOffSelector

[necolas]

Stamping

[finnp]

Test Plan

I started testing iOS with a test project with the following code: https://github.com/finnp/react-native-font-test/blob/main/A

The results looks like this:

To find proper fonts to test I searched Github and also used https://otf.show/onum.

The same test on Android looks like this

Both screenshot look as expected ✅

[finnp]

@cortinico@necolas Is anything else needed here to get this merged?

[cortinico]

@cortinico@necolas Is anything else needed here to get this merged?

Yes we need CircleCI tests to be green before we can import this. Can I ask you to logoff/login to your CircleCI as your token got revoked. You can do so from this UI: https://app.circleci.com/pipelines/github/facebook/react-native/21404

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,586,914	-4,681
android	hermes	armeabi-v7a	7,901,311	-4,395
android	hermes	x86	9,069,452	-4,627
android	hermes	x86_64	8,926,266	-4,908
android	jsc	arm64-v8a	9,174,285	+1,537
android	jsc	armeabi-v7a	8,364,703	+1,050
android	jsc	x86	9,231,816	+1,693
android	jsc	x86_64	9,489,208	+1,058

Base commit: 58ee6b2
Branch: main

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cortinico merged this pull request in f0893cf.

[professorkolik]

When this can be released?

[cortinico]

When this can be released?

This will land in 0.73