Skip to content

fix(xcode): backport Xcode 14.3 fix to 70 - #36768

Merged
kelset merged 2 commits into
0.70-stablefrom
kelset/backport-xcode-143-fix-070
Apr 3, 2023
Merged

fix(xcode): backport Xcode 14.3 fix to 70#36768
kelset merged 2 commits into
0.70-stablefrom
kelset/backport-xcode-143-fix-070

Conversation

@kelset

Copy link
Copy Markdown
Contributor

Summary:

A quick attempt at a minimal fix for 0.70 for #36739, based on #36759

Changelog:

[IOS] [FIXED] - Fix React Codegen podspec to build on Xcode 14.3

Test Plan:

@kelset
kelset requested a review from cipolleschiApril 3, 2023 10:19
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner labels Apr 3, 2023

@cipolleschicipolleschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update also codegen_utils-test.rb, otherwise the CI is red.

Comment thread.circleci/config.yml Outdated
@kelset
kelset requested a review from cipolleschiApril 3, 2023 10:44
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: cb88e75
Branch: main

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,596,765-972,244
androidhermesarmeabi-v7a7,015,291-868,109
androidhermesx867,898,000-1,152,927
androidhermesx86_647,869,799-1,036,155
androidjscarm64-v8a9,478,152+310,421
androidjscarmeabi-v7a8,258,746-99,386
androidjscx869,417,499+193,101
androidjscx86_6410,008,733+526,497

Base commit: cb88e75
Branch: main

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ContributorA React Native contributor.p: MicrosoftPartner: MicrosoftPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kelset@analysis-bot@cipolleschi@facebook-github-bot