Uh oh!
There was an error while loading. Please reload this page.
Drop internal base config merge in metro-config - #36777
Closed
huntie wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
commented
Apr 3, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D44630645 |
Base commit: f7dc24c |
facebook-github-bot
commented
Apr 18, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D44630645 |
Summary: This is follow up of Metro release 0.76.2 to Bump versions in RN. Metro version: 0.76.2 Metro release notes: https://github.com/facebook/metro/releases/tag/v0.76.2 CLI Bump PR: react-native-community/cli#1910 CLI npm version: 12.0.0-alpha.3 Took changelog and testplan from #36793 ## Changelog: [General][Fixed] - Bump CLI to 12.0.0-alpha.3 and Metro to 0.76.2 Pull Request resolved: #36948 Test Plan: CircleCI Differential Revision: D45081058 Pulled By: jacdebug fbshipit-source-id: 0326fc407fe52809f75d07f26b23f5a7e69a3900
Summary: Pull Request resolved: #36777 Changelog: [Internal] Remove internal merge of `getDefaultConfig` (Metro base defaults) from `react-native/metro-config`. This is unnecessary given the config loading setup of RN CLI and Expo CLI, which use (or replicate) Metro's [`loadConfig`](https://github.com/facebook/metro/blob/1e47cb5b3cc289530fb18e402891f9d2816611dd/packages/metro-config/src/loadConfig.js#L182-L190) function — which will itself apply defaults appropriately. This relates to a previously-breaking behaviour documented in the test plan of react-native-community/cli#1896 (independently fixed and no longer load-bearing) (**read: no need to cherry pick this change**). https://pxl.cl/2B8NS While this has no effect under the fixed RN CLI setup, this is a worthwhile simplification to this package that better-aligns with current Metro tooling expectations. ## Notes - `getDefaultConfig` no longer returns `ConfigT` (full config), and instead returns `MetroConfig` (partial config). This is non-breaking with the expected API of a given `metro.config.js` file. Differential Revision: D44630645 fbshipit-source-id: fa2c9f81767659f1c4fa5a8abf267173b182b3d9
facebook-github-bot
commented
Apr 18, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D44630645 |
facebook-github-bot
commented
Apr 18, 2023
Contributor
This pull request has been merged in 1c4a505. |
This was referenced Jun 22, 2023
facebook-github-bot pushed a commit
that referenced
this pull request
Jun 28, 2023
Summary: Pull Request resolved: #38092 Reverts #36777. This is motivated by reducing user friction when the widespread assumption is for `react-native/metro-config` to export a complete Metro config, as with Expo/rnx-kit, and like previously understood uses of `metro-config`. See react/metro#1010 (comment) for further notes. Fixes: - react/metro#1010 - #38069 - kristerkari/react-native-svg-transformer#276 Note that we do not intend for `react-native/metro-config` to directly export `assetExts` etc — these can be accessed on the `resolver` property from the full config object. Changelog: [General][Changed] `react-native/metro-config` now includes all base config values from `metro-config` Reviewed By: robhogan Differential Revision: D47055973 fbshipit-source-id: 5ad23cc9700397110de5c0e81c7d76299761ef0a
kelset pushed a commit
that referenced
this pull request
Jun 28, 2023
Summary: Pull Request resolved: #38092 Reverts #36777. This is motivated by reducing user friction when the widespread assumption is for `react-native/metro-config` to export a complete Metro config, as with Expo/rnx-kit, and like previously understood uses of `metro-config`. See react/metro#1010 (comment) for further notes. Fixes: - react/metro#1010 - #38069 - kristerkari/react-native-svg-transformer#276 Note that we do not intend for `react-native/metro-config` to directly export `assetExts` etc — these can be accessed on the `resolver` property from the full config object. Changelog: [General][Changed] `react-native/metro-config` now includes all base config values from `metro-config` Reviewed By: robhogan Differential Revision: D47055973 fbshipit-source-id: 5ad23cc9700397110de5c0e81c7d76299761ef0a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Remove internal merge of
getDefaultConfig(Metro base defaults) from@react-native/metro-config. This is unnecessary given the config loading setup of RN CLI and Expo CLI, which use (or replicate) Metro'sloadConfigfunction — which will itself apply defaults appropriately.This relates to a previously-breaking behaviour documented in the test plan of react-native-community/cli#1896 (independently fixed and no longer load-bearing) (read: no need to cherry pick this change).
While this has no effect under the fixed RN CLI setup, this is a worthwhile simplification to this package that better-aligns with current Metro tooling expectations.
Notes
getDefaultConfigno longer returnsConfigT(full config), and instead returnsMetroConfig(partial config). This is non-breaking with the expected API of a givenmetro.config.jsfile.Differential Revision: D44630645