Uh oh!
There was an error while loading. Please reload this page.
Restore 'import' in default Package Exports conditions - #36902
Closed
huntie wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Apr 13, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D44962143 |
Base commit: 3b4037e |
facebook-github-bot
commented
Apr 14, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D44962143 |
Summary: Pull Request resolved: #36902 Reverts #36584. Since we've come across example packages (typically targeting Node.js) which only distribute ESM, we believe it's more helpful to return to asserting the `"import"` condition by default, for maximum compatibility. The above issue and comments outline the pros/cons. Changelog: [General][Changed] - Default condition set for experimental Package Exports is now ['require', 'import', 'react-native'] Metro changelog: [Experimental] Package Exports unstable_conditionNames now defaults to ['require', 'import'] Reviewed By: robhogan Differential Revision: D44962143 fbshipit-source-id: f110182f37c07bc3fa5a3e6f936148e44b30a536
facebook-github-bot
commented
Apr 14, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D44962143 |
facebook-github-bot
commented
Apr 14, 2023
Contributor
This pull request has been merged in 808b3c9. |
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Apr 14, 2023
Summary: X-link: react/react-native#36902 Reverts react/react-native#36584. Since we've come across example packages (typically targeting Node.js) which only distribute ESM, we believe it's more helpful to return to asserting the `"import"` condition by default, for maximum compatibility. The above issue and comments outline the pros/cons. Changelog: [General][Changed] - Default condition set for experimental Package Exports is now ['require', 'import', 'react-native'] Metro changelog: [Experimental] Package Exports unstable_conditionNames now defaults to ['require', 'import'] Reviewed By: robhogan Differential Revision: D44962143 fbshipit-source-id: 004172388916c902469b49cfc920ebe13c62c430
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reverts #36584.
Since we've come across example packages (typically targeting Node.js) which only distribute ESM, we believe it's more helpful to return to asserting the
"import"condition by default, for maximum compatibility. The above issue and comments outline the pros/cons.Changelog:
[General][Changed] - Default condition set for experimental Package Exports is now ['require', 'import', 'react-native']
Metro changelog: [Experimental] Package Exports unstable_conditionNames now defaults to ['require', 'import']
Differential Revision: D44962143