Uh oh!
There was an error while loading. Please reload this page.
Testing: Remove private headers from podspecs - #36993
Closed
NickGerleman wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Apr 20, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45139075 |
NickGerlemanforce-pushed
the
export-D45139075
branch
from
April 20, 2023 05:13
286895e to
d3a8277Comparefacebook-github-bot
commented
Apr 20, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45139075 |
NickGerlemanforce-pushed
the
export-D45139075
branch
from
April 20, 2023 05:49
d3a8277 to
abb0836Comparefacebook-github-bot
commented
Apr 20, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45139075 |
1 similar comment
facebook-github-bot
commented
Apr 20, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45139075 |
NickGerlemanforce-pushed
the
export-D45139075
branch
from
April 20, 2023 05:56
abb0836 to
0713dc4Comparefacebook-github-bot
commented
Apr 20, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45139075 |
NickGerlemanforce-pushed
the
export-D45139075
branch
from
April 20, 2023 06:34
0713dc4 to
d4cbac1CompareNickGerlemanforce-pushed
the
export-D45139075
branch
from
April 20, 2023 06:42
d4cbac1 to
8b15d28Comparefacebook-github-bot
commented
Apr 20, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45139075 |
1 similar comment
facebook-github-bot
commented
Apr 20, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45139075 |
NickGerlemanforce-pushed
the
export-D45139075
branch
from
April 20, 2023 06:50
8b15d28 to
d98e6edCompareNickGerleman added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 20, 2023
Summary: X-link: react/react-native#36993 Fabric relies on the private C++ internals of Yoga. This creates a conundrum in the open source build due to how header creation in Cocoapods works. 1. The default mechanism of specifying public headers needs to include the private headers for them to be made usable by fabric (by default) 2. Cocoapods will roll up all of the public headers when importing a module react/react-native#33381 fixed the Fabric Cocoapods build which ran into this. React Native relies on FlipperKit which relies on YogaKit, which in turn finally imports the Yoga podspec. Because YogaKit may use Swift, we can only expose the public Yoga C ABI. The first solution in that PR was to allow RN to access Yoga private headers, but this was changed to instead make all Yoga headers public, and to add ifdefs to all of them to no-op when included outside of a C++ environment. Talking to Kudo, we should be able to change back to the earlier approach in the PR, to instead expose the private headers to only RN. This lets us avoid exposing headers that we ideally wouldn't be, and lets us avoid the messy ifdefs in every Yoga header. But also I have no idea what I'm doing here, so this will be exported and built. Changelog: [Internal] Differential Revision: D45139075 fbshipit-source-id: ed4c73f465bb73d23a2b22d1fed340d3cd41fe45
NickGerlemanforce-pushed
the
export-D45139075
branch
from
April 20, 2023 22:22
d98e6ed to
e2dce06Comparefacebook-github-bot
commented
Apr 20, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45139075 |
Base commit: c1dea41 |
NickGerlemanforce-pushed
the
export-D45139075
branch
from
April 20, 2023 23:04
e2dce06 to
11ec935CompareNickGerlemanforce-pushed
the
export-D45139075
branch
from
April 21, 2023 23:58
95ed9f3 to
42d2548CompareNickGerlemanforce-pushed
the
export-D45139075
branch
from
April 22, 2023 00:04
42d2548 to
252af8aComparefacebook-github-bot
commented
Apr 22, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45139075 |
NickGerleman added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 24, 2023
Summary: Pull Request resolved: react#1252 X-link: react/react-native#36993 Fabric relies on the private C++ internals of Yoga. This creates a conundrum in the open source build due to how header creation in Cocoapods works. 1. The default mechanism of specifying public headers needs to include the private headers for them to be made usable by fabric (by default) 2. Cocoapods will roll up all of the public headers when importing a module react/react-native#33381 fixed the Fabric Cocoapods build which ran into this. React Native relies on FlipperKit which relies on YogaKit, which in turn finally imports the Yoga podspec. Because YogaKit may use Swift, we can only expose the public Yoga C ABI. The first solution in that PR was to allow RN to access Yoga private headers, but this was changed to instead make all Yoga headers public, and to add ifdefs to all of them to no-op when included outside of a C++ environment. Talking to Kudo, we should be able to change back to the earlier approach in the PR, to instead expose the private headers to only RN. This lets us avoid exposing headers that we ideally wouldn't be, and lets us avoid the messy ifdefs in every Yoga header. Changelog: [Internal] Differential Revision: D45139075 fbshipit-source-id: af4c7c82ca15276a72c024d98cf44134da27497d
NickGerleman added a commit
to NickGerleman/litho
that referenced
this pull request
Apr 24, 2023
Summary: X-link: react/yoga#1252 X-link: react/react-native#36993 Fabric relies on the private C++ internals of Yoga. This creates a conundrum in the open source build due to how header creation in Cocoapods works. 1. The default mechanism of specifying public headers needs to include the private headers for them to be made usable by fabric (by default) 2. Cocoapods will roll up all of the public headers when importing a module react/react-native#33381 fixed the Fabric Cocoapods build which ran into this. React Native relies on FlipperKit which relies on YogaKit, which in turn finally imports the Yoga podspec. Because YogaKit may use Swift, we can only expose the public Yoga C ABI. The first solution in that PR was to allow RN to access Yoga private headers, but this was changed to instead make all Yoga headers public, and to add ifdefs to all of them to no-op when included outside of a C++ environment. Talking to Kudo, we should be able to change back to the earlier approach in the PR, to instead expose the private headers to only RN. This lets us avoid exposing headers that we ideally wouldn't be, and lets us avoid the messy ifdefs in every Yoga header. Changelog: [Internal] Differential Revision: D45139075 fbshipit-source-id: 8f1878f602b732cdd928a1311a6bedf85afe12ca
facebook-github-bot
commented
Apr 24, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45139075 |
NickGerlemanforce-pushed
the
export-D45139075
branch
from
April 24, 2023 20:29
252af8a to
9b5e6e7Comparefacebook-github-bot
commented
Apr 25, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45139075 |
NickGerlemanforce-pushed
the
export-D45139075
branch
from
April 25, 2023 20:32
9b5e6e7 to
178b0dfCompareNickGerlemanforce-pushed
the
export-D45139075
branch
from
April 26, 2023 21:19
178b0df to
17f8666Comparefacebook-github-bot
commented
Apr 26, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45139075 |
Summary: X-link: facebook/litho#940 X-link: react/yoga#1252 Pull Request resolved: react#36993 Fabric relies on the private C++ internals of Yoga. This creates a conundrum in the open source build due to how header creation in Cocoapods works. 1. The default mechanism of specifying public headers needs to include the private headers for them to be made usable by fabric (by default) 2. Cocoapods will roll up all of the public headers when importing a module react#33381 fixed the Fabric Cocoapods build which ran into this. React Native relies on FlipperKit which relies on YogaKit, which in turn finally imports the Yoga podspec. Because YogaKit may use Swift, we can only expose the public Yoga C ABI. The first solution in that PR was to allow RN to access Yoga private headers, but this was changed to instead make all Yoga headers public, and to add ifdefs to all of them to no-op when included outside of a C++ environment. Talking to Kudo, we should be able to change back to the earlier approach in the PR, to instead expose the private headers to only RN. This lets us avoid exposing headers that we ideally wouldn't be, and lets us avoid the messy ifdefs in every Yoga header. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45139075 fbshipit-source-id: 96dab7b73f5164cb5103674d074d0759dad9c8b0
NickGerlemanforce-pushed
the
export-D45139075
branch
from
April 26, 2023 22:38
17f8666 to
a8d5224Comparefacebook-github-bot
commented
Apr 26, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45139075 |
facebook-github-bot pushed a commit
to react/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/litho#940 Pull Request resolved: #1252 X-link: react/react-native#36993 Fabric relies on the private C++ internals of Yoga. This creates a conundrum in the open source build due to how header creation in Cocoapods works. 1. The default mechanism of specifying public headers needs to include the private headers for them to be made usable by fabric (by default) 2. Cocoapods will roll up all of the public headers when importing a module react/react-native#33381 fixed the Fabric Cocoapods build which ran into this. React Native relies on FlipperKit which relies on YogaKit, which in turn finally imports the Yoga podspec. Because YogaKit may use Swift, we can only expose the public Yoga C ABI. The first solution in that PR was to allow RN to access Yoga private headers, but this was changed to instead make all Yoga headers public, and to add ifdefs to all of them to no-op when included outside of a C++ environment. Talking to Kudo, we should be able to change back to the earlier approach in the PR, to instead expose the private headers to only RN. This lets us avoid exposing headers that we ideally wouldn't be, and lets us avoid the messy ifdefs in every Yoga header. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45139075 fbshipit-source-id: 99152986a578f7aac8324dffe0e18c42a38cc6a5
facebook-github-bot pushed a commit
to facebook/litho
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: #940 X-link: react/yoga#1252 X-link: react/react-native#36993 Fabric relies on the private C++ internals of Yoga. This creates a conundrum in the open source build due to how header creation in Cocoapods works. 1. The default mechanism of specifying public headers needs to include the private headers for them to be made usable by fabric (by default) 2. Cocoapods will roll up all of the public headers when importing a module react/react-native#33381 fixed the Fabric Cocoapods build which ran into this. React Native relies on FlipperKit which relies on YogaKit, which in turn finally imports the Yoga podspec. Because YogaKit may use Swift, we can only expose the public Yoga C ABI. The first solution in that PR was to allow RN to access Yoga private headers, but this was changed to instead make all Yoga headers public, and to add ifdefs to all of them to no-op when included outside of a C++ environment. Talking to Kudo, we should be able to change back to the earlier approach in the PR, to instead expose the private headers to only RN. This lets us avoid exposing headers that we ideally wouldn't be, and lets us avoid the messy ifdefs in every Yoga header. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45139075 fbshipit-source-id: 99152986a578f7aac8324dffe0e18c42a38cc6a5
facebook-github-bot
commented
Apr 27, 2023
Contributor
This pull request has been merged in 33ebb5d. |
liujinye-sys pushed a commit
to open-vela/external_yoga
that referenced
this pull request
Dec 16, 2025
Summary: X-link: facebook/litho#940 Pull Request resolved: react/yoga#1252 X-link: react/react-native#36993 Fabric relies on the private C++ internals of Yoga. This creates a conundrum in the open source build due to how header creation in Cocoapods works. 1. The default mechanism of specifying public headers needs to include the private headers for them to be made usable by fabric (by default) 2. Cocoapods will roll up all of the public headers when importing a module react/react-native#33381 fixed the Fabric Cocoapods build which ran into this. React Native relies on FlipperKit which relies on YogaKit, which in turn finally imports the Yoga podspec. Because YogaKit may use Swift, we can only expose the public Yoga C ABI. The first solution in that PR was to allow RN to access Yoga private headers, but this was changed to instead make all Yoga headers public, and to add ifdefs to all of them to no-op when included outside of a C++ environment. Talking to Kudo, we should be able to change back to the earlier approach in the PR, to instead expose the private headers to only RN. This lets us avoid exposing headers that we ideally wouldn't be, and lets us avoid the messy ifdefs in every Yoga header. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45139075 fbshipit-source-id: 99152986a578f7aac8324dffe0e18c42a38cc6a5
openvela-robot pushed a commit
to open-vela/external_yoga
that referenced
this pull request
Apr 21, 2026
Summary: X-link: facebook/litho#940 Pull Request resolved: react/yoga#1252 X-link: react/react-native#36993 Fabric relies on the private C++ internals of Yoga. This creates a conundrum in the open source build due to how header creation in Cocoapods works. 1. The default mechanism of specifying public headers needs to include the private headers for them to be made usable by fabric (by default) 2. Cocoapods will roll up all of the public headers when importing a module react/react-native#33381 fixed the Fabric Cocoapods build which ran into this. React Native relies on FlipperKit which relies on YogaKit, which in turn finally imports the Yoga podspec. Because YogaKit may use Swift, we can only expose the public Yoga C ABI. The first solution in that PR was to allow RN to access Yoga private headers, but this was changed to instead make all Yoga headers public, and to add ifdefs to all of them to no-op when included outside of a C++ environment. Talking to Kudo, we should be able to change back to the earlier approach in the PR, to instead expose the private headers to only RN. This lets us avoid exposing headers that we ideally wouldn't be, and lets us avoid the messy ifdefs in every Yoga header. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45139075 fbshipit-source-id: 99152986a578f7aac8324dffe0e18c42a38cc6a5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Internal]
Differential Revision: D45139075