Skip to content

Use SurfaceRegistry globals whenever available - #37410

Closed
javache wants to merge 1 commit into
react:mainfrom
javache:export-D45736529
Closed

Use SurfaceRegistry globals whenever available#37410
javache wants to merge 1 commit into
react:mainfrom
javache:export-D45736529

Conversation

@javache

@javachejavache commented May 12, 2023

Copy link
Copy Markdown
Contributor

Summary:
Incremental adoption of new bridgeless API's, where they are semantically equivalent to the old one.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D45736529

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 12, 2023
@facebook-github-bot

facebook-github-bot commented May 12, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D45736529

@javachejavache mentioned this pull request May 12, 2023
Merged
@analysis-bot

analysis-bot commented May 12, 2023•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,744,596-187
androidhermesarmeabi-v7a8,056,236-176
androidhermesx869,235,407-518
androidhermesx86_649,086,282-544
androidjscarm64-v8a9,307,301-186
androidjscarmeabi-v7a8,496,536-173
androidjscx869,369,188-508
androidjscx86_649,624,180-532

Base commit: 5eadd93
Branch: main

javache added a commit to react/react that referenced this pull request May 12, 2023
@javache
[react-native] Always set RN$stopSurface (#26808)
a389046
## Summary
To support incremental adoption of bridgeless logic we want to default
to using these globals whenever they're available.
## How did you test this change?
react/react-native#37410
facebook-github-bot pushed a commit that referenced this pull request May 16, 2023
@javache@facebook-github-bot
Always set RN$stopSurface (#26808)
2c4e809
Summary:
## Summary
To support incremental adoption of bridgeless logic we want to default
to using these globals whenever they're available.
## How did you test this change?
#37410
DiffTrain build for commit react/react@a389046.
Reviewed By: hoxyq
Differential Revision: D45816985
Pulled By: javache
fbshipit-source-id: 592e0f1eb726261335f703502c74a2548f7da2bc
@facebook-github-bot

facebook-github-bot commented May 17, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D45736529

@facebook-github-bot

facebook-github-bot commented May 17, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D45736529

@facebook-github-bot

facebook-github-bot commented May 22, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D45736529

1 similar comment
@facebook-github-bot

facebook-github-bot commented May 23, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D45736529

@facebook-github-bot

facebook-github-bot commented May 25, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D45736529

@facebook-github-bot

facebook-github-bot commented May 26, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D45736529

@facebook-github-bot

facebook-github-bot commented May 26, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D45736529

@facebook-github-bot

facebook-github-bot commented May 26, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D45736529

@facebook-github-bot

facebook-github-bot commented May 30, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D45736529

@facebook-github-bot

facebook-github-bot commented May 30, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D45736529

1 similar comment
@facebook-github-bot

facebook-github-bot commented May 30, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D45736529

@javache@facebook-github-bot
Use SurfaceRegistry globals whenever available (react#37410)
8c5bce3
Summary:
Pull Request resolved: react#37410
Incremental adoption of new bridgeless API's, where they are semantically equivalent to the old one.
Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D45736529
fbshipit-source-id: 02337e4066ceca1de61fa1dd6d6a3285d7d97750
@facebook-github-bot

facebook-github-bot commented May 30, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D45736529

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label May 30, 2023
@facebook-github-bot

facebook-github-bot commented May 30, 2023

Copy link
Copy Markdown
Contributor

This pull request has been merged in da3dcd7.

@javache
javache deleted the export-D45736529 branch May 31, 2023 15:55
Szymon20000 pushed a commit to Szymon20000/react-native that referenced this pull request Jun 14, 2023
@javache@Szymon20000
Use SurfaceRegistry globals whenever available (react#37410)
c3e1c41
Summary:
Pull Request resolved: react#37410
Incremental adoption of new bridgeless API's, where they are semantically equivalent to the old one.
Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D45736529
fbshipit-source-id: e41f6840e7c329f6051530e53773fae760584842
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@javache@AndyPengc12
[react-native] Always set RN$stopSurface (react#26808)
96d8ed3
## Summary
To support incremental adoption of bridgeless logic we want to default
to using these globals whenever they're available.
## How did you test this change?
react/react-native#37410
Akshato07 pushed a commit to Akshato07/-Luffy that referenced this pull request Feb 20, 2025
@javache
[react-native] Always set RN$stopSurface (#26808)
be012b0
## Summary
To support incremental adoption of bridgeless logic we want to default
to using these globals whenever they're available.
## How did you test this change?
react/react-native#37410
DiffTrain build for commit react/react@a389046.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@javache@facebook-github-bot@analysis-bot