Uh oh!
There was an error while loading. Please reload this page.
Make RNTester use RCTAppDelegate - #37572
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
May 25, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46182888 |
Base commit: 551bbbc |
cipolleschiforce-pushed
the
export-D46182888
branch
from
May 25, 2023 13:27
b0cc1a9 to
689af81Comparefacebook-github-bot
commented
May 25, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46182888 |
1 similar comment
facebook-github-bot
commented
May 25, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46182888 |
cipolleschiforce-pushed
the
export-D46182888
branch
from
May 25, 2023 13:52
689af81 to
054a0eaComparefacebook-github-bot
commented
May 26, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46182888 |
cipolleschiforce-pushed
the
export-D46182888
branch
2 times, most recently
from
May 30, 2023 09:43
7993fc9 to
5708748Comparefacebook-github-bot
commented
May 30, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46182888 |
cipolleschiforce-pushed
the
export-D46182888
branch
from
May 30, 2023 09:59
5708748 to
922fee8Comparefacebook-github-bot
commented
May 30, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46182888 |
cipolleschiforce-pushed
the
export-D46182888
branch
from
May 30, 2023 10:05
922fee8 to
2cb3b43Comparefacebook-github-bot
commented
May 30, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46182888 |
Summary: Pull Request resolved: #37572 Currently, RNTester was using a completely custom AppDelegate and not leveraging the RCTAppDelegate we use in the OSS. This resulted in a misalignment between the two setups and duplicated work to test stuff internally furst and then in the OSS, with some more time needed to understand why one setup was working and the other wasn't. With this change, we are aligning the two, bringing RNTester closer to the OSS setup. There are still small differences, but we can iterate over those. ## Changelog: [iOS][Changed] - Make RNTester use RCTAppDelegate Reviewed By: cortinico Differential Revision: D46182888 fbshipit-source-id: c90fe3f58d75b59b90d15dbf612c54811555d347
cipolleschiforce-pushed
the
export-D46182888
branch
from
May 30, 2023 10:11
2cb3b43 to
a826e6bComparefacebook-github-bot
commented
May 30, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46182888 |
facebook-github-bot
commented
May 30, 2023
Contributor
This pull request has been merged in 680cbe7. |
Saadnajmi
commented
May 31, 2023
Contributor
Congrats! :D |
Szymon20000 pushed a commit
to Szymon20000/react-native
that referenced
this pull request
Jun 14, 2023
Summary: Pull Request resolved: react#37572 Currently, RNTester was using a completely custom AppDelegate and not leveraging the RCTAppDelegate we use in the OSS. This resulted in a misalignment between the two setups and duplicated work to test stuff internally furst and then in the OSS, with some more time needed to understand why one setup was working and the other wasn't. With this change, we are aligning the two, bringing RNTester closer to the OSS setup. There are still small differences, but we can iterate over those. ## Changelog: [iOS][Changed] - Make RNTester use RCTAppDelegate Reviewed By: cortinico Differential Revision: D46182888 fbshipit-source-id: 7c55b06de1a317b1f2d4ad0d18a390dc4d3356a4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, RNTester was using a completely custom AppDelegate and not leveraging the RCTAppDelegate we use in the OSS. This resulted in a misalignment between the two setups and duplicated work to test stuff internally furst and then in the OSS, with some more time needed to understand why one setup was working and the other wasn't.
With this change, we are aligning the two, bringing RNTester closer to the OSS setup. There are still small differences, but we can iterate over those.
Changelog:
[iOS][Changed] - Make RNTester use RCTAppDelegate
Differential Revision: D46182888