Uh oh!
There was an error while loading. Please reload this page.
[iOS] Fix Fabric issue with React-Core pod when Xcode project has multiple targets - #37581
Closed
douglowder wants to merge 1 commit into
Closed
[iOS] Fix Fabric issue with React-Core pod when Xcode project has multiple targets#37581douglowder wants to merge 1 commit into
douglowder wants to merge 1 commit into
Conversation
analysis-bot
commented
May 26, 2023
Base commit: dcb4eb0 |
facebook-github-bot
commented
May 29, 2023
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
May 30, 2023
Contributor
@cipolleschi merged this pull request in d3e3599. |
Szymon20000 pushed a commit
to Szymon20000/react-native
that referenced
this pull request
Jun 14, 2023
…targets (react#37581) Summary: In Xcode projects with multiple targets, and in particular when targets are for different platforms (e.g. iOS and macOS), Cocoapods may add a suffix to a Pod name like `React-Core`. When this happens, the code in `new_architecture.rb` (which was looking for a pod with exact name `React-Core`) would not add the preprocessor definitions for Fabric as expected. This change fixes this issue. Fixesreact#37102 . ## Changelog: [iOS] [Fixed] - Fix Fabric issue with React-Core pod when Xcode project has multiple targets Pull Request resolved: react#37581 Test Plan: Tested that this change fixes this issue which occurs 100% of the time in React Native TV projects. Reviewed By: dmytrorykun Differential Revision: D46264704 Pulled By: cipolleschi fbshipit-source-id: 8dfc8e342b5a110ef1f028636e01e5c5f2b6e2f0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In Xcode projects with multiple targets, and in particular when targets are for different platforms (e.g. iOS and macOS), Cocoapods may add a suffix to a Pod name like
React-Core.When this happens, the code in
new_architecture.rb(which was looking for a pod with exact nameReact-Core) would not add the preprocessor definitions for Fabric as expected.This change fixes this issue. Fixes#37102 .
Changelog:
[iOS] [Fixed] - Fix Fabric issue with React-Core pod when Xcode project has multiple targets
Test Plan:
Tested that this change fixes this issue which occurs 100% of the time in React Native TV projects.