Uh oh!
There was an error while loading. Please reload this page.
Cleanup, remove the PRODUCTION flag - #37882
Closed
cipolleschi wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
commented
Jun 14, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46726208 |
Base commit: b3cc19c |
facebook-github-bot
commented
Jun 14, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46726208 |
cipolleschiforce-pushed
the
export-D46726208
branch
2 times, most recently
from
June 14, 2023 16:18
d22042b to
22367dfComparefacebook-github-bot
commented
Jun 14, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46726208 |
Summary: Currently, we ask users to reinstall the pods using the `PRODUCTION` flag when they want to either profile their app or prepare a release. This way of working with the Release mode is not standard. One of the reason why we introduced it was to provide a different binary for Hermes and reinstalling the pods was the quickest way. With this change, we are deferring the decision on when Hermes should be installed for apps to the moment where the app is actually build by the system. These changes are not applied to Nightlies, when a specific tarball is passed to the cocoapods using the `HERMES_ENGINE_TARBALL_PATH` env var, and when hermes is built from source as in these scenarios we are usually not interested in building for Release. The system is also smart enough not to redownload the tarball if the configuration does not change. It assumes that the default configuration when the pods are installed for the first time is Debug. ## Changelog: [IOS] [CHANGED] - Download the right `hermes-engine` configuration at build time. Pull Request resolved: #37850 Test Plan: - CircleCI green for the Release template jobs - Tested locally modifying the `hermes-utils` to force specific versions. - Tested locally with RNTestProject Differential Revision: D46687390 Pulled By: cipolleschi fbshipit-source-id: f2193fc1fc6459c59681008d42314a049418aa1e
Summary: Pull Request resolved: #37882 After some progressive changes, we can finally remove the PRODUCTION flag from the codebase. ## Changelog: [iOS][Removed] - Remove PRODUCTION flag from iOS build logic Reviewed By: cortinico, dmytrorykun Differential Revision: D46726208 fbshipit-source-id: 46c2539ff3dfeb3791ca77ca244d1ef0a0d7023e
cipolleschiforce-pushed
the
export-D46726208
branch
from
June 14, 2023 16:56
22367df to
a0f99cbComparefacebook-github-bot
commented
Jun 14, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46726208 |
facebook-github-bot
commented
Jun 14, 2023
Contributor
This pull request has been merged in daa99fe. |
| } | ||
| // Assumption: if there is no stored last build, we assume that it was build for debug. | ||
| if (!fs.existsSync && configuration === 'Debug') { |
Contributor
There was a problem hiding this comment.
hi @cipolleschi, wondering if !fs.existsSync should be !fileExists instead?
ContributorAuthor
There was a problem hiding this comment.
ooops! 🤦
Well spot. I'll prepare a followup soon!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
After some progressive changes, we can finally remove the PRODUCTION flag from the codebase.
Changelog:
[iOS][Removed] - Remove PRODUCTION flag from iOS build logic
Differential Revision: D46726208