Uh oh!
There was an error while loading. Please reload this page.
Fix component type references in xplat - #37903
Closed
pieterv wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Jun 15, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46748791 |
1 similar comment
facebook-github-bot
commented
Jun 15, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46748791 |
facebook-github-bot
commented
Jun 15, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46748791 |
facebook-github-bot
commented
Jun 15, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46748791 |
Base commit: 8c9e375 |
facebook-github-bot
commented
Jun 15, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46748791 |
facebook-github-bot
commented
Jun 15, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46748791 |
Summary: Pull Request resolved: react#37903 The name "component" in a function type contexts will be banned in future versions of Flow (the same other keywords like typeof are today). This diff renames the offending usages in xplat files. Changelog: [Internal] Reviewed By: gkz Differential Revision: D46748791 fbshipit-source-id: 65994bc97d4930406b5e0b6a286d7fe08be8ff4a
facebook-github-bot
commented
Jun 15, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D46748791 |
facebook-github-bot
commented
Jun 15, 2023
Contributor
This pull request has been merged in 894b62c. |
adamaveray added a commit
to adamaveray/react-native
that referenced
this pull request
Jun 16, 2023
* main: (135 commits) translation auto-update for i18n/twilight.config.json on master Interop: Introduce Bridge proxy Remove okhttp internal util usage (react#37843) Update debian to fix CI while updating Node (react#37841) fix: foreground ripple crash on api < 23 (react#37901) Re-add the top level LICENSE file (react#37916) Deploy 0.209.0 to xplat (react#37921) Re-enable direct debugging with JSC on iOS 16.4+ (react#37914) add emitObjectProp in parser primitives (react#37904) Make React-utils its own pod (react#37659) feat: allow custom assignment of rootView to rootViewController (react#37873) Switch xplat prettier config to hermes plugin (react#37915) Set iOS AppState to inactive when app is launching (react#37690) Use `fileExists` in replace_hermes script (react#37911) (docs): fix license url (react#37909) Revert D46719890: Re-enable direct debugging with JSC on iOS 16.4+ Re-enable direct debugging with JSC on iOS 16.4+ (react#37874) Fix component type references in xplat (react#37903) Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader (react#37867) test runtime lifecycle callback (react#37897) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D46748791