Uh oh!
There was an error while loading. Please reload this page.
[0.72] Re-enable direct debugging with JSC on iOS 16.4+ - #37922
[0.72] Re-enable direct debugging with JSC on iOS 16.4+ #37922Saadnajmi wants to merge 1 commit into
Conversation
Summary: Pull Request resolved: react#37914 Restores react#37874 (reverted earlier today), with fix for `JSCRuntime.cpp` build on Android. Changelog: None Reviewed By: cortinico Differential Revision: D46762984 fbshipit-source-id: 6d56f81b9d0c928887860993b2b729ed96c0734c
|
analysis-bot
commented
Jun 15, 2023
Base commit: 8b1bf05 |
kelset
left a comment
There was a problem hiding this comment.
adding blocking comment to avoid that someone would merge it for now: we need to be careful because it seems that JSGlobalContextSetInspectable is only available starting with Xcode 14.3, so this would force folks to upgrade to it.
kelset
commented
Jun 19, 2023
for further details, check out the conversation here -> reactwg/react-native-releases#73 (comment) |
Saadnajmi
commented
Aug 16, 2023
Closing for now, I have a separate PR to make this commit compatible with Xcode 14.2 and If that merges, I'll re-open + pick that too. |
Cherry pick of 8b1bf05 to 0.72-stable