Skip to content

[0.72] Re-enable direct debugging with JSC on iOS 16.4+ - #37922

Closed
Saadnajmi wants to merge 1 commit into
react:0.72-stablefrom
Saadnajmi:jsc-72
Closed

[0.72] Re-enable direct debugging with JSC on iOS 16.4+ #37922
Saadnajmi wants to merge 1 commit into
react:0.72-stablefrom
Saadnajmi:jsc-72

Conversation

@Saadnajmi

Copy link
Copy Markdown
Contributor

Cherry pick of 8b1bf05 to 0.72-stable

Summary:
Pull Request resolved: react#37914
Restores react#37874 (reverted earlier today), with fix for `JSCRuntime.cpp` build on Android.
Changelog: None
Reviewed By: cortinico
Differential Revision: D46762984
fbshipit-source-id: 6d56f81b9d0c928887860993b2b729ed96c0734c
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Jun 15, 2023
@github-actions

Copy link
Copy Markdown
Fails
🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Warnings
⚠️📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 4fc475e

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,545,464-212,216
androidhermesarmeabi-v7a7,859,638-210,615
androidhermesx869,024,366-225,909
androidhermesx86_648,878,911-220,502
androidjscarm64-v8a9,145,051-173,782
androidjscarmeabi-v7a8,335,015-173,722
androidjscx869,198,310-184,009
androidjscx86_649,455,902-179,652

Base commit: 8b1bf05
Branch: main

@kelsetkelset left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding blocking comment to avoid that someone would merge it for now: we need to be careful because it seems that JSGlobalContextSetInspectable is only available starting with Xcode 14.3, so this would force folks to upgrade to it.

@kelset

Copy link
Copy Markdown
Contributor

for further details, check out the conversation here -> reactwg/react-native-releases#73 (comment)

@Saadnajmi

Copy link
Copy Markdown
ContributorAuthor

Closing for now, I have a separate PR to make this commit compatible with Xcode 14.2 and If that merges, I'll re-open + pick that too.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: MicrosoftPartner: MicrosoftPartnerPick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Saadnajmi@analysis-bot@kelset@facebook-github-bot@huntie