Uh oh!
There was an error while loading. Please reload this page.
feat: DrawerLayoutIos - #37928
Conversation
Base commit: 637ffb1 |
Gregoirevda
commented
Jun 16, 2023
To the reviewer, this is definitely WIP. I think we should have DrawerLayoutIos props aligned with DrawerLayoutAndroid and have the native code in How can I easily edit |
Pranav-yadav
commented
Jun 16, 2023
Just for ref: this is re-land of #37924 |
Pranav-yadav
commented
Jun 28, 2023
@cortinico can you ping someone to review this? |
@Pranav-yadav I started the refactor yesterday evening. I'm updating react views instead of the template and using the drawer in rn-tester app as it should be done. I'll also align the interface between both; especially the renderDrawer prop. There will be a new prop introduced 'visible' which would be responsible from Js to have the drawer view setup (open and close methods still responsible for showing it). As currently DrawerLayoutAndroid doesn't work with react navigation because a view doesn't unmount when navigating away. Fixes #37495 |
Pranav-yadav
commented
Jun 28, 2023
Sure. That seems great. |
| function DrawerDefault() { | ||
| return ( | ||
| <DrawerLayoutIos visible width={420}> | ||
| <View style={styles.modalContainer}></View> |
There was a problem hiding this comment.
⚠️ packages/rn-tester/js/examples/DrawerLayoutIos/DrawerLayoutIosExample.js line 19 – Empty components are self-closing (react/self-closing-comp)
javache
commented
Oct 31, 2023
Why should this component go in React Native core? Would it be better served as a community package? We have DrawerLayoutAndroid because it's a core Android SDK component, but it would be better if these weren't part of React Native's core. |
Summary:
Adding equivalent of existing DrawerLayoutAndroid.
I'm using the method added in PR #37873 for AppDelegate too only contain enhancements.
Native Drawer, with gestures and button to open and close.
It does have issues:
Changelog:
Pick one each for the category and type tags:
[IOS] [ADDED] - Adding LayoutDrawerIos
Test Plan:
Tested on simulator iPad Pro iOS 16.2