Skip to content

fix: Fix id prop not working on all Touchable components - #38169

Closed
gabrieldonadel wants to merge 1 commit into
react:mainfrom
gabrieldonadel:feat/add-id-to-touchables
Closed

fix: Fix id prop not working on all Touchable components#38169
gabrieldonadel wants to merge 1 commit into
react:mainfrom
gabrieldonadel:feat/add-id-to-touchables

Conversation

@gabrieldonadel

Copy link
Copy Markdown
Collaborator

Summary:

This PR fixed the id prop to being correctly mapped to nativeID on the following components: TouchableBounce, TouchableHighlight, TouchableNativeFeedback, and TouchableOpacity.

Closes#38117
Follow up of #34522

Changelog:

[GENERAL] [FIXED] - Fix id prop not working on TouchableBounce, TouchableHighlight, TouchableNativeFeedback, and TouchableOpacity

Test Plan:

Ensure that the id prop android tests pass on CircleCI

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner labels Jul 4, 2023
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a9,060,782+12
androidhermesarmeabi-v7a8,310,108+10
androidhermesx869,576,989+9
androidhermesx86_649,419,419+17
androidjscarm64-v8a9,613,528+43
androidjscarmeabi-v7a8,740,147+29
androidjscx869,700,468+39
androidjscx86_649,947,028+30

Base commit: e64373a
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions

Copy link
Copy Markdown

This pull request was successfully merged by @gabrieldonadel in 0e80fdb.

When will my fix make it into a release? | Upcoming Releases

@github-actionsgithub-actionsBot added the Merged This PR has been merged. label Jul 4, 2023
@gabrieldonadel
gabrieldonadel deleted the feat/add-id-to-touchables branch July 4, 2023 12:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.p: ExpoPartner: ExpoPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Id not working on Touchable*

3 participants

@gabrieldonadel@analysis-bot@facebook-github-bot