Update new_architecture.rb for React-ImageManager by billnbell · Pull Request #38247 · react/react-native

billnbell · 2023-07-07T21:49:54Z

Summary:

This added React-ImageManager to the use_frameworks! - a lot of rpm modules podspec need this.

Changelog:

[iOS] [FIXED] - Add React-ImageManager path to work with use_frameworks!

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests

Test Plan:

Should not be breaking - it will add to the header_search_paths React-ImageManager

facebook-github-bot · 2023-07-07T21:49:59Z

Hi @billnbell!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

billnbell · 2023-07-07T21:59:42Z

I signed the CLA

analysis-bot · 2023-07-07T22:15:50Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,885,449	-2
android	hermes	armeabi-v7a	7,935,798	+1
android	hermes	x86	9,281,970	-1
android	hermes	x86_64	9,185,456	-1
android	jsc	arm64-v8a	9,473,452	+0
android	jsc	armeabi-v7a	8,416,807	+0
android	jsc	x86	9,456,195	-1
android	jsc	x86_64	9,772,407	-1

Base commit: cbf9408
Branch: main

facebook-github-bot · 2023-07-07T23:07:04Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

cipolleschi · 2023-07-19T14:16:07Z

Hi there! Thanks for taking the time for doing this.
I think we have also to update the ruby tests, otherwise the CI will stay red. I think this is the test that needs to be updated.

facebook-github-bot · 2023-07-19T14:16:33Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

billnbell · 2023-07-20T03:49:24Z

Hi there! Thanks for taking the time for doing this.
I think we have also to update the ruby tests, otherwise the CI will stay red. I think this is the test that needs to be updated.

Yeah I added that one - let's see what the tests do

cipolleschi · 2023-07-20T12:08:04Z

/rebase

billnbell · 2023-07-21T03:33:23Z

OK rebased.

cipolleschi · 2023-07-21T10:04:11Z

I don't know what's going on with the CI. Main is green, I don't understand why this branch can't build correctly... :/

cipolleschi · 2023-07-21T10:07:23Z

/rebase

billnbell · 2023-07-22T00:24:59Z

What do you want me to do for /rebase ? I am not getting it.

billnbell · 2023-07-22T00:29:27Z

I merged from Facebook into main and merged that and rebased into patch-2. Should be rebased.

cipolleschi · 2023-07-24T10:48:32Z

Cool! Now the CI is running properly!

There are some ruby tests failures, which are expected!

You can run ruby tests locally on your machines:

navigate to: react-native/packages/react-native/scripts
run ./run_ruby_tests.sh

This will highlights the failures locally and you should be able to fix the tests and update the PR! ;)

Thanks again for taking the time to work on this!

billnbell · 2023-07-29T04:37:25Z

ok fixed those 2.

billnbell

ok good

cipolleschi · 2023-07-31T09:31:09Z

What do you want me to do for /rebase ? I am not getting it.

I'm sorry! 😓

Leaving a comment /rebase on a React Native PR triggers a github action that automatically rebase the PR on top of main, if possible.

That's why I was leaving those messages: I was asking the CI to rebase to rerun the CI and verify that it gets green!

facebook-github-bot · 2023-07-31T09:31:34Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

fix: test for new arch Squashed commit of the following: commit dce55b0 Author: Bill Bell <bbell@exclusiveresorts.com> Date: Wed Jul 19 21:48:27 2023 -0600 fix: test for new arch commit 51e8515 Author: William Bell <williambell9708@outlook.com> Date: Fri Jul 7 15:47:00 2023 -0600 Update new_architecture.rb for React-ImageManager

github-actions · 2023-07-31T11:07:39Z

This pull request was successfully merged by @billnbell in 8a63b91.

^{When will my fix make it into a release? | Upcoming Releases}

Summary: This added React-ImageManager to the use_frameworks! - a lot of rpm modules podspec need this. bypass-github-export-checks [iOS] [FIXED] - Add React-ImageManager path to work with use_frameworks! For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #38247 Test Plan: Should not be breaking - it will add to the header_search_paths React-ImageManager Reviewed By: dmytrorykun Differential Revision: D47593749 Pulled By: cipolleschi fbshipit-source-id: a66e90707e5fa73573deab1f04e8d8693869a90c

Summary: This added React-ImageManager to the use_frameworks! - a lot of rpm modules podspec need this. bypass-github-export-checks [iOS] [FIXED] - Add React-ImageManager path to work with use_frameworks! For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #38247 Test Plan: Should not be breaking - it will add to the header_search_paths React-ImageManager Reviewed By: dmytrorykun Differential Revision: D47593749 Pulled By: cipolleschi fbshipit-source-id: a66e90707e5fa73573deab1f04e8d8693869a90c chore(releases): improve bump oss script to allow less human errors (#38666) Summary: One of the limitations of the existing flow for the release crew is that they need to manually remember to publish all the other packages in the monorepo ahead of a new patch release - this PR modifies the logic for the bump-oss-version script (and makes it available via yarn) so that it will not run if: * there are git changes lying around * if some of the packages need a new release it required a bit of refactoring to extract some portions of the logic from the bump-all-package-versions script, but I think the end result is pretty decent. ## Changelog:  [INTERNAL] [CHANGED] - improve bump oss script to allow less human errors Pull Request resolved: #38666 Test Plan: * checkout this branch * comment L54 of bump-oss-version.js (to remove the check on the branch name) * run `yarn bump-all-updated-packages`, verify that it works and that it detects that some packages have unreleased code * run `yarn bump-oss-version -t asd -v asd` (the "fake" parameters are needed to pass the yargs check), verify that it will throw an error because it finds a package that has unreleased code Reviewed By: mdvacca Differential Revision: D48156963 Pulled By: cortinico fbshipit-source-id: 2473ad5a84578c5236c905fd9aa9a88113fe8d22 # Conflicts: # scripts/publish-npm.js re-add the file nit Revert "Update new_architecture.rb for React-ImageManager (#38247)" This reverts commit 645264e249f566ce87f6aaf462e029909302fd92.

…72 edition) (#38888) Co-authored-by: William Bell <williambell9708@outlook.com> resolved: #38247resolved: #38666

billnbell mentioned this pull request Jul 7, 2023
New Arch 0.72.1 issue with use_frameworks! - file not found.How to fix? #38188
Closed

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 7, 2023

billnbell mentioned this pull request Jul 12, 2023
Regression -- 0.72 fails to compile on iOS with use_frameworks! :linkage => :static when using pnpm #38140
Closed

github-actionsBot added the Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. label Jul 19, 2023

cortinico removed the Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. label Jul 20, 2023

github-actionsBot added the Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. label Jul 20, 2023

billnbell force-pushed the patch-2 branch 2 times, most recently from 9f2bd81 to 39f06ccCompare July 21, 2023 03:32

billnbell force-pushed the patch-2 branch 2 times, most recently from 51c9b3d to e1e1e76Compare July 29, 2023 04:48

billnbell commented Jul 29, 2023
View reviewed changes

billnbell force-pushed the patch-2 branch from dccce69 to e1e1e76Compare July 29, 2023 05:17

fix: ruby tests
cec92c2

github-actionsBotforce-pushed the patch-2 branch from bb8b926 to cec92c2Compare July 31, 2023 09:33

github-actionsBot added the Merged This PR has been merged. label Jul 31, 2023

facebook-github-bot closed this in 8a63b91Jul 31, 2023

cipolleschi mentioned this pull request Aug 10, 2023
[LOCAL] Fix Ruby Tests for 0.72 #38919
Closed

huntie pushed a commit that referenced this pull request Aug 18, 2023
chore(releases): improve bump oss script to allow less human errors (…
ef8ac7a
…72 edition) (#38888) Co-authored-by: William Bell <williambell9708@outlook.com> resolved: #38247resolved: #38666

Uh oh!

Conversation

billnbell commented Jul 7, 2023• edited by cipolleschi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

facebook-github-bot commented Jul 7, 2023

Action Required

Process

Uh oh!

billnbell commented Jul 7, 2023

Uh oh!

analysis-bot commented Jul 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jul 7, 2023

Uh oh!

cipolleschi commented Jul 19, 2023

Uh oh!

facebook-github-bot commented Jul 19, 2023

Uh oh!

billnbell commented Jul 20, 2023

Uh oh!

cipolleschi commented Jul 20, 2023

Uh oh!

billnbell commented Jul 21, 2023

Uh oh!

cipolleschi commented Jul 21, 2023

Uh oh!

cipolleschi commented Jul 21, 2023

Uh oh!

billnbell commented Jul 22, 2023

Uh oh!

billnbell commented Jul 22, 2023

Uh oh!

cipolleschi commented Jul 24, 2023

Uh oh!

billnbell commented Jul 29, 2023

Uh oh!

billnbell left a comment

Choose a reason for hiding this comment

Uh oh!

cipolleschi commented Jul 31, 2023

Uh oh!

facebook-github-bot commented Jul 31, 2023

Uh oh!

github-actionsBot commented Jul 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

billnbell commented Jul 7, 2023•
edited by cipolleschi
Loading

analysis-bot commented Jul 7, 2023•
edited
Loading