Uh oh!
There was an error while loading. Please reload this page.
Only apply isHighlighted native prop on iOS - #38642
Closed
rozele wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Jul 26, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D47800845 |
Base commit: 6cd1da9 |
Summary: Pull Request resolved: react#38642 isHighlighted is only used for iOS. Even macOS disables it (see microsoft#1346). This change ensures that the isHighlighted prop is only updated for iOS. ## Changelog: [General] [Fixed] - Avoids re-renders during text selection on desktop platforms by limiting native-only `isHighlighted` prop to iOS Reviewed By: lenaic, sammy-SC Differential Revision: D47800845 fbshipit-source-id: 9888db039f5b955da0c3dfa43dd304f3f4d01f19
facebook-github-bot
commented
Jul 26, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D47800845 |
facebook-github-bot
commented
Jul 26, 2023
Contributor
This pull request has been merged in 3d2fd4b. |
Saadnajmi pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jul 28, 2023
Summary: Pull Request resolved: react#38642 isHighlighted is only used for iOS. Even macOS disables it (see microsoft#1346). This change ensures that the isHighlighted prop is only updated for iOS. ## Changelog: [General] [Fixed] - Avoids re-renders during text selection on desktop platforms by limiting native-only `isHighlighted` prop to iOS Reviewed By: lenaic, sammy-SC Differential Revision: D47800845 fbshipit-source-id: af109be17027b2fbc9408e2ec9e1b841c709fe35
Saadnajmi pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jul 28, 2023
Summary: Pull Request resolved: react#38642 isHighlighted is only used for iOS. Even macOS disables it (see microsoft#1346). This change ensures that the isHighlighted prop is only updated for iOS. ## Changelog: [General] [Fixed] - Avoids re-renders during text selection on desktop platforms by limiting native-only `isHighlighted` prop to iOS Reviewed By: lenaic, sammy-SC Differential Revision: D47800845 fbshipit-source-id: af109be17027b2fbc9408e2ec9e1b841c709fe35
Saadnajmi added a commit
to microsoft/react-native-macos
that referenced
this pull request
Jul 28, 2023
Summary: Pull Request resolved: react#38642 isHighlighted is only used for iOS. Even macOS disables it (see #1346). This change ensures that the isHighlighted prop is only updated for iOS. ## Changelog: [General] [Fixed] - Avoids re-renders during text selection on desktop platforms by limiting native-only `isHighlighted` prop to iOS Reviewed By: lenaic, sammy-SC Differential Revision: D47800845 fbshipit-source-id: af109be17027b2fbc9408e2ec9e1b841c709fe35 Co-authored-by: Eric Rozell <ericroz@meta.com>
Saadnajmi added a commit
to microsoft/react-native-macos
that referenced
this pull request
Jul 28, 2023
Summary: Pull Request resolved: react#38642 isHighlighted is only used for iOS. Even macOS disables it (see #1346). This change ensures that the isHighlighted prop is only updated for iOS. ## Changelog: [General] [Fixed] - Avoids re-renders during text selection on desktop platforms by limiting native-only `isHighlighted` prop to iOS Reviewed By: lenaic, sammy-SC Differential Revision: D47800845 fbshipit-source-id: af109be17027b2fbc9408e2ec9e1b841c709fe35 Co-authored-by: Eric Rozell <ericroz@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
isHighlighted is only used for iOS. Even macOS disables it (see microsoft#1346).
This change ensures that the isHighlighted prop is only updated for iOS.
[General] [Fixed] - Avoids re-renders during text selection on desktop platforms by limiting native-only
isHighlightedprop to iOSReviewed By: lenaic, sammy-SC
Differential Revision: D47800845