Skip to content

Unify test-e2e command in rn-tester-e2e pacakge - #38701

Closed
szymonrybczak wants to merge 3 commits into
react:mainfrom
szymonrybczak:chore/unify-test-e2e-command
Closed

Unify test-e2e command in rn-tester-e2e pacakge#38701
szymonrybczak wants to merge 3 commits into
react:mainfrom
szymonrybczak:chore/unify-test-e2e-command

Conversation

@szymonrybczak

Copy link
Copy Markdown
Contributor

Summary:

This PR is small cleanup in scripts in rn-tester-e2e package, it creates unified script so that we can easily pass platform as an argument. Context: #36267 (comment)

Changelog:

[INTERNAL] [CHANGED] - Unify test-e2e command in rn-tester-e2e package

Test Plan:

CI Green ✅

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 31, 2023
@analysis-bot

analysis-bot commented Jul 31, 2023

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,889,842-264
androidhermesarmeabi-v7a7,939,948+1,833
androidhermesx869,287,275-490
androidhermesx86_649,191,472+2,053
androidjscarm64-v8a9,479,679+1,597
androidjscarmeabi-v7a8,422,764+3,682
androidjscx869,463,255+1,369
androidjscx86_649,780,163+3,906

Base commit: 5eaf28b
Branch: main

Comment threadpackages/rn-tester-e2e/scripts/run-e2e-tests.sh Outdated
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschicipolleschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @szymonrybczak, thank you a lot for this PR.

I left a couple of comments to improve code organization and relieve maintenance burden. Let me know what do you think!

@@ -0,0 +1,13 @@
#!/bin/bash

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that this is a new script. Can we have it in JS instead of in bash?

This will make it more portable and JS is easier to read and reason about. Also, we have linters and formatters for it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also... can we create a folder into scripts/e2e where we put these scripts? This will keep the folder more organized.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, changed.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also... can we create a folder into scripts/e2e where we put these scripts? This will keep the folder more organized.

Would you like me to move all scripts related to running e2e to this folder?

@szymonrybczak
szymonrybczakforce-pushed the chore/unify-test-e2e-command branch from 1fa4d5c to a358592CompareAugust 1, 2023 09:57

@cipolleschicipolleschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR!

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions

Copy link
Copy Markdown

This pull request was successfully merged by @szymonrybczak in 378aa72.

When will my fix make it into a release? | Upcoming Releases

@github-actionsgithub-actionsBot added the Merged This PR has been merged. label Aug 2, 2023
@szymonrybczak
szymonrybczak deleted the chore/unify-test-e2e-command branch August 2, 2023 11:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@szymonrybczak@analysis-bot@facebook-github-bot@cipolleschi@kelset