Skip to content

Enable partial media picking in Marketplace - #38880

Closed
luluwu2032 wants to merge 1 commit into
react:mainfrom
luluwu2032:export-D48171193
Closed

Enable partial media picking in Marketplace#38880
luluwu2032 wants to merge 1 commit into
react:mainfrom
luluwu2032:export-D48171193

Conversation

@luluwu2032

Copy link
Copy Markdown
Contributor

Summary:
Users who interact with your app on Android 14 devices can now grant partial access to their visual media library (Photos/Videos) when an app requests any visual media permissions (READ_MEDIA_IMAGES or READ_MEDIA_VIDEO) introduced in Android 13 (API level 33).

This diff allow enable the partial access via "READ_MEDIA_VISUAL_USER_SELECTED" in Marketplace photo picker

For Android 14 this diff request partial media access plus the normal access, there will be two return cases:

  • READ_MEDIA_VISUAL_USER_SELECTED is granted, READ_MEDIA_IMAGES and READ_MEDIA_VIDEO will be denied automatically, there is no need to check the later ones
  • READ_MEDIA_VISUAL_USER_SELECTED is denied, then check READ_MEDIA_IMAGES and READ_MEDIA_VIDEO

Reviewed By: NickGerleman

Differential Revision: D48171193

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Aug 9, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D48171193

@analysis-bot

analysis-bot commented Aug 9, 2023

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,895,437+105
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a9,487,029+6
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: c956a1b
Branch: main

Summary:
Pull Request resolved: react#38880
Users who interact with your app on Android 14 devices can now grant partial access to their visual media library (Photos/Videos) when an app requests any visual media permissions (READ_MEDIA_IMAGES or READ_MEDIA_VIDEO) introduced in Android 13 (API level 33).
This diff allow enable the partial access via "READ_MEDIA_VISUAL_USER_SELECTED" in Marketplace photo picker
For Android 14 this diff request partial media access plus the normal access, there will be two return cases:
- READ_MEDIA_VISUAL_USER_SELECTED is granted, READ_MEDIA_IMAGES and READ_MEDIA_VIDEO will be denied automatically, there is no need to check the later ones
- READ_MEDIA_VISUAL_USER_SELECTED is denied, then check READ_MEDIA_IMAGES and READ_MEDIA_VIDEO
Changelog:
[Android][Changed] - Enable partial media picking in Marketplace
Reviewed By: NickGerleman
Differential Revision: D48171193
fbshipit-source-id: 6e8d022a81b2e32108cd57b30ad5ce148be17c5a
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D48171193

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Aug 9, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in 72b9516.

luluwu2032 added a commit to luluwu2032/react-native that referenced this pull request Sep 20, 2023
Summary:
In react#38880 we added the new media permission "READ_MEDIA_VISUAL_USER_SELECTED", this diff added it for TS as well
Reviewed By: NickGerleman, mdvacca
Differential Revision: D49371798
facebook-github-bot pushed a commit that referenced this pull request Sep 20, 2023
Summary:
Pull Request resolved: #39563
In #38880 we added the new media permission "READ_MEDIA_VISUAL_USER_SELECTED", this diff added it for TS as well
Reviewed By: NickGerleman, mdvacca
Differential Revision: D49371798
fbshipit-source-id: ebc77872f5609b411904b04e684b804584eeaaa9
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@luluwu2032@facebook-github-bot@analysis-bot