Uh oh!
There was an error while loading. Please reload this page.
Convert ColorUtilTest to Kotlin - #38979
Conversation
bd05e9b to
2fa3ea2Compare
Base commit: 61861d2 |
cortinico
left a comment
There was a problem hiding this comment.
Thanks for sending this over @okwasniewski!
Can I ask you to follow-up on my comments and then we can import/merge this
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
65b199f to
fdfab0fCompareHey @cortinico thanks for the review. I've applied your suggestions. Edit: The test is still failing for some reason, I will debug this later. |
cortinico
commented
Aug 22, 2023
Converted to draft, please move it back once it's ready for review. The tests that are failing are: |
fdfab0f to
29e4f88Compareokwasniewski
commented
Aug 27, 2023
@cortinico Tests are now passing - ready for rereview |
facebook-github-bot
commented
Aug 29, 2023
@mdvacca has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
Converts ColorUtilTest to kotlin as requested in #38825
Changelog:
[INTERNAL] [CHANGED] - Convert ColorUtilTest to Kotlin
Test Plan:
./gradlew :packages:react-native:ReactAndroid:test.