Use runtime scheduler in the old architecture by cipolleschi · Pull Request #39057 · react/react-native

cipolleschi · 2023-08-17T11:41:47Z

Summary:

Changelog:

[iOS][Changed] - Use the runtime scheduler in the old Architecture

Facebook

Differential Revision: D48430129

facebook-github-bot · 2023-08-17T11:42:16Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-17T14:11:37Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-17T14:19:43Z

This pull request was exported from Phabricator. Differential Revision: D48430129

analysis-bot · 2023-08-17T14:43:00Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,965,565	+9
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	9,554,383	-43
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 45f7e11
Branch: main

facebook-github-bot · 2023-08-17T15:04:03Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-17T15:13:20Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-17T16:26:25Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-17T18:55:38Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-17T20:10:29Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-18T13:08:55Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-18T15:51:03Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-19T11:11:30Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-20T11:12:47Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-23T09:24:30Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-23T09:51:39Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-24T09:40:22Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-24T10:13:18Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-24T10:53:46Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-24T12:25:56Z

This pull request was exported from Phabricator. Differential Revision: D48430129

Summary: ## Changelog: [Internal] - Remove unused imports ## Facebook: Differential Revision: https://internalfb.com/D48429794 fbshipit-source-id: f03d6bc7f87469d537219999f9a494c2051cce18

Summary: Pull Request resolved: #39056 ## Changelog: [Internal] - Reduce header dependencies in RuntimeScheduler ## Facebook: Differential Revision: https://internalfb.com/D48429842 fbshipit-source-id: b6d544ffcf2d23b95e06c78492bf3a382666d1c9

Summary: ## Changelog: [iOS][Changed] - Extract RuntimeScheduler as separate cocoapod dependency ## Facebook: Differential Revision: https://internalfb.com/D48429964 fbshipit-source-id: 63240bb360de84fa4bba3b43d1ea5fa78bdde1f5

Summary: Pull Request resolved: #39057 ## Changelog: [iOS][Changed] - Use the runtime scheduler in the old Architecture ## Facebook bypass-github-export-checks Reviewed By: sammy-SC Differential Revision: D48430129 fbshipit-source-id: 7e3edda9676c4f37939cdec3ff412115ecaf69cc

facebook-github-bot · 2023-08-24T12:31:54Z

This pull request was exported from Phabricator. Differential Revision: D48430129

facebook-github-bot · 2023-08-24T12:36:07Z

This pull request has been merged in 2692f20.

…1284) Summary: There is a problem in the way that we check if Fabric is enabled inside `react_native_post_install`. https://github.com/facebook/react-native/blob/899e7cdb55197fc17a96a93af4f8bcc7519553c2/packages/react-native/scripts/react_native_pods.rb#L239 We're determining if fabric is enabled by checking if the `React-Fabric pod `is present, but since we always call `setup_fabric!(:react_native_path => prefix)` (#39057) inside `use_react_native` the `React-Fabric` pod is always present causing the `-DRN_FABRIC_ENABLED` flag to always be added to `project.pbxproj` even if the new arch is disabled. ## Changelog: [IOS] [FIXED] - Fix ios pod post_install logic for detecting if fabric is enabled Pull Request resolved: #41284 Test Plan: Run `use_react_native!(fabric => false)` should not add the `-DRN_FABRIC_ENABLED` flag to `project.pbxproj` Reviewed By: fkgozali Differential Revision: D50896487 Pulled By: cipolleschi fbshipit-source-id: 78154407ce52b09fd3a317b7dc64bd4bba56363e

…1284) Summary: There is a problem in the way that we check if Fabric is enabled inside `react_native_post_install`. https://github.com/facebook/react-native/blob/899e7cdb55197fc17a96a93af4f8bcc7519553c2/packages/react-native/scripts/react_native_pods.rb#L239 We're determining if fabric is enabled by checking if the `React-Fabric pod `is present, but since we always call `setup_fabric!(:react_native_path => prefix)` (react/react-native#39057) inside `use_react_native` the `React-Fabric` pod is always present causing the `-DRN_FABRIC_ENABLED` flag to always be added to `project.pbxproj` even if the new arch is disabled. [IOS] [FIXED] - Fix ios pod post_install logic for detecting if fabric is enabled Pull Request resolved: react/react-native#41284 Test Plan: Run `use_react_native!(fabric => false)` should not add the `-DRN_FABRIC_ENABLED` flag to `project.pbxproj` Reviewed By: fkgozali Differential Revision: D50896487 Pulled By: cipolleschi fbshipit-source-id: 78154407ce52b09fd3a317b7dc64bd4bba56363e

…1284) Summary: There is a problem in the way that we check if Fabric is enabled inside `react_native_post_install`. https://github.com/facebook/react-native/blob/899e7cdb55197fc17a96a93af4f8bcc7519553c2/packages/react-native/scripts/react_native_pods.rb#L239 We're determining if fabric is enabled by checking if the `React-Fabric pod `is present, but since we always call `setup_fabric!(:react_native_path => prefix)` (#39057) inside `use_react_native` the `React-Fabric` pod is always present causing the `-DRN_FABRIC_ENABLED` flag to always be added to `project.pbxproj` even if the new arch is disabled. [IOS] [FIXED] - Fix ios pod post_install logic for detecting if fabric is enabled Pull Request resolved: #41284 Test Plan: Run `use_react_native!(fabric => false)` should not add the `-DRN_FABRIC_ENABLED` flag to `project.pbxproj` Reviewed By: fkgozali Differential Revision: D50896487 Pulled By: cipolleschi fbshipit-source-id: 78154407ce52b09fd3a317b7dc64bd4bba56363e

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Aug 17, 2023

cipolleschi force-pushed the export-D48430129 branch from 6c30fb1 to 7e1d56dCompare August 17, 2023 14:11

cipolleschi force-pushed the export-D48430129 branch from 7e1d56d to afdc318Compare August 17, 2023 14:20

cipolleschi force-pushed the export-D48430129 branch from afdc318 to c307365Compare August 17, 2023 15:04

cipolleschi force-pushed the export-D48430129 branch from c307365 to 6e17e19Compare August 17, 2023 15:13

cipolleschi force-pushed the export-D48430129 branch from 6e17e19 to 560b666Compare August 17, 2023 16:26

cipolleschi force-pushed the export-D48430129 branch from 560b666 to 19935a6Compare August 17, 2023 18:56

cipolleschi force-pushed the export-D48430129 branch from 19935a6 to abf6619Compare August 17, 2023 20:11

cipolleschi force-pushed the export-D48430129 branch from abf6619 to 1c3b842Compare August 18, 2023 13:09

cipolleschi force-pushed the export-D48430129 branch from 1c3b842 to f05be6cCompare August 18, 2023 15:51

cipolleschi force-pushed the export-D48430129 branch 2 times, most recently from 2aad980 to 7002d5fCompare August 20, 2023 11:12

cipolleschi force-pushed the export-D48430129 branch from 7002d5f to a69deceCompare August 21, 2023 15:54

cipolleschi force-pushed the export-D48430129 branch from a69dece to 8dd1304Compare August 23, 2023 09:24

cipolleschi force-pushed the export-D48430129 branch from 8dd1304 to c0cd2c4Compare August 23, 2023 09:51

cipolleschi force-pushed the export-D48430129 branch from c0cd2c4 to 2fd865dCompare August 24, 2023 09:40

cipolleschi force-pushed the export-D48430129 branch from 2fd865d to 56641f1Compare August 24, 2023 10:13

cipolleschi force-pushed the export-D48430129 branch from 56641f1 to 3fc7627Compare August 24, 2023 10:54

cipolleschi force-pushed the export-D48430129 branch from 3fc7627 to 57a6258Compare August 24, 2023 12:26

Riccardo Cipolleschiand others added 4 commits August 24, 2023 05:29

Remove unused imports
771106c
Summary: ## Changelog: [Internal] - Remove unused imports ## Facebook: Differential Revision: https://internalfb.com/D48429794 fbshipit-source-id: f03d6bc7f87469d537219999f9a494c2051cce18

Add RuntimeScheduler dependency properly
30553d1
Summary: ## Changelog: [iOS][Changed] - Extract RuntimeScheduler as separate cocoapod dependency ## Facebook: Differential Revision: https://internalfb.com/D48429964 fbshipit-source-id: 63240bb360de84fa4bba3b43d1ea5fa78bdde1f5

cipolleschi force-pushed the export-D48430129 branch from 57a6258 to d38ffb5Compare August 24, 2023 12:32

facebook-github-bot closed this in 2692f20Aug 24, 2023

facebook-github-bot added the Merged This PR has been merged. label Aug 24, 2023

touchmarine mentioned this pull request Oct 7, 2023
🐛 Include of non-modular header inside framework module 'React.RCTRuntimeExecutorFromBridge' (iOS) dotintent/react-native-ble-plx#1107
Closed
2 tasks

gabrieldonadel mentioned this pull request Nov 1, 2023
Fix ios pod post_install logic for detecting if fabric is enabled #41284
Closed

Uh oh!

Conversation

cipolleschi commented Aug 17, 2023

Changelog:

Facebook

Uh oh!

facebook-github-bot commented Aug 17, 2023

Uh oh!

facebook-github-bot commented Aug 17, 2023

Uh oh!

facebook-github-bot commented Aug 17, 2023

Uh oh!

analysis-bot commented Aug 17, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Aug 17, 2023

Uh oh!

facebook-github-bot commented Aug 17, 2023

Uh oh!

facebook-github-bot commented Aug 17, 2023

Uh oh!

facebook-github-bot commented Aug 17, 2023

Uh oh!

facebook-github-bot commented Aug 17, 2023

Uh oh!

facebook-github-bot commented Aug 18, 2023

Uh oh!

facebook-github-bot commented Aug 18, 2023

Uh oh!

facebook-github-bot commented Aug 19, 2023

Uh oh!

facebook-github-bot commented Aug 20, 2023

Uh oh!

facebook-github-bot commented Aug 23, 2023

Uh oh!

facebook-github-bot commented Aug 23, 2023

Uh oh!

facebook-github-bot commented Aug 24, 2023

Uh oh!

facebook-github-bot commented Aug 24, 2023

Uh oh!

facebook-github-bot commented Aug 24, 2023

Uh oh!

facebook-github-bot commented Aug 24, 2023

Uh oh!

facebook-github-bot commented Aug 24, 2023

Uh oh!

facebook-github-bot commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

analysis-bot commented Aug 17, 2023•
edited
Loading