Skip to content

New RNtester e2e tests - #39117

Closed
elizabethberger wants to merge 30 commits into
react:mainfrom
elizabethberger:new-rntester-e2e-tests
Closed

New RNtester e2e tests#39117
elizabethberger wants to merge 30 commits into
react:mainfrom
elizabethberger:new-rntester-e2e-tests

Conversation

@elizabethberger

@elizabethbergerelizabethberger commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

Summary:

The motivation was to create more e2e tests that test other components in the RNTester app.
The list of components that have been tested is below:

ComponentTest is addedPlatform
DrawerLayoutAndroidNOAndroid
ActivityIndicatorYESiOS & Android
ButtonYESiOS & Android
FlatListYESiOS & Android
ImageNOiOS & Android
JSResponderHandlerYESiOS & Android
InputAccessoryViewNOiOS
KeyboardAvoidingViewYESiOS & Android
ModalYESiOS & Android
New App ScreenYESiOS & Android
PressableYESiOS & Android
RefreshControlYESiOS & Android
ScrollViewNOiOS & Android
ScrollViewSimpleExampleYESiOS & Android
SafeAreaViewNOiOS
ScrollViewAnimatedNOiOS & Android
ScrollViewIndicatorInsetsNOiOS
SectionListNOiOS & Android
StatusBarNOiOS & Android
SwipeableCardNOiOS & Android
SwitchNOiOS & Android
TextNOiOS & Android
TextInputNOiOS & Android
Touchable* and onPressNOiOS & Android
TextInputs with key propNOAndroid
TransparentHitTestExampleNOiOS
ViewNOiOS & Android
New Architecture ExamplesNOiOS & Android
Performance Comparison ExamplesNOiOS & Android

Changelog:

[General] [Added] - Added next component tests for RNTester

Test Plan:

Follow Readme file.

Test Result:

For iOS platform:

Screenshot 2023-08-22 at 18 08 28

For Android platform:

Screenshot 2023-08-22 at 18 13 47

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Hi @elzszulc!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 23, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@github-actions

github-actionsBot commented Aug 25, 2023

Copy link
Copy Markdown
Warnings
⚠️One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 93c6072

@elizabethberger
elizabethberger marked this pull request as ready for review August 28, 2023 11:30
@elizabethberger

elizabethberger commented Aug 28, 2023

Copy link
Copy Markdown
ContributorAuthor

I added a batch of tests to RNtester. Can you check the code of my changes? Thank you in advance!
@kelset@szymonrybczak@thymikee@cortinico@cipolleschi

@facebook-github-botfacebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 28, 2023

@kelsetkelset left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I've run it locally and all works as expected 👏

it's a :shipit: for me, now I guess we need to wait for @cortinico / @cipolleschi to import and land

@kelsetkelset added Partner p: Callstack Partner: Callstack labels Aug 30, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschicipolleschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elzszulc, thanks for taking the time for doing this.
I'll try to land it now.

The PR is quite big and we had a bit of trouble reviewing it. Would it be possilble for the next time to split it in multiple PRs? Perhaps you can create a new branch from the previous one, and use some numbering in the title, so we can import them and land them in order to avoid conflicts!

@github-actions

Copy link
Copy Markdown

This pull request was successfully merged by @elzszulc in aa2a0c1.

When will my fix make it into a release? | Upcoming Releases

@github-actionsgithub-actionsBot added the Merged This PR has been merged. label Sep 1, 2023
@elizabethberger

Copy link
Copy Markdown
ContributorAuthor

The PR is quite big and we had a bit of trouble reviewing it. Would it be possilble for the next time to split it in multiple PRs? Perhaps you can create a new branch from the previous one, and use some numbering in the title, so we can import them and land them in order to avoid conflicts!

@cipolleschi Yes, thank you for pointing this out! Definitely, next time I will break my work into smaller parts. I'm sorry for the trouble.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.p: CallstackPartner: CallstackPartnerShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@elizabethberger@facebook-github-bot@cipolleschi@kelset