Uh oh!
There was an error while loading. Please reload this page.
Update devtoolsFrontendUrl value in target list - #39122
Closed
huntie wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Aug 23, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48561005 |
Summary: Pull Request resolved: #39122 Updates the `devtoolsFrontendUrl` value returned in the `/json/list` endpoint, to match the fixed DevTools frontend revision we set for `/open-debugger` — which now uses this as the source of truth. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48561005 fbshipit-source-id: 3221124fc6083b3d48d315cf2c5970f3c4ffc9bd
facebook-github-bot
commented
Aug 23, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48561005 |
This pull request was successfully merged by @huntie in f9e936e. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
commented
Aug 23, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48561005 |
facebook-github-bot pushed a commit
that referenced
this pull request
Aug 31, 2023
Summary: Pull Request resolved: #39242 Reverts external behaviour of #39122. - `/json/list` once again returns the built-in `devtools://devtools/bundled/js_app.html` URL — effectively freezing the current experience in Flipper. - `/open-debugger` continues to use the *new* frontend via `getDevToolsFrontendUrl`. - *Eventually*, we'll want to align this as the returned `devtoolsFrontendUrl` value once Flipper is out of the picture. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48868767 fbshipit-source-id: 088ecebffa6ce45cb9bed44e3b02df4b7b471068
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Updates the
devtoolsFrontendUrlvalue returned in the/json/listendpoint, to match the fixed DevTools frontend revision we set for/open-debugger— which now uses this as the source of truth.Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D48561005