Skip to content

feat: add ValueUnit struct - #39150

Closed
intergalacticspacehighway wants to merge 2 commits into
react:mainfrom
intergalacticspacehighway:feat/add-value-unit-struct
Closed

feat: add ValueUnit struct#39150
intergalacticspacehighway wants to merge 2 commits into
react:mainfrom
intergalacticspacehighway:feat/add-value-unit-struct

Conversation

@intergalacticspacehighway

@intergalacticspacehighwayintergalacticspacehighway commented Aug 24, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary:

Adds a new struct ValueUnit for #38559. This is a simple version of YGValue struct to hold values that have percentage and point as units.

Changelog:

[INTERNAL] [ADDED] - ValueUnit struct

Test Plan:

Pod install and build the rn-tester ios app

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 24, 2023
@intergalacticspacehighwayintergalacticspacehighway mentioned this pull request Aug 24, 2023
Closed
@analysis-bot

analysis-bot commented Aug 24, 2023•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,959,324-210
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a9,554,403+104
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: 8955bfb
Branch: main

NickGerleman
NickGerleman reviewed Aug 24, 2023
View reviewed changes
Comment threadpackages/react-native/ReactCommon/react/renderer/graphics/ValueUnit.h Outdated
NickGerleman
NickGerleman reviewed Aug 24, 2023
View reviewed changes
Comment threadpackages/react-native/ReactCommon/react/renderer/graphics/ValueUnit.h Outdated
@intergalacticspacehighway@NickGerleman
Apply suggestions from code review
696621e
Co-authored-by: Nick Gerleman <nick@nickgerleman.com>
@facebook-github-bot

facebook-github-bot commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@javache

javache commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

I think this PR should be "stacked" on the other transform-origin changes, so it can be introduced with an immediate use-case.

@intergalacticspacehighway

intergalacticspacehighway commented Aug 25, 2023

Copy link
Copy Markdown
ContributorAuthor

@javache merged this branch here - 0f27a0c and usage - a30ed3d. Feel free to close this PR!

@intergalacticspacehighway
intergalacticspacehighway deleted the feat/add-value-unit-struct branch August 9, 2024 22:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@NickGerlemanNickGerlemanNickGerleman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@intergalacticspacehighway@analysis-bot@facebook-github-bot@javache@NickGerleman