Uh oh!
There was an error while loading. Please reload this page.
Simplify shadow node fragment placeholders - #39239
Closed
javache wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Aug 31, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48867013 |
Base commit: a2dc4d7 |
Summary: We can avoid static guards and heap allocation memory by forcing a default initialized shared_ptr (which is constexpr), and telling the compiler to not bother with registering a destructor, as these shared_ptr will never hold a value. Changelog: [Internal] Reviewed By: rshest Differential Revision: D48867013
javacheforce-pushed
the
export-D48867013
branch
from
September 1, 2023 14:37
77c7698 to
3827c96Comparefacebook-github-bot
commented
Sep 1, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48867013 |
facebook-github-bot
commented
Sep 1, 2023
Contributor
This pull request has been merged in a69bc7f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We can avoid static guards and heap allocation memory by forcing a default initialized shared_ptr (which is constexpr), and telling the compiler to not bother with registering a destructor, as these shared_ptr will never hold a value.
Changelog: [Internal]
Differential Revision: D48867013