Skip to content

Remove superfluous JSI import? - #39247

Closed
ethansinjin wants to merge 1 commit into
react:mainfrom
ethansinjin:export-D47380384
Closed

Remove superfluous JSI import?#39247
ethansinjin wants to merge 1 commit into
react:mainfrom
ethansinjin:export-D47380384

Conversation

@ethansinjin

@ethansinjinethansinjin commented Aug 31, 2023•
edited
Loading

Copy link
Copy Markdown

Summary:
Seems to be invalid given the other jsi import

Changelog:

[Internal] - Remove invalid import

Reviewed By: NickGerleman

Differential Revision: D47380384

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 31, 2023
@facebook-github-bot

facebook-github-bot commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47380384

@analysis-bot

analysis-bot commented Aug 31, 2023•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,963,073+2
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a9,555,938-58
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: a2dc4d7
Branch: main

@facebook-github-bot

facebook-github-bot commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47380384

@facebook-github-bot

facebook-github-bot commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47380384

@facebook-github-bot

facebook-github-bot commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47380384

@facebook-github-bot

facebook-github-bot commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47380384

@facebook-github-bot

facebook-github-bot commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47380384

@facebook-github-bot

facebook-github-bot commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47380384

@facebook-github-bot

facebook-github-bot commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47380384

@ethansinjin@facebook-github-bot
Remove superfluous JSI import? (react#39247)
199f759
Summary:
Seems to be invalid given the other jsi import
## Changelog:
[Internal] - Remove invalid import
Reviewed By: NickGerleman
Differential Revision: D47380384
@facebook-github-bot

facebook-github-bot commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47380384

@facebook-github-bot

facebook-github-bot commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

This pull request has been merged in 92d8428.

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Sep 1, 2023
@ethansinjin
ethansinjin deleted the export-D47380384 branch September 1, 2023 15:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethansinjin@facebook-github-bot@analysis-bot