Uh oh!
There was an error while loading. Please reload this page.
Fork ReactCommon/hermes/inspector as inspector-modern - #39253
Closed
motiz88 wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Sep 1, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48897203 |
motiz88 added a commit
to motiz88/hermes
that referenced
this pull request
Sep 1, 2023
Summary: X-link: react/react-native#39253 Changelog: [Internal] Forks `ReactCommon/hermes/inspector` → `ReactCommon/hermes/inspector-modern`. More changes to `inspector-modern` will come in subsequent diffs. The Gradle, CocoaPods and Buck builds of React Native have been updated to use `inspector-modern` everywhere. The code in `ReactCommon/hermes/inspector` is thus **deprecated** and unused in the open source build, and will be deleted in an upcoming diff (likely before the 0.73 cut). NOTE: The reason we're not immediately deleting `ReactCommon/hermes/inspector` is that there are a handful of references to it in Meta's internal monorepo (*outside of React Native*) that we are in the process of migrating away. Once we've deleted the existing `ReactCommon/hermes/inspector`, we *may* rename `inspector-modern` back to `inspector`. Differential Revision: D48897203
facebook-github-bot
commented
Sep 1, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48897203 |
motiz88force-pushed
the
export-D48897203
branch
from
September 1, 2023 09:42
7e26eb1 to
e81160eCompare
Base commit: 7a0d2a0 |
motiz88 added a commit
to motiz88/hermes
that referenced
this pull request
Sep 1, 2023
Summary: X-link: react/react-native#39253 Changelog: [Internal] Forks `ReactCommon/hermes/inspector` → `ReactCommon/hermes/inspector-modern`. More changes to `inspector-modern` will come in subsequent diffs. The Gradle, CocoaPods and Buck builds of React Native have been updated to use `inspector-modern` everywhere. The code in `ReactCommon/hermes/inspector` is thus **deprecated** and unused in the open source build, and will be deleted in an upcoming diff (likely before the 0.73 cut). NOTE: The reason we're not immediately deleting `ReactCommon/hermes/inspector` is that there are a handful of references to it in Meta's internal monorepo (*outside of React Native*) that we are in the process of migrating away. Once we've deleted the existing `ReactCommon/hermes/inspector`, we *may* rename `inspector-modern` back to `inspector`. Differential Revision: D48897203
motiz88 added a commit
to motiz88/hermes
that referenced
this pull request
Sep 1, 2023
Summary: X-link: react/react-native#39253 Changelog: [Internal] Forks `ReactCommon/hermes/inspector` → `ReactCommon/hermes/inspector-modern`. More changes to `inspector-modern` will come in subsequent diffs. The Gradle, CocoaPods and Buck builds of React Native have been updated to use `inspector-modern` everywhere. The code in `ReactCommon/hermes/inspector` is thus **deprecated** and unused in the open source build, and will be deleted in an upcoming diff (likely before the 0.73 cut). NOTE: The reason we're not immediately deleting `ReactCommon/hermes/inspector` is that there are a handful of references to it in Meta's internal monorepo (*outside of React Native*) that we are in the process of migrating away. Once we've deleted the existing `ReactCommon/hermes/inspector`, we *may* rename `inspector-modern` back to `inspector`. Differential Revision: D48897203
facebook-github-bot
commented
Sep 1, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48897203 |
motiz88force-pushed
the
export-D48897203
branch
from
September 1, 2023 11:20
e81160e to
8316056Comparemotiz88 added a commit
to motiz88/hermes
that referenced
this pull request
Sep 1, 2023
Summary: X-link: react/react-native#39253 Changelog: [Internal] Forks `ReactCommon/hermes/inspector` → `ReactCommon/hermes/inspector-modern`. More changes to `inspector-modern` will come in subsequent diffs. The Gradle, CocoaPods and Buck builds of React Native have been updated to use `inspector-modern` everywhere. The code in `ReactCommon/hermes/inspector` is thus **deprecated** and unused in the open source build, and will be deleted in an upcoming diff (likely before the 0.73 cut). NOTE: The reason we're not immediately deleting `ReactCommon/hermes/inspector` is that there are a handful of references to it in Meta's internal monorepo (*outside of React Native*) that we are in the process of migrating away. Once we've deleted the existing `ReactCommon/hermes/inspector`, we *may* rename `inspector-modern` back to `inspector`. Differential Revision: D48897203
facebook-github-bot
commented
Sep 1, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48897203 |
motiz88force-pushed
the
export-D48897203
branch
from
September 1, 2023 12:18
8316056 to
095e542Comparefacebook-github-bot
commented
Sep 1, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48897203 |
motiz88force-pushed
the
export-D48897203
branch
from
September 1, 2023 12:58
095e542 to
aec04c6Comparefacebook-github-bot
commented
Sep 1, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48897203 |
motiz88force-pushed
the
export-D48897203
branch
from
September 1, 2023 19:43
aec04c6 to
7fb3b58Comparefacebook-github-bot
commented
Sep 2, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48897203 |
motiz88force-pushed
the
export-D48897203
branch
from
September 2, 2023 08:33
7fb3b58 to
4531b3cCompareSummary: Pull Request resolved: react#39253 X-link: facebook/hermes#1112 Changelog: [Internal] Forks `ReactCommon/hermes/inspector` → `ReactCommon/hermes/inspector-modern`. More changes to `inspector-modern` will come in subsequent diffs. The Gradle, CocoaPods and Buck builds of React Native have been updated to use `inspector-modern` everywhere. The code in `ReactCommon/hermes/inspector` is thus **deprecated** and unused in the open source build, and will be deleted in an upcoming diff (likely before the 0.73 cut). NOTE: The reason we're not immediately deleting `ReactCommon/hermes/inspector` is that there are a handful of references to it in Meta's internal monorepo (*outside of React Native*) that we are in the process of migrating away. Once we've deleted the existing `ReactCommon/hermes/inspector`, we *may* rename `inspector-modern` back to `inspector`. Differential Revision: D48897203 fbshipit-source-id: dd3c262c9ca0bb88163bfcf5cc51826085fed5e1
facebook-github-bot
commented
Sep 2, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48897203 |
motiz88force-pushed
the
export-D48897203
branch
from
September 2, 2023 08:47
4531b3c to
2a576d1Compare
Generated by 🚫 dangerJS against 4531b3ca6ed97033636b8f88a09b9c89c3b4db29 |
This pull request was successfully merged by @motiz88 in 4dea635. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/hermes#1112
Changelog: [Internal]
Forks
ReactCommon/hermes/inspector→ReactCommon/hermes/inspector-modern. More changes toinspector-modernwill come in subsequent diffs.The Gradle, CocoaPods and Buck builds of React Native have been updated to use
inspector-moderneverywhere. The code inReactCommon/hermes/inspectoris thus deprecated and unused in the open source build, and will be deleted in an upcoming diff (likely before the 0.73 cut).NOTE: The reason we're not immediately deleting
ReactCommon/hermes/inspectoris that there are a handful of references to it in Meta's internal monorepo (outside of React Native) that we are in the process of migrating away. Once we've deleted the existingReactCommon/hermes/inspector, we may renameinspector-modernback toinspector.Differential Revision: D48897203