[Cocoapods] min_ios_version_supported -> min_supported_versions

[Saadnajmi]

Summary:

One of the most common diffs we have in React Native macOS is simply extending the platforms key Inside every pod spec to include macOS. React Native tvOS does the same to add tvOS. In the future, React Native may support visionOS, at which point we do the same thing again. Let's define a min_supported_versions hash that can be overridden at one place that is extensible to more platforms, instead of just specifying min_ios_version_supported.

Note: In doing this change, I have set it that React-Hermes.podspec doesn't build for macOS anymore. I think this is safe, since anyone using Hermes on macOS was probably using React Native macOS where we already have a diff to add macOS back?

Changelog:

[IOS] [CHANGED] - Add min_supported_versions helper to cocoa pods scripts

Test Plan:

CI should pass.

[dmytrorykun]

@Saadnajmi could you please rebase on the latest main, as there were unrelated CircleCI failures recently.

[Saadnajmi]

@Saadnajmi could you please rebase on the latest main, as there were unrelated CircleCI failures recently.

Uuuh, I seem to have messed up the branch a bit with the rebase, I'll fix shortly

[facebook-github-bot]

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,962,478	-43
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	9,554,231	-29
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: ef3e771
Branch: main

[Saadnajmi]

Should be fixed now!

[facebook-github-bot]

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[dmytrorykun]

@Saadnajmi there are some Ruby Test failures. Reproducible locally with

cd packages/react-native/scripts
sh run_ruby_tests.sh

Could you please fix them?

[Saadnajmi]

@Saadnajmi there are some Ruby Test failures. Reproducible locally with

cd packages/react-native/scripts
sh run_ruby_tests.sh

Could you please fix them?

Sorry, I think this will still fail actually (seeing that locally). Give me a bit while I learn more about ruby :D

[Saadnajmi]

@dmytrorykun looks like we're good now!

[facebook-github-bot]

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[github-actions]

This pull request was successfully merged by @Saadnajmi in 1b78da8.

^{When will my fix make it into a release? | Upcoming Releases}

[bingDBdu]

I don't think it can find the min_supported_versions

What should I do more fetch the value from cocoapods helper?

[Saadnajmi]

@bingDBdu Without knowing much of your setup, I see you're using cocoapods 1.15.0, which I think is actually not compatible with React Native at the moment. Also are you on RN 0.73?