Uh oh!
There was an error while loading. Please reload this page.
Improve start command interactive behaviour - #39544
Closed
huntie wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Sep 19, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D49422206 |
huntieforce-pushed
the
export-D49422206
branch
from
September 20, 2023 08:51
63c7340 to
7275a49Comparefacebook-github-bot
commented
Sep 20, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D49422206 |
huntieforce-pushed
the
export-D49422206
branch
from
September 20, 2023 08:51
7275a49 to
22b8138Comparefacebook-github-bot
commented
Sep 20, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D49422206 |
Summary: Pull Request resolved: #39544 Misc improvements to `npx react-native start` interactive behaviour: - Attaches key handlers on Metro `initialize_done` event — printing key command info earlier (once the server starts listening to bundle requests). - Shutdown behaviour: - Awaits closing of Metro's HTTP server. - Pauses key listener while awaiting shutdown (dependency on `cli-tools` `addInteractionListener` dropped). - Now observes `ctrl+d` (`ctrl+z` pause behaviour removed). - Updates reload handler message to 'Reloading connected app(s)...' (since ). - Adds newline below key commands printout (even spacing). Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D49422206 fbshipit-source-id: 9dfe406f13b5caaf4213d94200480ac43b988a23
facebook-github-bot
commented
Sep 20, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D49422206 |
huntieforce-pushed
the
export-D49422206
branch
from
September 20, 2023 08:54
22b8138 to
17e6056CompareThis pull request was successfully merged by @huntie in 196b3f9. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Misc improvements to
npx react-native startinteractive behaviour:initialize_doneevent — printing key command info earlier (once the server starts listening to bundle requests).cli-toolsaddInteractionListenerdropped).ctrl+d(ctrl+zpause behaviour removed).Changelog: [Internal]
Differential Revision: D49422206