Uh oh!
There was an error while loading. Please reload this page.
[iOS] Remove RCTGetMultiplierForContentSizeCategory - #39617
Conversation
ryancat
commented
Sep 25, 2023
Yeah the concern would be public API being visible to unknown apps. What's the proper deprecation steps look like and how we enforce it? @cipolleschi |
cipolleschi
commented
Sep 25, 2023
Yeah, it seems like we are not even using this internally.
|
Saadnajmi
commented
Sep 25, 2023
To be clear, deprecate in 0.73 and remove in 0.74? |
facebook-github-bot
commented
Sep 25, 2023
@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Saadnajmi
commented
Sep 26, 2023
Deprecation done here: #39643, I'll revisit this PR post 0.73. |
Summary: Per #39617 (comment) , let's deprecate this method first. bypass-github-export-checks ## Changelog: [IOS] [DEPRECATED] - Deprecate RCTGetMultiplierForContentSizeCategory Pull Request resolved: #39643 Test Plan: CI should pass Reviewed By: dmytrorykun Differential Revision: D49637172 Pulled By: cipolleschi fbshipit-source-id: 20dc70c737ef51efd5a5aa38832fb47b5d49e641
Saadnajmi
commented
Oct 6, 2023
Now that #39785 merged, can we revisit this? |
cipolleschi
commented
Oct 6, 2023
yeah... branch has been cut and the other commit is in the cherry pick list. |
facebook-github-bot
commented
Oct 9, 2023
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Oct 9, 2023
@cipolleschi merged this pull request in 6a2c245. |
Summary:
It seems this method is not referenced by anything anymore. I think #35017 made it redundant. Let's remove it?
I can also do the whole "Deprecate for one version, remove in the next" since this was publicly exported.
Changelog:
[iOS] [REMOVED] - Remove RCTGetMultiplierForContentSizeCategory
Test Plan:
CI should pass