Uh oh!
There was an error while loading. Please reload this page.
[Local] Xcode 15 patch - #39754
Merged
Merged
Conversation
cipolleschi
approved these changes
Oct 2, 2023
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
nit: the grammar fix was not picked up, but a part from that, it is good!
Contributor
There was a problem hiding this comment.
Suggested change
| defself.remove_value_to_setting_if_present(config,setting_name,value) | |
| defself.remove_value_from_setting_if_present(config,setting_name,value) |
fortmarekforce-pushed
the
mf/xcode-15-patch
branch
from
October 2, 2023 17:09
da6ac72 to
ce0ff34Comparecipolleschi
approved these changes
Oct 3, 2023
cipolleschi
commented
Oct 3, 2023
Contributor
You might want to run |
fortmarekforce-pushed
the
mf/xcode-15-patch
branch
from
October 4, 2023 06:54
ce0ff34 to
6676ca9Comparefortmarekforce-pushed
the
mf/xcode-15-patch
branch
from
October 4, 2023 07:51
f6850e5 to
64f34a6Comparecipolleschi
approved these changes
Oct 4, 2023
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Applying this PR from @cipolleschi. We couldn't directly cherry-pick as the files have moved, so doing this to be safe.
Changelog:
[Internal] [Fixed] - Make the Xcode 15 workaround more robust.
Test Plan:
Try out
rn-testerwith Xcode 15.