Uh oh!
There was an error while loading. Please reload this page.
Bump fmt to 9.1.0 - #39799
Closed
NickGerleman wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Oct 4, 2023
Contributor
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 7d88ac4 |
|
facebook-github-bot
commented
Oct 4, 2023
Contributor
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Oct 4, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D49900112 |
facebook-github-bot
commented
Oct 4, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D49900112 |
Summary: This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump. Changelog: [General][Breaking] - Bump fmt to 9.1.0 Test Plan: Passes in CircleCI Reviewed By: cortinico, yungsters Differential Revision: D49900112 Pulled By: NickGerleman
facebook-github-bot
commented
Oct 5, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D49900112 |
NickGerleman added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 5, 2023
Summary: This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump. Changelog: [Internal] Pull Request resolved: react#39799 Test Plan: Passes in CircleCI Differential Revision: D49900112 fbshipit-source-id: 68bd2b951f147b23dabee338d9b5e81e3294977a
NickGerleman added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 5, 2023
Summary: This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump. Changelog: [Internal] Pull Request resolved: react#39799 Test Plan: Passes in CircleCI Differential Revision: D49900112 fbshipit-source-id: 502293fd4a467d1df447bef6d50a42065d167092
NickGerleman added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 5, 2023
Summary: This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump. Changelog: [Internal] Pull Request resolved: react#39799 Test Plan: Passes in CircleCI Differential Revision: D49900112 fbshipit-source-id: f33f9684d0836530409a553bb4c88bbc082a1f57
facebook-github-bot
commented
Oct 5, 2023
Contributor
@NickGerleman merged this pull request in bb9ed0e. |
Saadnajmi pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 20, 2024
Summary: This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump. Changelog: [General][Breaking] - Bump fmt to 9.1.0 Pull Request resolved: react#39799 Test Plan: Passes in CircleCI Reviewed By: cortinico, yungsters Differential Revision: D49900112 Pulled By: NickGerleman fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd
Saadnajmi added a commit
to microsoft/react-native-macos
that referenced
this pull request
Jan 23, 2024
…2049) * [visionOS] Add local podspecs to override supported platforms * Bump fmt to 9.1.0 (react#39799) Summary: This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump. Changelog: [General][Breaking] - Bump fmt to 9.1.0 Pull Request resolved: react#39799 Test Plan: Passes in CircleCI Reviewed By: cortinico, yungsters Differential Revision: D49900112 Pulled By: NickGerleman fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd --------- Co-authored-by: Nick Gerleman <ngerlem@fb.com>
Saadnajmi pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 23, 2024
Summary: This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump. Changelog: [General][Breaking] - Bump fmt to 9.1.0 Pull Request resolved: react#39799 Test Plan: Passes in CircleCI Reviewed By: cortinico, yungsters Differential Revision: D49900112 Pulled By: NickGerleman fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd
Saadnajmi added a commit
to microsoft/react-native-macos
that referenced
this pull request
Jan 23, 2024
…2048) * [visionOS] Add local podspecs to override supported platforms * Bump fmt to 9.1.0 (react#39799) Summary: This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump. Changelog: [General][Breaking] - Bump fmt to 9.1.0 Pull Request resolved: react#39799 Test Plan: Passes in CircleCI Reviewed By: cortinico, yungsters Differential Revision: D49900112 Pulled By: NickGerleman fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd * [CI] Install the latest version of packages in the brewfile (#2024) * [CI] Remove watchman --------- Co-authored-by: Nick Gerleman <ngerlem@fb.com>
okwasniewski pushed a commit
to callstack/react-native-visionos
that referenced
this pull request
Jan 31, 2024
Summary: This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump. Changelog: [General][Breaking] - Bump fmt to 9.1.0 Pull Request resolved: react#39799 Test Plan: Passes in CircleCI Reviewed By: cortinico, yungsters Differential Revision: D49900112 Pulled By: NickGerleman fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd # Conflicts: # packages/react-native/ReactCommon/react/nativemodule/samples/ReactCommon-Samples.podspec # packages/react-native/ReactCommon/react/renderer/debug/React-rendererdebug.podspec # packages/rn-tester/Podfile.lock
okwasniewski pushed a commit
to callstack/react-native-visionos
that referenced
this pull request
Feb 6, 2024
Summary: This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump. Changelog: [General][Breaking] - Bump fmt to 9.1.0 Pull Request resolved: react#39799 Test Plan: Passes in CircleCI Reviewed By: cortinico, yungsters Differential Revision: D49900112 Pulled By: NickGerleman fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd # Conflicts: # packages/react-native/ReactCommon/react/nativemodule/samples/ReactCommon-Samples.podspec # packages/react-native/ReactCommon/react/renderer/debug/React-rendererdebug.podspec # packages/rn-tester/Podfile.lock
okwasniewski pushed a commit
to callstack/react-native-visionos
that referenced
this pull request
Apr 5, 2024
Summary: This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump. Changelog: [General][Breaking] - Bump fmt to 9.1.0 Pull Request resolved: react#39799 Test Plan: Passes in CircleCI Reviewed By: cortinico, yungsters Differential Revision: D49900112 Pulled By: NickGerleman fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd # Conflicts: # packages/react-native/ReactCommon/react/nativemodule/samples/ReactCommon-Samples.podspec # packages/react-native/ReactCommon/react/renderer/debug/React-rendererdebug.podspec # packages/rn-tester/Podfile.lock
okwasniewski pushed a commit
to callstack/react-native-visionos
that referenced
this pull request
Jun 24, 2024
Summary: This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump. Changelog: [General][Breaking] - Bump fmt to 9.1.0 Pull Request resolved: react#39799 Test Plan: Passes in CircleCI Reviewed By: cortinico, yungsters Differential Revision: D49900112 Pulled By: NickGerleman fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd # Conflicts: # packages/react-native/ReactCommon/react/nativemodule/samples/ReactCommon-Samples.podspec # packages/react-native/ReactCommon/react/renderer/debug/React-rendererdebug.podspec # packages/rn-tester/Podfile.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.
Changelog: [Internal]