Uh oh!
There was an error while loading. Please reload this page.
Make sure template is consuming the right buildToolsVersion - #39956
Closed
cortinico wants to merge 1 commit into
Closed
Make sure template is consuming the right buildToolsVersion#39956cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
facebook-github-bot
commented
Oct 6, 2023
Contributor
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @cortinico in a5d5ead. When will my fix make it into a release? | Upcoming Releases |
blakef pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
Summary: Currently, the template has a `buildToolsVersion = '34.0.0'` specified in the top level .gradle file but it's not currently using it. This is causing the build to fallback to the default version provided by AGP which is 33.x This is also causing the CI to download buildtools 34.0.0 as they're not in the container (causing network flakyness). I'm also bumping the docker container to v12 as we bumped NDK 26 which is missing in the v11 container. ## Changelog: [INTERNAL] [FIXED] - Make sure template is consuming the right buildToolsVersion Pull Request resolved: react/react-native#39956 Test Plan: CI should be green Reviewed By: christophpurrer Differential Revision: D50019777 Pulled By: cortinico fbshipit-source-id: a2ab7a7bd7c55624d5c050b45e69086c5f25ba6a Original: react/react-native@a5d5ead
blakef pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Currently, the template has a `buildToolsVersion = '34.0.0'` specified in the top level .gradle file but it's not currently using it. This is causing the build to fallback to the default version provided by AGP which is 33.x This is also causing the CI to download buildtools 34.0.0 as they're not in the container (causing network flakyness). I'm also bumping the docker container to v12 as we bumped NDK 26 which is missing in the v11 container. ## Changelog: [INTERNAL] [FIXED] - Make sure template is consuming the right buildToolsVersion Pull Request resolved: react/react-native#39956 Test Plan: CI should be green Reviewed By: christophpurrer Differential Revision: D50019777 Pulled By: cortinico fbshipit-source-id: a2ab7a7bd7c55624d5c050b45e69086c5f25ba6a Original-Commit: react/react-native@a5d5ead
blakef pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Currently, the template has a `buildToolsVersion = '34.0.0'` specified in the top level .gradle file but it's not currently using it. This is causing the build to fallback to the default version provided by AGP which is 33.x This is also causing the CI to download buildtools 34.0.0 as they're not in the container (causing network flakyness). I'm also bumping the docker container to v12 as we bumped NDK 26 which is missing in the v11 container. ## Changelog: [INTERNAL] [FIXED] - Make sure template is consuming the right buildToolsVersion Pull Request resolved: react/react-native#39956 Test Plan: CI should be green Reviewed By: christophpurrer Differential Revision: D50019777 Pulled By: cortinico fbshipit-source-id: a2ab7a7bd7c55624d5c050b45e69086c5f25ba6a Original-Commit: react/react-native@a5d5ead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, the template has a
buildToolsVersion = '34.0.0'specified in the top level .gradle file but it's not currently using it.This is causing the build to fallback to the default version provided by AGP which is 33.x
This is also causing the CI to download buildtools 34.0.0 as they're not in the container (causing network flakyness).
I'm also bumping the docker container to v12 as we bumped NDK 26 which is missing in the v11 container.
Changelog:
[INTERNAL] [FIXED] - Make sure template is consuming the right buildToolsVersion
Test Plan:
CI should be green