Skip to content

Android: fix ClassCastException in ReactRootView.java when software keyboard is shown#40755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kot331107 wants to merge 9 commits into from
Closed

Android: fix ClassCastException in ReactRootView.java when software keyboard is shown #40755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d812374
Android: a fix for ClassCastException in ReactRootView.java
kot331107 Oct 9, 2023
df2aac4
handle case where there're subsequent calls from onGlobalLayout() for…
kot331107 Oct 11, 2023
56fda39
add missing symbols
kot331107 Oct 11, 2023
4ea3f74
another approach: getting softInputMode directly from root view's lay…
kot331107 Oct 12, 2023
88da1fe
Update packages/react-native/ReactAndroid/src/main/java/com/facebook/…
kot331107 Oct 12, 2023
f84428b
remove redundant getActivity()
kot331107 Oct 12, 2023
a0f935f
attempt to fix android tests
kot331107 Oct 13, 2023
15e4a9a
amend last
kot331107 Oct 13, 2023
693957c
fix test error
kot331107 Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,7 @@
import static com.facebook.react.uimanager.common.UIManagerType.FABRIC;
import static com.facebook.systrace.Systrace.TRACE_TAG_REACT_JAVA_BRIDGE;

import android.app.Activity;
import android.content.Context;
import android.content.ContextWrapper;
import android.graphics.Canvas;
import android.graphics.Insets;
import android.graphics.Point;
Expand DownExpand Up@@ -856,12 +854,18 @@ public void onGlobalLayout() {
checkForDeviceDimensionsChanges();
}

private Activity getActivity() {
Context context = getContext();
while (!(context instanceof Activity) && context instanceof ContextWrapper) {
context = ((ContextWrapper) context).getBaseContext();
private @Nullable WindowManager.LayoutParams getWindowLayoutParams() {
View view = ReactRootView.this;
if (view.getLayoutParams() instanceof WindowManager.LayoutParams) {
return (WindowManager.LayoutParams) view.getLayoutParams();
}
return (Activity) context;
while (view.getParent() instanceof View) {
view = (View) view.getParent();
if (view.getLayoutParams() instanceof WindowManager.LayoutParams) {
return (WindowManager.LayoutParams) view.getLayoutParams();
}
}
return null;
}

@RequiresApi(api = Build.VERSION_CODES.R)
Expand All@@ -881,7 +885,13 @@ private void checkForKeyboardEvents() {
Insets barInsets = rootInsets.getInsets(WindowInsets.Type.systemBars());
int height = imeInsets.bottom - barInsets.bottom;

int softInputMode = getActivity().getWindow().getAttributes().softInputMode;
int softInputMode;
WindowManager.LayoutParams windowLayoutParams = getWindowLayoutParams();
if (windowLayoutParams != null) {
softInputMode = windowLayoutParams.softInputMode;
} else {
return;
}
int screenY =
softInputMode == WindowManager.LayoutParams.SOFT_INPUT_ADJUST_NOTHING
? mVisibleViewArea.bottom - height
Expand Down
7 changes: 5 additions & 2 deletions packages/react-native/ReactAndroid/src/test/java/com/facebook/react/RootViewTest.kt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,7 @@ import android.graphics.Insets
import android.graphics.Rect
import android.view.MotionEvent
import android.view.WindowInsets
import android.view.WindowManager
import com.facebook.react.bridge.Arguments
import com.facebook.react.bridge.CatalystInstance
import com.facebook.react.bridge.JavaOnlyArray
Expand DownExpand Up@@ -211,9 +212,11 @@ class RootViewTest {
.setVisible(WindowInsets.Type.ime(), true)
.build()
}
val rootViewSpy = spy(rootView)
whenever(rootViewSpy.getLayoutParams()).thenReturn(WindowManager.LayoutParams())

rootView.startReactApplication(instanceManager, "")
rootView.simulateCheckForKeyboardForTesting()
rootViewSpy.startReactApplication(instanceManager, "")
rootViewSpy.simulateCheckForKeyboardForTesting()

val params = Arguments.createMap()
val endCoordinates = Arguments.createMap()
Expand Down