Uh oh!
There was an error while loading. Please reload this page.
rntester Android > Don't call rncore_ModuleProvider(name, params) twice - #40758
Closed
christophpurrer wants to merge 1 commit into
Closed
rntester Android > Don't call rncore_ModuleProvider(name, params) twice#40758christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
facebook-github-bot
commented
Oct 10, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D50109991 |
facebook-github-bot
commented
Oct 10, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D50109991 |
christophpurrerforce-pushed
the
export-D50109991
branch
from
October 10, 2023 03:07
4ed0c45 to
7c80381Compare
Base commit: b13ea17 |
…ce (react#40758) Summary: This is a follow up to react#39987 As we already call ``` return rncore_ModuleProvider(name, params); ``` in: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultTurboModuleManagerDelegate.cpp#L55 we don't have to do it again in: https://github.com/facebook/react-native/blob/main/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp#L53 Changelog: [Internal] Reviewed By: cortinico Differential Revision: D50109991
christophpurrerforce-pushed
the
export-D50109991
branch
from
October 11, 2023 00:06
7c80381 to
8b2407aComparefacebook-github-bot
commented
Oct 11, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D50109991 |
facebook-github-bot
commented
Oct 11, 2023
Contributor
This pull request has been merged in 4e92f60. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is a follow up to #39987
As we already call
in:
https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultTurboModuleManagerDelegate.cpp#L55
we don't have to do it again in:
https://github.com/facebook/react-native/blob/main/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp#L53
Changelog: [Internal]
Differential Revision: D50109991