Skip to content

Bump SocketRocket to 0.6.1 (#40774) - #40776

Closed
arushikesarwani94 wants to merge 1 commit into
react:mainfrom
arushikesarwani94:export-D50133688
Closed

Bump SocketRocket to 0.6.1 (#40774)#40776
arushikesarwani94 wants to merge 1 commit into
react:mainfrom
arushikesarwani94:export-D50133688

Conversation

@arushikesarwani94

Copy link
Copy Markdown
Contributor

Summary:
The SocketRocket version was upgraded to 0.6.1 on the 0.72-stable branch but for some reason it was not updated in main, causing a downgrade when running pod install with 0.73.0 RC1

Original commit bumping SocketRocket -> 8ce471e

Changelog:

[IOS] [CHANGED] - Bump SocketRocket to 0.6.1

Test Plan: Run rntester locally

Differential Revision: D50133688

Pulled By: arushikesarwani94

Summary:
The SocketRocket version was upgraded to 0.6.1 on the 0.72-stable branch but for some reason it was not updated in main, causing a downgrade when running `pod install` with 0.73.0 RC1
Original commit bumping SocketRocket -> react@8ce471e
## Changelog:
[IOS] [CHANGED] - Bump SocketRocket to 0.6.1
Pull Request resolved: react#40774
Test Plan: Run rntester locally
Differential Revision: D50133688
Pulled By: arushikesarwani94
fbshipit-source-id: 8a62bb5ef8ef0c5702f75c55cc7a079ab95740aa
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 10, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D50133688

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a17,219,049-9
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a20,587,243-3
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: 5c2ec55
Branch: main

@gabrieldonadel

Copy link
Copy Markdown
Collaborator

Hi @arushikesarwani94, not sure if you noticed but it seems that this PR is downgrading CocoaPods version in the lock file. I fixed it here (#40774) tho

@cortinico

Copy link
Copy Markdown
Contributor

Closing as abandoned internally

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedp: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@arushikesarwani94@facebook-github-bot@analysis-bot@gabrieldonadel@cortinico