Uh oh!
There was an error while loading. Please reload this page.
Configure Java toolchains per project - #41306
Conversation
facebook-github-bot
commented
Nov 3, 2023
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
analysis-bot
commented
Nov 3, 2023
Base commit: 80d816a |
UNIDY2002
commented
Nov 3, 2023
Wait... This fix is having issue on old arch... |
UNIDY2002
commented
Nov 3, 2023
Libraries on old arch does not apply the RNGP, and will not get their Java toolchains configured. Therefore, this PR is inapplicable. Closing it for now. |
EDIT: You were right. This is a bug (see #41620). Fix is forthcoming |
Summary:
A follow-up fix on #40560
The fix introduced by #40757 worked under the false assumption that
:appgets evaluated before any other library. However, some libraries, such as @amplitude/analytics-react-native (whose project name is:amplitude_analytics-react-native), might be evaluated before:appand miss theconfigureJavaToolChains()process.This PR changes
configureJavaToolChains()into a per-project implementation, and invokes the function during both library and app configurations. This can ensure that all projects get their Java toolchains configured promptly.Changelog:
[ANDROID] [FIXED] - Configure Java toolchains per project
Test Plan:
Test with @amplitude/analytics-react-native and ensure that the android app builds in new arch.