Skip to content

[RN][iOS] Fix React-FabricImage dependencies - #41641

Merged
huntie merged 1 commit into
0.73-stablefrom
cipolleschi/fix-fabric-image-deps
Nov 27, 2023
Merged

[RN][iOS] Fix React-FabricImage dependencies#41641
huntie merged 1 commit into
0.73-stablefrom
cipolleschi/fix-fabric-image-deps

Conversation

@cipolleschi

@cipolleschicipolleschi commented Nov 24, 2023

Copy link
Copy Markdown
Contributor

Summary:

This is the porting of #41640 to 0.73

react-native-svg reported that the SVG library was not building on the latest RC of React Native because Codegen was not finding the proper files.

By inspecting an example app with SVG, we realized that React-Codegen was not depending on React-FabricImage, while having access to their headers.

We added the dependency, but them the build was failing due to a circular dependency because the React-ImageManager was dependeing on React-RCTImage.
This dependency is conceptually wrong (a piece of Core should not depend on Library which depends on Core... 😑) and I verified that by removing that dependency the framework continue to build.

Changelog:

[Internal] - Fixed dependencies of Codegen on React-Image

Test Plan

Tested on a local app + CircleCI

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 24, 2023
@cipolleschi
cipolleschi changed the base branch from main to 0.73-stableNovember 24, 2023 17:29
@cipolleschicipolleschi changed the title cipolleschi/fix fabric image deps[RN][iOS] Fix React-FabricImage dependenciesNov 24, 2023
@cipolleschi
cipolleschi marked this pull request as ready for review November 24, 2023 17:35
@cipolleschi
cipolleschiforce-pushed the cipolleschi/fix-fabric-image-deps branch from 03c67b0 to 5703bb5CompareNovember 24, 2023 17:54
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,518,593-9,152,042
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a9,756,753-11,297,088
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: 67c852e
Branch: main

@github-actions

github-actionsBot commented Nov 24, 2023

Copy link
Copy Markdown
Warnings
⚠️One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 03c67b04c4414faaa3d7a25b12afe023c8a16cf4

@huntie
huntie merged commit 830c2e7 into 0.73-stableNov 27, 2023
@cortinico
cortinico deleted the cipolleschi/fix-fabric-image-deps branch June 10, 2024 13:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cipolleschi@analysis-bot@huntie@facebook-github-bot