[iOS] Fixes Reject error kind in Fabric

[zhongwuzw]

Summary:

Fixes#41950 .

Changelog:

[IOS] [FIXED] - Fixes Reject error kind in Fabric

Test Plan:

reject returns Error.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	16,569,922	-72,516
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	19,951,036	-87,388
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: aa2d613
Branch: main

[ryancat]

This change exposed the original error instead of the one created from RCTJSErrorFromCodeMessageAndNSError. I am not sure if there's any side effect/implications of that.

It seems the RCTMakeError is merely a wrapper to the error message though.

cc @sammy-SC for more details on this.

[cipolleschi]

Hi @zhongwuzw, thanks for the effort.
I think your changes mixes a little the semantic of the Error and lose some information from the ObjectiveC dictionary.
I suggested an approach that mixes what was happening before your changes with your suggestions.

You have the valid point of creating the Error, but I think it's better if we preserve the cause of the Error.
What do you think?

[zhongwuzw]

@cipolleschi Please review again.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[zhongwuzw]

@javache@cipolleschi Please review again. :)

[cipolleschi]

it looks good to me. There is only a small nit.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi merged this pull request in 9525074.