Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/community-cli-plugin/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,9 +31,11 @@
"metro": "^0.80.3",
"metro-config": "^0.80.3",
"metro-core": "^0.80.3",
"micromatch": "^4.0.5",
"node-fetch": "^2.2.0",
"querystring": "^0.2.1",
"readline": "^1.3.0"
"readline": "^1.3.0",
"yaml": "^2.3.4"
},
"devDependencies": {
"metro-resolver": "^0.80.3"
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import {getWorkspaceRoot} from '../getWorkspaceRoot';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

describe('getWorkspaceRoot', () => {
test('returns null if not in a workspace', () => {
const tempPackagePath = createTempPackage({
name: 'my-app',
});
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});

test('supports an npm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/my-app', 'packages/my-lib'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/*'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace (object style)', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: {
packages: ['packages/*'],
},
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace exclusion', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*", "!packages/*-app"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,133 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import loadMetroConfig from '../loadMetroConfig';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

/**
* Resolves a package by its name and creates a symbolic link in a node_modules directory
*/
function createPackageLink(nodeModulesPath: string, packageName: string) {
// Resolve the packages path on disk
const destinationPath = path.dirname(require.resolve(packageName));
const packageScope = packageName.includes('/')
? packageName.split('/')[0]
: undefined;

// Create a parent directory for a @scoped package
if (typeof packageScope === 'string') {
fs.mkdirSync(path.join(nodeModulesPath, packageScope));
}

const sourcePath = path.join(nodeModulesPath, packageName);
fs.symlinkSync(destinationPath, sourcePath);
}

function createTempConfig(projectRoot: string, metroConfig: {...}) {
const content = `
const {getDefaultConfig, mergeConfig} = require('@react-native/metro-config');
const config = ${JSON.stringify(metroConfig)};
module.exports = mergeConfig(getDefaultConfig(__dirname), config);
`;
const configPath = path.join(projectRoot, 'metro.config.js');
fs.writeFileSync(configPath, content, 'utf8');

const nodeModulesPath = path.join(projectRoot, 'node_modules');
fs.mkdirSync(nodeModulesPath);
// Create a symbolic link to the '@react-native/metro-config' package used by the config
createPackageLink(nodeModulesPath, '@react-native/metro-config');
}

const configLoadingContext = {
reactNativePath: path.dirname(require.resolve('react-native/package.json')),
platforms: {
ios: {npmPackageName: 'temp-package'},
android: {npmPackageName: 'temp-package'},
},
};

describe('loadMetroConfig', () => {
test('loads an empty config', async () => {
const rootPath = createTempPackage({name: 'temp-app'});
createTempConfig(rootPath, {});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath]);
});

test('loads watch folders', async () => {
const rootPath = createTempPackage({
name: 'temp-app',
});
createTempConfig(rootPath, {
watchFolders: ['somewhere-else'],
});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath, 'somewhere-else']);
});

test('includes an npm workspace root if no watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot, rootPath]);
});

test('does not resolve an npm workspace root if watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {
watchFolders: [],
});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot]);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import fs from 'fs';
import os from 'os';
import path from 'path';

export function createTempPackage(
packageJson: {...},
packagePath: string = fs.mkdtempSync(
path.join(os.tmpdir(), 'rn-metro-config-test-'),
),
): string {
fs.mkdirSync(packagePath, {recursive: true});
if (typeof packageJson === 'object') {
fs.writeFileSync(
path.join(packagePath, 'package.json'),
JSON.stringify(packageJson),
'utf8',
);
}

// Wrapping path in realpath to resolve any symlinks introduced by mkdtemp
return fs.realpathSync(packagePath);
}
86 changes: 86 additions & 0 deletions packages/community-cli-plugin/src/utils/getWorkspaceRoot.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* @format
* @oncall react_native
*/

import {logger} from '@react-native-community/cli-tools';
import fs from 'fs';
import micromatch from 'micromatch';
import path from 'path';
import yaml from 'yaml';

/**
* Get the workspace paths from the path of a potential workspace root.
*
* This supports:
* - [npm workspaces](https://docs.npmjs.com/cli/v10/using-npm/workspaces)
* - [yarn workspaces](https://yarnpkg.com/features/workspaces)
* - [pnpm workspaces](https://pnpm.io/workspaces)
*/
function getWorkspacePaths(packagePath: string): Array<string> {
try {
// Checking pnpm workspaces first
const pnpmWorkspacePath = path.resolve(packagePath, 'pnpm-workspace.yaml');
if (fs.existsSync(pnpmWorkspacePath)) {
const pnpmWorkspaceConfig = yaml.parse(
fs.readFileSync(pnpmWorkspacePath, 'utf8'),
);
if (
typeof pnpmWorkspaceConfig === 'object' &&
Array.isArray(pnpmWorkspaceConfig.packages)
) {
return pnpmWorkspaceConfig.packages;
}
}
// Falling back to npm / yarn workspaces
const packageJsonPath = path.resolve(packagePath, 'package.json');
const {workspaces} = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
if (Array.isArray(workspaces)) {
return workspaces;
} else if (
typeof workspaces === 'object' &&
Array.isArray(workspaces.packages)
) {
// An alternative way for yarn to declare workspace packages
return workspaces.packages;
}
} catch (err) {
if (err.code !== 'ENOENT') {
logger.debug(`Failed getting workspace root from ${packagePath}: ${err}`);
}
}
return [];
}

/**
* Resolves the root of an npm or yarn workspace, by traversing the file tree
* upwards from a `candidatePath` in the search for
* - a directory with a package.json
* - which has a `workspaces` array of strings
* - which (possibly via a glob) includes the project root
*/
export function getWorkspaceRoot(
projectRoot: string,
candidatePath: string = projectRoot,
): ?string {
const workspacePaths = getWorkspacePaths(candidatePath);
// If one of the workspaces match the project root, this is the workspace root
// Note: While npm workspaces doesn't currently support globs, yarn does, which is why we use micromatch
const relativePath = path.relative(candidatePath, projectRoot);
// Using this instead of `micromatch.isMatch` to enable excluding patterns
if (micromatch([relativePath], workspacePaths).length > 0) {
return candidatePath;
}
// Try one level up
const parentDir = path.dirname(candidatePath);
if (parentDir !== candidatePath) {
return getWorkspaceRoot(projectRoot, parentDir);
}
return null;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[`@react-native/community-cli-plugin`] Added inference of `watchFolders` from NPM, Yarn and PNPM workspaces by kraenhansen · Pull Request #41967 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/community-cli-plugin/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,9 +31,11 @@
"metro": "^0.80.3",
"metro-config": "^0.80.3",
"metro-core": "^0.80.3",
"micromatch": "^4.0.5",
"node-fetch": "^2.2.0",
"querystring": "^0.2.1",
"readline": "^1.3.0"
"readline": "^1.3.0",
"yaml": "^2.3.4"
},
"devDependencies": {
"metro-resolver": "^0.80.3"
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import {getWorkspaceRoot} from '../getWorkspaceRoot';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

describe('getWorkspaceRoot', () => {
test('returns null if not in a workspace', () => {
const tempPackagePath = createTempPackage({
name: 'my-app',
});
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});

test('supports an npm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/my-app', 'packages/my-lib'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/*'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace (object style)', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: {
packages: ['packages/*'],
},
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace exclusion', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*", "!packages/*-app"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,133 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import loadMetroConfig from '../loadMetroConfig';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

/**
* Resolves a package by its name and creates a symbolic link in a node_modules directory
*/
function createPackageLink(nodeModulesPath: string, packageName: string) {
// Resolve the packages path on disk
const destinationPath = path.dirname(require.resolve(packageName));
const packageScope = packageName.includes('/')
? packageName.split('/')[0]
: undefined;

// Create a parent directory for a @scoped package
if (typeof packageScope === 'string') {
fs.mkdirSync(path.join(nodeModulesPath, packageScope));
}

const sourcePath = path.join(nodeModulesPath, packageName);
fs.symlinkSync(destinationPath, sourcePath);
}

function createTempConfig(projectRoot: string, metroConfig: {...}) {
const content = `
const {getDefaultConfig, mergeConfig} = require('@react-native/metro-config');
const config = ${JSON.stringify(metroConfig)};
module.exports = mergeConfig(getDefaultConfig(__dirname), config);
`;
const configPath = path.join(projectRoot, 'metro.config.js');
fs.writeFileSync(configPath, content, 'utf8');

const nodeModulesPath = path.join(projectRoot, 'node_modules');
fs.mkdirSync(nodeModulesPath);
// Create a symbolic link to the '@react-native/metro-config' package used by the config
createPackageLink(nodeModulesPath, '@react-native/metro-config');
}

const configLoadingContext = {
reactNativePath: path.dirname(require.resolve('react-native/package.json')),
platforms: {
ios: {npmPackageName: 'temp-package'},
android: {npmPackageName: 'temp-package'},
},
};

describe('loadMetroConfig', () => {
test('loads an empty config', async () => {
const rootPath = createTempPackage({name: 'temp-app'});
createTempConfig(rootPath, {});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath]);
});

test('loads watch folders', async () => {
const rootPath = createTempPackage({
name: 'temp-app',
});
createTempConfig(rootPath, {
watchFolders: ['somewhere-else'],
});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath, 'somewhere-else']);
});

test('includes an npm workspace root if no watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot, rootPath]);
});

test('does not resolve an npm workspace root if watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {
watchFolders: [],
});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot]);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import fs from 'fs';
import os from 'os';
import path from 'path';

export function createTempPackage(
packageJson: {...},
packagePath: string = fs.mkdtempSync(
path.join(os.tmpdir(), 'rn-metro-config-test-'),
),
): string {
fs.mkdirSync(packagePath, {recursive: true});
if (typeof packageJson === 'object') {
fs.writeFileSync(
path.join(packagePath, 'package.json'),
JSON.stringify(packageJson),
'utf8',
);
}

// Wrapping path in realpath to resolve any symlinks introduced by mkdtemp
return fs.realpathSync(packagePath);
}
86 changes: 86 additions & 0 deletions packages/community-cli-plugin/src/utils/getWorkspaceRoot.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* @format
* @oncall react_native
*/

import {logger} from '@react-native-community/cli-tools';
import fs from 'fs';
import micromatch from 'micromatch';
import path from 'path';
import yaml from 'yaml';

/**
* Get the workspace paths from the path of a potential workspace root.
*
* This supports:
* - [npm workspaces](https://docs.npmjs.com/cli/v10/using-npm/workspaces)
* - [yarn workspaces](https://yarnpkg.com/features/workspaces)
* - [pnpm workspaces](https://pnpm.io/workspaces)
*/
function getWorkspacePaths(packagePath: string): Array<string> {
try {
// Checking pnpm workspaces first
const pnpmWorkspacePath = path.resolve(packagePath, 'pnpm-workspace.yaml');
if (fs.existsSync(pnpmWorkspacePath)) {
const pnpmWorkspaceConfig = yaml.parse(
fs.readFileSync(pnpmWorkspacePath, 'utf8'),
);
if (
typeof pnpmWorkspaceConfig === 'object' &&
Array.isArray(pnpmWorkspaceConfig.packages)
) {
return pnpmWorkspaceConfig.packages;
}
}
// Falling back to npm / yarn workspaces
const packageJsonPath = path.resolve(packagePath, 'package.json');
const {workspaces} = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
if (Array.isArray(workspaces)) {
return workspaces;
} else if (
typeof workspaces === 'object' &&
Array.isArray(workspaces.packages)
) {
// An alternative way for yarn to declare workspace packages
return workspaces.packages;
}
} catch (err) {
if (err.code !== 'ENOENT') {
logger.debug(`Failed getting workspace root from ${packagePath}: ${err}`);
}
}
return [];
}

/**
* Resolves the root of an npm or yarn workspace, by traversing the file tree
* upwards from a `candidatePath` in the search for
* - a directory with a package.json
* - which has a `workspaces` array of strings
* - which (possibly via a glob) includes the project root
*/
export function getWorkspaceRoot(
projectRoot: string,
candidatePath: string = projectRoot,
): ?string {
const workspacePaths = getWorkspacePaths(candidatePath);
// If one of the workspaces match the project root, this is the workspace root
// Note: While npm workspaces doesn't currently support globs, yarn does, which is why we use micromatch
const relativePath = path.relative(candidatePath, projectRoot);
// Using this instead of `micromatch.isMatch` to enable excluding patterns
if (micromatch([relativePath], workspacePaths).length > 0) {
return candidatePath;
}
// Try one level up
const parentDir = path.dirname(candidatePath);
if (parentDir !== candidatePath) {
return getWorkspaceRoot(projectRoot, parentDir);
}
return null;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [`@react-native/community-cli-plugin`] Added inference of `watchFolders` from NPM, Yarn and PNPM workspaces by kraenhansen · Pull Request #41967 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/community-cli-plugin/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,9 +31,11 @@
"metro": "^0.80.3",
"metro-config": "^0.80.3",
"metro-core": "^0.80.3",
"micromatch": "^4.0.5",
"node-fetch": "^2.2.0",
"querystring": "^0.2.1",
"readline": "^1.3.0"
"readline": "^1.3.0",
"yaml": "^2.3.4"
},
"devDependencies": {
"metro-resolver": "^0.80.3"
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import {getWorkspaceRoot} from '../getWorkspaceRoot';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

describe('getWorkspaceRoot', () => {
test('returns null if not in a workspace', () => {
const tempPackagePath = createTempPackage({
name: 'my-app',
});
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});

test('supports an npm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/my-app', 'packages/my-lib'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/*'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace (object style)', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: {
packages: ['packages/*'],
},
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace exclusion', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*", "!packages/*-app"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,133 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import loadMetroConfig from '../loadMetroConfig';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

/**
* Resolves a package by its name and creates a symbolic link in a node_modules directory
*/
function createPackageLink(nodeModulesPath: string, packageName: string) {
// Resolve the packages path on disk
const destinationPath = path.dirname(require.resolve(packageName));
const packageScope = packageName.includes('/')
? packageName.split('/')[0]
: undefined;

// Create a parent directory for a @scoped package
if (typeof packageScope === 'string') {
fs.mkdirSync(path.join(nodeModulesPath, packageScope));
}

const sourcePath = path.join(nodeModulesPath, packageName);
fs.symlinkSync(destinationPath, sourcePath);
}

function createTempConfig(projectRoot: string, metroConfig: {...}) {
const content = `
const {getDefaultConfig, mergeConfig} = require('@react-native/metro-config');
const config = ${JSON.stringify(metroConfig)};
module.exports = mergeConfig(getDefaultConfig(__dirname), config);
`;
const configPath = path.join(projectRoot, 'metro.config.js');
fs.writeFileSync(configPath, content, 'utf8');

const nodeModulesPath = path.join(projectRoot, 'node_modules');
fs.mkdirSync(nodeModulesPath);
// Create a symbolic link to the '@react-native/metro-config' package used by the config
createPackageLink(nodeModulesPath, '@react-native/metro-config');
}

const configLoadingContext = {
reactNativePath: path.dirname(require.resolve('react-native/package.json')),
platforms: {
ios: {npmPackageName: 'temp-package'},
android: {npmPackageName: 'temp-package'},
},
};

describe('loadMetroConfig', () => {
test('loads an empty config', async () => {
const rootPath = createTempPackage({name: 'temp-app'});
createTempConfig(rootPath, {});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath]);
});

test('loads watch folders', async () => {
const rootPath = createTempPackage({
name: 'temp-app',
});
createTempConfig(rootPath, {
watchFolders: ['somewhere-else'],
});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath, 'somewhere-else']);
});

test('includes an npm workspace root if no watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot, rootPath]);
});

test('does not resolve an npm workspace root if watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {
watchFolders: [],
});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot]);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import fs from 'fs';
import os from 'os';
import path from 'path';

export function createTempPackage(
packageJson: {...},
packagePath: string = fs.mkdtempSync(
path.join(os.tmpdir(), 'rn-metro-config-test-'),
),
): string {
fs.mkdirSync(packagePath, {recursive: true});
if (typeof packageJson === 'object') {
fs.writeFileSync(
path.join(packagePath, 'package.json'),
JSON.stringify(packageJson),
'utf8',
);
}

// Wrapping path in realpath to resolve any symlinks introduced by mkdtemp
return fs.realpathSync(packagePath);
}
86 changes: 86 additions & 0 deletions packages/community-cli-plugin/src/utils/getWorkspaceRoot.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* @format
* @oncall react_native
*/

import {logger} from '@react-native-community/cli-tools';
import fs from 'fs';
import micromatch from 'micromatch';
import path from 'path';
import yaml from 'yaml';

/**
* Get the workspace paths from the path of a potential workspace root.
*
* This supports:
* - [npm workspaces](https://docs.npmjs.com/cli/v10/using-npm/workspaces)
* - [yarn workspaces](https://yarnpkg.com/features/workspaces)
* - [pnpm workspaces](https://pnpm.io/workspaces)
*/
function getWorkspacePaths(packagePath: string): Array<string> {
try {
// Checking pnpm workspaces first
const pnpmWorkspacePath = path.resolve(packagePath, 'pnpm-workspace.yaml');
if (fs.existsSync(pnpmWorkspacePath)) {
const pnpmWorkspaceConfig = yaml.parse(
fs.readFileSync(pnpmWorkspacePath, 'utf8'),
);
if (
typeof pnpmWorkspaceConfig === 'object' &&
Array.isArray(pnpmWorkspaceConfig.packages)
) {
return pnpmWorkspaceConfig.packages;
}
}
// Falling back to npm / yarn workspaces
const packageJsonPath = path.resolve(packagePath, 'package.json');
const {workspaces} = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
if (Array.isArray(workspaces)) {
return workspaces;
} else if (
typeof workspaces === 'object' &&
Array.isArray(workspaces.packages)
) {
// An alternative way for yarn to declare workspace packages
return workspaces.packages;
}
} catch (err) {
if (err.code !== 'ENOENT') {
logger.debug(`Failed getting workspace root from ${packagePath}: ${err}`);
}
}
return [];
}

/**
* Resolves the root of an npm or yarn workspace, by traversing the file tree
* upwards from a `candidatePath` in the search for
* - a directory with a package.json
* - which has a `workspaces` array of strings
* - which (possibly via a glob) includes the project root
*/
export function getWorkspaceRoot(
projectRoot: string,
candidatePath: string = projectRoot,
): ?string {
const workspacePaths = getWorkspacePaths(candidatePath);
// If one of the workspaces match the project root, this is the workspace root
// Note: While npm workspaces doesn't currently support globs, yarn does, which is why we use micromatch
const relativePath = path.relative(candidatePath, projectRoot);
// Using this instead of `micromatch.isMatch` to enable excluding patterns
if (micromatch([relativePath], workspacePaths).length > 0) {
return candidatePath;
}
// Try one level up
const parentDir = path.dirname(candidatePath);
if (parentDir !== candidatePath) {
return getWorkspaceRoot(projectRoot, parentDir);
}
return null;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [`@react-native/community-cli-plugin`] Added inference of `watchFolders` from NPM, Yarn and PNPM workspaces by kraenhansen · Pull Request #41967 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/community-cli-plugin/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,9 +31,11 @@
"metro": "^0.80.3",
"metro-config": "^0.80.3",
"metro-core": "^0.80.3",
"micromatch": "^4.0.5",
"node-fetch": "^2.2.0",
"querystring": "^0.2.1",
"readline": "^1.3.0"
"readline": "^1.3.0",
"yaml": "^2.3.4"
},
"devDependencies": {
"metro-resolver": "^0.80.3"
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import {getWorkspaceRoot} from '../getWorkspaceRoot';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

describe('getWorkspaceRoot', () => {
test('returns null if not in a workspace', () => {
const tempPackagePath = createTempPackage({
name: 'my-app',
});
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});

test('supports an npm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/my-app', 'packages/my-lib'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/*'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace (object style)', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: {
packages: ['packages/*'],
},
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace exclusion', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*", "!packages/*-app"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,133 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import loadMetroConfig from '../loadMetroConfig';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

/**
* Resolves a package by its name and creates a symbolic link in a node_modules directory
*/
function createPackageLink(nodeModulesPath: string, packageName: string) {
// Resolve the packages path on disk
const destinationPath = path.dirname(require.resolve(packageName));
const packageScope = packageName.includes('/')
? packageName.split('/')[0]
: undefined;

// Create a parent directory for a @scoped package
if (typeof packageScope === 'string') {
fs.mkdirSync(path.join(nodeModulesPath, packageScope));
}

const sourcePath = path.join(nodeModulesPath, packageName);
fs.symlinkSync(destinationPath, sourcePath);
}

function createTempConfig(projectRoot: string, metroConfig: {...}) {
const content = `
const {getDefaultConfig, mergeConfig} = require('@react-native/metro-config');
const config = ${JSON.stringify(metroConfig)};
module.exports = mergeConfig(getDefaultConfig(__dirname), config);
`;
const configPath = path.join(projectRoot, 'metro.config.js');
fs.writeFileSync(configPath, content, 'utf8');

const nodeModulesPath = path.join(projectRoot, 'node_modules');
fs.mkdirSync(nodeModulesPath);
// Create a symbolic link to the '@react-native/metro-config' package used by the config
createPackageLink(nodeModulesPath, '@react-native/metro-config');
}

const configLoadingContext = {
reactNativePath: path.dirname(require.resolve('react-native/package.json')),
platforms: {
ios: {npmPackageName: 'temp-package'},
android: {npmPackageName: 'temp-package'},
},
};

describe('loadMetroConfig', () => {
test('loads an empty config', async () => {
const rootPath = createTempPackage({name: 'temp-app'});
createTempConfig(rootPath, {});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath]);
});

test('loads watch folders', async () => {
const rootPath = createTempPackage({
name: 'temp-app',
});
createTempConfig(rootPath, {
watchFolders: ['somewhere-else'],
});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath, 'somewhere-else']);
});

test('includes an npm workspace root if no watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot, rootPath]);
});

test('does not resolve an npm workspace root if watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {
watchFolders: [],
});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot]);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import fs from 'fs';
import os from 'os';
import path from 'path';

export function createTempPackage(
packageJson: {...},
packagePath: string = fs.mkdtempSync(
path.join(os.tmpdir(), 'rn-metro-config-test-'),
),
): string {
fs.mkdirSync(packagePath, {recursive: true});
if (typeof packageJson === 'object') {
fs.writeFileSync(
path.join(packagePath, 'package.json'),
JSON.stringify(packageJson),
'utf8',
);
}

// Wrapping path in realpath to resolve any symlinks introduced by mkdtemp
return fs.realpathSync(packagePath);
}
86 changes: 86 additions & 0 deletions packages/community-cli-plugin/src/utils/getWorkspaceRoot.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* @format
* @oncall react_native
*/

import {logger} from '@react-native-community/cli-tools';
import fs from 'fs';
import micromatch from 'micromatch';
import path from 'path';
import yaml from 'yaml';

/**
* Get the workspace paths from the path of a potential workspace root.
*
* This supports:
* - [npm workspaces](https://docs.npmjs.com/cli/v10/using-npm/workspaces)
* - [yarn workspaces](https://yarnpkg.com/features/workspaces)
* - [pnpm workspaces](https://pnpm.io/workspaces)
*/
function getWorkspacePaths(packagePath: string): Array<string> {
try {
// Checking pnpm workspaces first
const pnpmWorkspacePath = path.resolve(packagePath, 'pnpm-workspace.yaml');
if (fs.existsSync(pnpmWorkspacePath)) {
const pnpmWorkspaceConfig = yaml.parse(
fs.readFileSync(pnpmWorkspacePath, 'utf8'),
);
if (
typeof pnpmWorkspaceConfig === 'object' &&
Array.isArray(pnpmWorkspaceConfig.packages)
) {
return pnpmWorkspaceConfig.packages;
}
}
// Falling back to npm / yarn workspaces
const packageJsonPath = path.resolve(packagePath, 'package.json');
const {workspaces} = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
if (Array.isArray(workspaces)) {
return workspaces;
} else if (
typeof workspaces === 'object' &&
Array.isArray(workspaces.packages)
) {
// An alternative way for yarn to declare workspace packages
return workspaces.packages;
}
} catch (err) {
if (err.code !== 'ENOENT') {
logger.debug(`Failed getting workspace root from ${packagePath}: ${err}`);
}
}
return [];
}

/**
* Resolves the root of an npm or yarn workspace, by traversing the file tree
* upwards from a `candidatePath` in the search for
* - a directory with a package.json
* - which has a `workspaces` array of strings
* - which (possibly via a glob) includes the project root
*/
export function getWorkspaceRoot(
projectRoot: string,
candidatePath: string = projectRoot,
): ?string {
const workspacePaths = getWorkspacePaths(candidatePath);
// If one of the workspaces match the project root, this is the workspace root
// Note: While npm workspaces doesn't currently support globs, yarn does, which is why we use micromatch
const relativePath = path.relative(candidatePath, projectRoot);
// Using this instead of `micromatch.isMatch` to enable excluding patterns
if (micromatch([relativePath], workspacePaths).length > 0) {
return candidatePath;
}
// Try one level up
const parentDir = path.dirname(candidatePath);
if (parentDir !== candidatePath) {
return getWorkspaceRoot(projectRoot, parentDir);
}
return null;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' [`@react-native/community-cli-plugin`] Added inference of `watchFolders` from NPM, Yarn and PNPM workspaces by kraenhansen · Pull Request #41967 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/community-cli-plugin/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,9 +31,11 @@
"metro": "^0.80.3",
"metro-config": "^0.80.3",
"metro-core": "^0.80.3",
"micromatch": "^4.0.5",
"node-fetch": "^2.2.0",
"querystring": "^0.2.1",
"readline": "^1.3.0"
"readline": "^1.3.0",
"yaml": "^2.3.4"
},
"devDependencies": {
"metro-resolver": "^0.80.3"
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import {getWorkspaceRoot} from '../getWorkspaceRoot';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

describe('getWorkspaceRoot', () => {
test('returns null if not in a workspace', () => {
const tempPackagePath = createTempPackage({
name: 'my-app',
});
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});

test('supports an npm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/my-app', 'packages/my-lib'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/*'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace (object style)', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: {
packages: ['packages/*'],
},
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace exclusion', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*", "!packages/*-app"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,133 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import loadMetroConfig from '../loadMetroConfig';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

/**
* Resolves a package by its name and creates a symbolic link in a node_modules directory
*/
function createPackageLink(nodeModulesPath: string, packageName: string) {
// Resolve the packages path on disk
const destinationPath = path.dirname(require.resolve(packageName));
const packageScope = packageName.includes('/')
? packageName.split('/')[0]
: undefined;

// Create a parent directory for a @scoped package
if (typeof packageScope === 'string') {
fs.mkdirSync(path.join(nodeModulesPath, packageScope));
}

const sourcePath = path.join(nodeModulesPath, packageName);
fs.symlinkSync(destinationPath, sourcePath);
}

function createTempConfig(projectRoot: string, metroConfig: {...}) {
const content = `
const {getDefaultConfig, mergeConfig} = require('@react-native/metro-config');
const config = ${JSON.stringify(metroConfig)};
module.exports = mergeConfig(getDefaultConfig(__dirname), config);
`;
const configPath = path.join(projectRoot, 'metro.config.js');
fs.writeFileSync(configPath, content, 'utf8');

const nodeModulesPath = path.join(projectRoot, 'node_modules');
fs.mkdirSync(nodeModulesPath);
// Create a symbolic link to the '@react-native/metro-config' package used by the config
createPackageLink(nodeModulesPath, '@react-native/metro-config');
}

const configLoadingContext = {
reactNativePath: path.dirname(require.resolve('react-native/package.json')),
platforms: {
ios: {npmPackageName: 'temp-package'},
android: {npmPackageName: 'temp-package'},
},
};

describe('loadMetroConfig', () => {
test('loads an empty config', async () => {
const rootPath = createTempPackage({name: 'temp-app'});
createTempConfig(rootPath, {});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath]);
});

test('loads watch folders', async () => {
const rootPath = createTempPackage({
name: 'temp-app',
});
createTempConfig(rootPath, {
watchFolders: ['somewhere-else'],
});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath, 'somewhere-else']);
});

test('includes an npm workspace root if no watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot, rootPath]);
});

test('does not resolve an npm workspace root if watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {
watchFolders: [],
});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot]);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import fs from 'fs';
import os from 'os';
import path from 'path';

export function createTempPackage(
packageJson: {...},
packagePath: string = fs.mkdtempSync(
path.join(os.tmpdir(), 'rn-metro-config-test-'),
),
): string {
fs.mkdirSync(packagePath, {recursive: true});
if (typeof packageJson === 'object') {
fs.writeFileSync(
path.join(packagePath, 'package.json'),
JSON.stringify(packageJson),
'utf8',
);
}

// Wrapping path in realpath to resolve any symlinks introduced by mkdtemp
return fs.realpathSync(packagePath);
}
86 changes: 86 additions & 0 deletions packages/community-cli-plugin/src/utils/getWorkspaceRoot.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* @format
* @oncall react_native
*/

import {logger} from '@react-native-community/cli-tools';
import fs from 'fs';
import micromatch from 'micromatch';
import path from 'path';
import yaml from 'yaml';

/**
* Get the workspace paths from the path of a potential workspace root.
*
* This supports:
* - [npm workspaces](https://docs.npmjs.com/cli/v10/using-npm/workspaces)
* - [yarn workspaces](https://yarnpkg.com/features/workspaces)
* - [pnpm workspaces](https://pnpm.io/workspaces)
*/
function getWorkspacePaths(packagePath: string): Array<string> {
try {
// Checking pnpm workspaces first
const pnpmWorkspacePath = path.resolve(packagePath, 'pnpm-workspace.yaml');
if (fs.existsSync(pnpmWorkspacePath)) {
const pnpmWorkspaceConfig = yaml.parse(
fs.readFileSync(pnpmWorkspacePath, 'utf8'),
);
if (
typeof pnpmWorkspaceConfig === 'object' &&
Array.isArray(pnpmWorkspaceConfig.packages)
) {
return pnpmWorkspaceConfig.packages;
}
}
// Falling back to npm / yarn workspaces
const packageJsonPath = path.resolve(packagePath, 'package.json');
const {workspaces} = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
if (Array.isArray(workspaces)) {
return workspaces;
} else if (
typeof workspaces === 'object' &&
Array.isArray(workspaces.packages)
) {
// An alternative way for yarn to declare workspace packages
return workspaces.packages;
}
} catch (err) {
if (err.code !== 'ENOENT') {
logger.debug(`Failed getting workspace root from ${packagePath}: ${err}`);
}
}
return [];
}

/**
* Resolves the root of an npm or yarn workspace, by traversing the file tree
* upwards from a `candidatePath` in the search for
* - a directory with a package.json
* - which has a `workspaces` array of strings
* - which (possibly via a glob) includes the project root
*/
export function getWorkspaceRoot(
projectRoot: string,
candidatePath: string = projectRoot,
): ?string {
const workspacePaths = getWorkspacePaths(candidatePath);
// If one of the workspaces match the project root, this is the workspace root
// Note: While npm workspaces doesn't currently support globs, yarn does, which is why we use micromatch
const relativePath = path.relative(candidatePath, projectRoot);
// Using this instead of `micromatch.isMatch` to enable excluding patterns
if (micromatch([relativePath], workspacePaths).length > 0) {
return candidatePath;
}
// Try one level up
const parentDir = path.dirname(candidatePath);
if (parentDir !== candidatePath) {
return getWorkspaceRoot(projectRoot, parentDir);
}
return null;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [`@react-native/community-cli-plugin`] Added inference of `watchFolders` from NPM, Yarn and PNPM workspaces by kraenhansen · Pull Request #41967 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/community-cli-plugin/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,9 +31,11 @@
"metro": "^0.80.3",
"metro-config": "^0.80.3",
"metro-core": "^0.80.3",
"micromatch": "^4.0.5",
"node-fetch": "^2.2.0",
"querystring": "^0.2.1",
"readline": "^1.3.0"
"readline": "^1.3.0",
"yaml": "^2.3.4"
},
"devDependencies": {
"metro-resolver": "^0.80.3"
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import {getWorkspaceRoot} from '../getWorkspaceRoot';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

describe('getWorkspaceRoot', () => {
test('returns null if not in a workspace', () => {
const tempPackagePath = createTempPackage({
name: 'my-app',
});
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});

test('supports an npm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/my-app', 'packages/my-lib'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/*'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace (object style)', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: {
packages: ['packages/*'],
},
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace exclusion', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*", "!packages/*-app"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,133 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import loadMetroConfig from '../loadMetroConfig';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

/**
* Resolves a package by its name and creates a symbolic link in a node_modules directory
*/
function createPackageLink(nodeModulesPath: string, packageName: string) {
// Resolve the packages path on disk
const destinationPath = path.dirname(require.resolve(packageName));
const packageScope = packageName.includes('/')
? packageName.split('/')[0]
: undefined;

// Create a parent directory for a @scoped package
if (typeof packageScope === 'string') {
fs.mkdirSync(path.join(nodeModulesPath, packageScope));
}

const sourcePath = path.join(nodeModulesPath, packageName);
fs.symlinkSync(destinationPath, sourcePath);
}

function createTempConfig(projectRoot: string, metroConfig: {...}) {
const content = `
const {getDefaultConfig, mergeConfig} = require('@react-native/metro-config');
const config = ${JSON.stringify(metroConfig)};
module.exports = mergeConfig(getDefaultConfig(__dirname), config);
`;
const configPath = path.join(projectRoot, 'metro.config.js');
fs.writeFileSync(configPath, content, 'utf8');

const nodeModulesPath = path.join(projectRoot, 'node_modules');
fs.mkdirSync(nodeModulesPath);
// Create a symbolic link to the '@react-native/metro-config' package used by the config
createPackageLink(nodeModulesPath, '@react-native/metro-config');
}

const configLoadingContext = {
reactNativePath: path.dirname(require.resolve('react-native/package.json')),
platforms: {
ios: {npmPackageName: 'temp-package'},
android: {npmPackageName: 'temp-package'},
},
};

describe('loadMetroConfig', () => {
test('loads an empty config', async () => {
const rootPath = createTempPackage({name: 'temp-app'});
createTempConfig(rootPath, {});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath]);
});

test('loads watch folders', async () => {
const rootPath = createTempPackage({
name: 'temp-app',
});
createTempConfig(rootPath, {
watchFolders: ['somewhere-else'],
});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath, 'somewhere-else']);
});

test('includes an npm workspace root if no watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot, rootPath]);
});

test('does not resolve an npm workspace root if watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {
watchFolders: [],
});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot]);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import fs from 'fs';
import os from 'os';
import path from 'path';

export function createTempPackage(
packageJson: {...},
packagePath: string = fs.mkdtempSync(
path.join(os.tmpdir(), 'rn-metro-config-test-'),
),
): string {
fs.mkdirSync(packagePath, {recursive: true});
if (typeof packageJson === 'object') {
fs.writeFileSync(
path.join(packagePath, 'package.json'),
JSON.stringify(packageJson),
'utf8',
);
}

// Wrapping path in realpath to resolve any symlinks introduced by mkdtemp
return fs.realpathSync(packagePath);
}
86 changes: 86 additions & 0 deletions packages/community-cli-plugin/src/utils/getWorkspaceRoot.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* @format
* @oncall react_native
*/

import {logger} from '@react-native-community/cli-tools';
import fs from 'fs';
import micromatch from 'micromatch';
import path from 'path';
import yaml from 'yaml';

/**
* Get the workspace paths from the path of a potential workspace root.
*
* This supports:
* - [npm workspaces](https://docs.npmjs.com/cli/v10/using-npm/workspaces)
* - [yarn workspaces](https://yarnpkg.com/features/workspaces)
* - [pnpm workspaces](https://pnpm.io/workspaces)
*/
function getWorkspacePaths(packagePath: string): Array<string> {
try {
// Checking pnpm workspaces first
const pnpmWorkspacePath = path.resolve(packagePath, 'pnpm-workspace.yaml');
if (fs.existsSync(pnpmWorkspacePath)) {
const pnpmWorkspaceConfig = yaml.parse(
fs.readFileSync(pnpmWorkspacePath, 'utf8'),
);
if (
typeof pnpmWorkspaceConfig === 'object' &&
Array.isArray(pnpmWorkspaceConfig.packages)
) {
return pnpmWorkspaceConfig.packages;
}
}
// Falling back to npm / yarn workspaces
const packageJsonPath = path.resolve(packagePath, 'package.json');
const {workspaces} = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
if (Array.isArray(workspaces)) {
return workspaces;
} else if (
typeof workspaces === 'object' &&
Array.isArray(workspaces.packages)
) {
// An alternative way for yarn to declare workspace packages
return workspaces.packages;
}
} catch (err) {
if (err.code !== 'ENOENT') {
logger.debug(`Failed getting workspace root from ${packagePath}: ${err}`);
}
}
return [];
}

/**
* Resolves the root of an npm or yarn workspace, by traversing the file tree
* upwards from a `candidatePath` in the search for
* - a directory with a package.json
* - which has a `workspaces` array of strings
* - which (possibly via a glob) includes the project root
*/
export function getWorkspaceRoot(
projectRoot: string,
candidatePath: string = projectRoot,
): ?string {
const workspacePaths = getWorkspacePaths(candidatePath);
// If one of the workspaces match the project root, this is the workspace root
// Note: While npm workspaces doesn't currently support globs, yarn does, which is why we use micromatch
const relativePath = path.relative(candidatePath, projectRoot);
// Using this instead of `micromatch.isMatch` to enable excluding patterns
if (micromatch([relativePath], workspacePaths).length > 0) {
return candidatePath;
}
// Try one level up
const parentDir = path.dirname(candidatePath);
if (parentDir !== candidatePath) {
return getWorkspaceRoot(projectRoot, parentDir);
}
return null;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [`@react-native/community-cli-plugin`] Added inference of `watchFolders` from NPM, Yarn and PNPM workspaces by kraenhansen · Pull Request #41967 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/community-cli-plugin/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,9 +31,11 @@
"metro": "^0.80.3",
"metro-config": "^0.80.3",
"metro-core": "^0.80.3",
"micromatch": "^4.0.5",
"node-fetch": "^2.2.0",
"querystring": "^0.2.1",
"readline": "^1.3.0"
"readline": "^1.3.0",
"yaml": "^2.3.4"
},
"devDependencies": {
"metro-resolver": "^0.80.3"
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import {getWorkspaceRoot} from '../getWorkspaceRoot';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

describe('getWorkspaceRoot', () => {
test('returns null if not in a workspace', () => {
const tempPackagePath = createTempPackage({
name: 'my-app',
});
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});

test('supports an npm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/my-app', 'packages/my-lib'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/*'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace (object style)', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: {
packages: ['packages/*'],
},
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace exclusion', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*", "!packages/*-app"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,133 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import loadMetroConfig from '../loadMetroConfig';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

/**
* Resolves a package by its name and creates a symbolic link in a node_modules directory
*/
function createPackageLink(nodeModulesPath: string, packageName: string) {
// Resolve the packages path on disk
const destinationPath = path.dirname(require.resolve(packageName));
const packageScope = packageName.includes('/')
? packageName.split('/')[0]
: undefined;

// Create a parent directory for a @scoped package
if (typeof packageScope === 'string') {
fs.mkdirSync(path.join(nodeModulesPath, packageScope));
}

const sourcePath = path.join(nodeModulesPath, packageName);
fs.symlinkSync(destinationPath, sourcePath);
}

function createTempConfig(projectRoot: string, metroConfig: {...}) {
const content = `
const {getDefaultConfig, mergeConfig} = require('@react-native/metro-config');
const config = ${JSON.stringify(metroConfig)};
module.exports = mergeConfig(getDefaultConfig(__dirname), config);
`;
const configPath = path.join(projectRoot, 'metro.config.js');
fs.writeFileSync(configPath, content, 'utf8');

const nodeModulesPath = path.join(projectRoot, 'node_modules');
fs.mkdirSync(nodeModulesPath);
// Create a symbolic link to the '@react-native/metro-config' package used by the config
createPackageLink(nodeModulesPath, '@react-native/metro-config');
}

const configLoadingContext = {
reactNativePath: path.dirname(require.resolve('react-native/package.json')),
platforms: {
ios: {npmPackageName: 'temp-package'},
android: {npmPackageName: 'temp-package'},
},
};

describe('loadMetroConfig', () => {
test('loads an empty config', async () => {
const rootPath = createTempPackage({name: 'temp-app'});
createTempConfig(rootPath, {});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath]);
});

test('loads watch folders', async () => {
const rootPath = createTempPackage({
name: 'temp-app',
});
createTempConfig(rootPath, {
watchFolders: ['somewhere-else'],
});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath, 'somewhere-else']);
});

test('includes an npm workspace root if no watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot, rootPath]);
});

test('does not resolve an npm workspace root if watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {
watchFolders: [],
});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot]);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import fs from 'fs';
import os from 'os';
import path from 'path';

export function createTempPackage(
packageJson: {...},
packagePath: string = fs.mkdtempSync(
path.join(os.tmpdir(), 'rn-metro-config-test-'),
),
): string {
fs.mkdirSync(packagePath, {recursive: true});
if (typeof packageJson === 'object') {
fs.writeFileSync(
path.join(packagePath, 'package.json'),
JSON.stringify(packageJson),
'utf8',
);
}

// Wrapping path in realpath to resolve any symlinks introduced by mkdtemp
return fs.realpathSync(packagePath);
}
86 changes: 86 additions & 0 deletions packages/community-cli-plugin/src/utils/getWorkspaceRoot.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* @format
* @oncall react_native
*/

import {logger} from '@react-native-community/cli-tools';
import fs from 'fs';
import micromatch from 'micromatch';
import path from 'path';
import yaml from 'yaml';

/**
* Get the workspace paths from the path of a potential workspace root.
*
* This supports:
* - [npm workspaces](https://docs.npmjs.com/cli/v10/using-npm/workspaces)
* - [yarn workspaces](https://yarnpkg.com/features/workspaces)
* - [pnpm workspaces](https://pnpm.io/workspaces)
*/
function getWorkspacePaths(packagePath: string): Array<string> {
try {
// Checking pnpm workspaces first
const pnpmWorkspacePath = path.resolve(packagePath, 'pnpm-workspace.yaml');
if (fs.existsSync(pnpmWorkspacePath)) {
const pnpmWorkspaceConfig = yaml.parse(
fs.readFileSync(pnpmWorkspacePath, 'utf8'),
);
if (
typeof pnpmWorkspaceConfig === 'object' &&
Array.isArray(pnpmWorkspaceConfig.packages)
) {
return pnpmWorkspaceConfig.packages;
}
}
// Falling back to npm / yarn workspaces
const packageJsonPath = path.resolve(packagePath, 'package.json');
const {workspaces} = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
if (Array.isArray(workspaces)) {
return workspaces;
} else if (
typeof workspaces === 'object' &&
Array.isArray(workspaces.packages)
) {
// An alternative way for yarn to declare workspace packages
return workspaces.packages;
}
} catch (err) {
if (err.code !== 'ENOENT') {
logger.debug(`Failed getting workspace root from ${packagePath}: ${err}`);
}
}
return [];
}

/**
* Resolves the root of an npm or yarn workspace, by traversing the file tree
* upwards from a `candidatePath` in the search for
* - a directory with a package.json
* - which has a `workspaces` array of strings
* - which (possibly via a glob) includes the project root
*/
export function getWorkspaceRoot(
projectRoot: string,
candidatePath: string = projectRoot,
): ?string {
const workspacePaths = getWorkspacePaths(candidatePath);
// If one of the workspaces match the project root, this is the workspace root
// Note: While npm workspaces doesn't currently support globs, yarn does, which is why we use micromatch
const relativePath = path.relative(candidatePath, projectRoot);
// Using this instead of `micromatch.isMatch` to enable excluding patterns
if (micromatch([relativePath], workspacePaths).length > 0) {
return candidatePath;
}
// Try one level up
const parentDir = path.dirname(candidatePath);
if (parentDir !== candidatePath) {
return getWorkspaceRoot(projectRoot, parentDir);
}
return null;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); [`@react-native/community-cli-plugin`] Added inference of `watchFolders` from NPM, Yarn and PNPM workspaces by kraenhansen · Pull Request #41967 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/community-cli-plugin/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,9 +31,11 @@
"metro": "^0.80.3",
"metro-config": "^0.80.3",
"metro-core": "^0.80.3",
"micromatch": "^4.0.5",
"node-fetch": "^2.2.0",
"querystring": "^0.2.1",
"readline": "^1.3.0"
"readline": "^1.3.0",
"yaml": "^2.3.4"
},
"devDependencies": {
"metro-resolver": "^0.80.3"
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import {getWorkspaceRoot} from '../getWorkspaceRoot';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

describe('getWorkspaceRoot', () => {
test('returns null if not in a workspace', () => {
const tempPackagePath = createTempPackage({
name: 'my-app',
});
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});

test('supports an npm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/my-app', 'packages/my-lib'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: ['packages/*'],
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a yarn workspace (object style)', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
workspaces: {
packages: ['packages/*'],
},
});
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(tempWorkspaceRootPath);
});

test('supports a pnpm workspace exclusion', () => {
const tempWorkspaceRootPath = createTempPackage({
name: 'package-root',
});
// Create the pnpm workspace configuration (see https://pnpm.io/pnpm-workspace_yaml)
const workspacesConfig = 'packages: ["packages/*", "!packages/*-app"]';
fs.writeFileSync(
path.join(tempWorkspaceRootPath, 'pnpm-workspace.yaml'),
workspacesConfig,
'utf8',
);
const tempPackagePath = createTempPackage(
{
name: 'my-app',
},
path.join(tempWorkspaceRootPath, 'packages', 'my-app'),
);
expect(getWorkspaceRoot(tempPackagePath)).toBe(null);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,133 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import loadMetroConfig from '../loadMetroConfig';
import {createTempPackage} from './temporary-package';
import fs from 'fs';
import path from 'path';

/**
* Resolves a package by its name and creates a symbolic link in a node_modules directory
*/
function createPackageLink(nodeModulesPath: string, packageName: string) {
// Resolve the packages path on disk
const destinationPath = path.dirname(require.resolve(packageName));
const packageScope = packageName.includes('/')
? packageName.split('/')[0]
: undefined;

// Create a parent directory for a @scoped package
if (typeof packageScope === 'string') {
fs.mkdirSync(path.join(nodeModulesPath, packageScope));
}

const sourcePath = path.join(nodeModulesPath, packageName);
fs.symlinkSync(destinationPath, sourcePath);
}

function createTempConfig(projectRoot: string, metroConfig: {...}) {
const content = `
const {getDefaultConfig, mergeConfig} = require('@react-native/metro-config');
const config = ${JSON.stringify(metroConfig)};
module.exports = mergeConfig(getDefaultConfig(__dirname), config);
`;
const configPath = path.join(projectRoot, 'metro.config.js');
fs.writeFileSync(configPath, content, 'utf8');

const nodeModulesPath = path.join(projectRoot, 'node_modules');
fs.mkdirSync(nodeModulesPath);
// Create a symbolic link to the '@react-native/metro-config' package used by the config
createPackageLink(nodeModulesPath, '@react-native/metro-config');
}

const configLoadingContext = {
reactNativePath: path.dirname(require.resolve('react-native/package.json')),
platforms: {
ios: {npmPackageName: 'temp-package'},
android: {npmPackageName: 'temp-package'},
},
};

describe('loadMetroConfig', () => {
test('loads an empty config', async () => {
const rootPath = createTempPackage({name: 'temp-app'});
createTempConfig(rootPath, {});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath]);
});

test('loads watch folders', async () => {
const rootPath = createTempPackage({
name: 'temp-app',
});
createTempConfig(rootPath, {
watchFolders: ['somewhere-else'],
});

const loadedConfig = await loadMetroConfig({
root: rootPath,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(rootPath);
expect(loadedConfig.watchFolders).toEqual([rootPath, 'somewhere-else']);
});

test('includes an npm workspace root if no watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot, rootPath]);
});

test('does not resolve an npm workspace root if watchFolders are defined', async () => {
const rootPath = createTempPackage({
name: 'temp-root',
workspaces: ['packages/temp-app'],
});
// Create a config inside a sub-package
const projectRoot = createTempPackage(
{
name: 'temp-app',
},
path.join(rootPath, 'packages', 'temp-app'),
);
createTempConfig(projectRoot, {
watchFolders: [],
});

const loadedConfig = await loadMetroConfig({
root: projectRoot,
...configLoadingContext,
});
expect(loadedConfig.projectRoot).toEqual(projectRoot);
expect(loadedConfig.watchFolders).toEqual([projectRoot]);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/

import fs from 'fs';
import os from 'os';
import path from 'path';

export function createTempPackage(
packageJson: {...},
packagePath: string = fs.mkdtempSync(
path.join(os.tmpdir(), 'rn-metro-config-test-'),
),
): string {
fs.mkdirSync(packagePath, {recursive: true});
if (typeof packageJson === 'object') {
fs.writeFileSync(
path.join(packagePath, 'package.json'),
JSON.stringify(packageJson),
'utf8',
);
}

// Wrapping path in realpath to resolve any symlinks introduced by mkdtemp
return fs.realpathSync(packagePath);
}
86 changes: 86 additions & 0 deletions packages/community-cli-plugin/src/utils/getWorkspaceRoot.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* @format
* @oncall react_native
*/

import {logger} from '@react-native-community/cli-tools';
import fs from 'fs';
import micromatch from 'micromatch';
import path from 'path';
import yaml from 'yaml';

/**
* Get the workspace paths from the path of a potential workspace root.
*
* This supports:
* - [npm workspaces](https://docs.npmjs.com/cli/v10/using-npm/workspaces)
* - [yarn workspaces](https://yarnpkg.com/features/workspaces)
* - [pnpm workspaces](https://pnpm.io/workspaces)
*/
function getWorkspacePaths(packagePath: string): Array<string> {
try {
// Checking pnpm workspaces first
const pnpmWorkspacePath = path.resolve(packagePath, 'pnpm-workspace.yaml');
if (fs.existsSync(pnpmWorkspacePath)) {
const pnpmWorkspaceConfig = yaml.parse(
fs.readFileSync(pnpmWorkspacePath, 'utf8'),
);
if (
typeof pnpmWorkspaceConfig === 'object' &&
Array.isArray(pnpmWorkspaceConfig.packages)
) {
return pnpmWorkspaceConfig.packages;
}
}
// Falling back to npm / yarn workspaces
const packageJsonPath = path.resolve(packagePath, 'package.json');
const {workspaces} = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
if (Array.isArray(workspaces)) {
return workspaces;
} else if (
typeof workspaces === 'object' &&
Array.isArray(workspaces.packages)
) {
// An alternative way for yarn to declare workspace packages
return workspaces.packages;
}
} catch (err) {
if (err.code !== 'ENOENT') {
logger.debug(`Failed getting workspace root from ${packagePath}: ${err}`);
}
}
return [];
}

/**
* Resolves the root of an npm or yarn workspace, by traversing the file tree
* upwards from a `candidatePath` in the search for
* - a directory with a package.json
* - which has a `workspaces` array of strings
* - which (possibly via a glob) includes the project root
*/
export function getWorkspaceRoot(
projectRoot: string,
candidatePath: string = projectRoot,
): ?string {
const workspacePaths = getWorkspacePaths(candidatePath);
// If one of the workspaces match the project root, this is the workspace root
// Note: While npm workspaces doesn't currently support globs, yarn does, which is why we use micromatch
const relativePath = path.relative(candidatePath, projectRoot);
// Using this instead of `micromatch.isMatch` to enable excluding patterns
if (micromatch([relativePath], workspacePaths).length > 0) {
return candidatePath;
}
// Try one level up
const parentDir = path.dirname(candidatePath);
if (parentDir !== candidatePath) {
return getWorkspaceRoot(projectRoot, parentDir);
}
return null;
}
Loading