Uh oh!
There was an error while loading. Please reload this page.
Use Objective-C nullability to provide better Swift types in RCTAppDelegate - #42236
Closed
okwasniewski wants to merge 1 commit into
Closed
Use Objective-C nullability to provide better Swift types in RCTAppDelegate#42236okwasniewski wants to merge 1 commit into
okwasniewski wants to merge 1 commit into
Conversation
facebook-github-bot
commented
Jan 10, 2024
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
analysis-bot
commented
Jan 10, 2024
Base commit: 8fd2f12 |
This pull request was successfully merged by @okwasniewski in a7c5c28. When will my fix make it into a release? | Upcoming Releases |
3 tasks
Kudo added a commit
to expo/expo
that referenced
this pull request
Jan 16, 2024
…26357) # Why fix react-native nightlies support for 0.74 # How summarize here, please check each commit messages for details - [BREAKING CHANGE] remove `unstable_useRuntimeSchedulerAlways` or `REACT_NATIVE_UNSTABLE_USE_RUNTIME_SCHEDULER_ALWAYS` support - [BREAKING CHANGE] remove `ReactNativeHostHandler.onRegisterJSIModules()` interface - [expo][dev-menu][dev-launcher] fixed for `ReactNativeHost.getJSIModulePackage()` removal and adding `ReactNativeHost.getUIManagerProvider()` - [dev-client] add compatible methods to address react/react-native#42236 changes To be resolved and currently workarounded by SetupReactNativeNightly - `import com.facebook.react.turbomodule.core.CallInvokerHolderImpl` -> ``import com.facebook.react.internal.turbomodule.core.CallInvokerHolderImpl` # Test Plan ci passed
okwasniewski added a commit
to callstack/react-native-visionos
that referenced
this pull request
Feb 16, 2024
…legate (react#42236) Summary: This PR adds nullable type annotations + nullability audit regions (`NS_ASSUME_NONNULL_BEGIN`/`NS_ASSUME_NONNULL_END`) to provide better Swift types. Before: ```swift class AppDelegate: RCTAppDelegate { override func sourceURL(for bridge: RCTBridge!) -> URL! { self.bundleURL() } override func bundleURL() -> URL! { RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "js/RNTesterApp.ios") } override func customize(_ rootView: RCTRootView!) { rootView.backgroundColor = .red } } ``` After: ```swift class AppDelegate: RCTAppDelegate { override func sourceURL(for bridge: RCTBridge) -> URL { self.bundleURL() } override func bundleURL() -> URL { RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "js/RNTesterApp.ios") } override func customize(_ rootView: RCTRootView) { rootView.backgroundColor = .red } } ``` ## Changelog: [IOS] [ADDED] - Provide better Swift types for RCTAppDelegate and RCTBridgeDelegate Pull Request resolved: react#42236 Test Plan: In Xcode click the top left square button and look up the generated interface:  Reviewed By: christophpurrer Differential Revision: D52660647 Pulled By: cipolleschi fbshipit-source-id: d4d3c36b3f420b3490145c491cd3781613f4b111
okwasniewski added a commit
to callstack/react-native-visionos
that referenced
this pull request
Apr 5, 2024
…legate (react#42236) Summary: This PR adds nullable type annotations + nullability audit regions (`NS_ASSUME_NONNULL_BEGIN`/`NS_ASSUME_NONNULL_END`) to provide better Swift types. Before: ```swift class AppDelegate: RCTAppDelegate { override func sourceURL(for bridge: RCTBridge!) -> URL! { self.bundleURL() } override func bundleURL() -> URL! { RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "js/RNTesterApp.ios") } override func customize(_ rootView: RCTRootView!) { rootView.backgroundColor = .red } } ``` After: ```swift class AppDelegate: RCTAppDelegate { override func sourceURL(for bridge: RCTBridge) -> URL { self.bundleURL() } override func bundleURL() -> URL { RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "js/RNTesterApp.ios") } override func customize(_ rootView: RCTRootView) { rootView.backgroundColor = .red } } ``` ## Changelog: [IOS] [ADDED] - Provide better Swift types for RCTAppDelegate and RCTBridgeDelegate Pull Request resolved: react#42236 Test Plan: In Xcode click the top left square button and look up the generated interface:  Reviewed By: christophpurrer Differential Revision: D52660647 Pulled By: cipolleschi fbshipit-source-id: d4d3c36b3f420b3490145c491cd3781613f4b111
okwasniewski added a commit
to callstack/react-native-visionos
that referenced
this pull request
Jun 24, 2024
…legate (react#42236) Summary: This PR adds nullable type annotations + nullability audit regions (`NS_ASSUME_NONNULL_BEGIN`/`NS_ASSUME_NONNULL_END`) to provide better Swift types. Before: ```swift class AppDelegate: RCTAppDelegate { override func sourceURL(for bridge: RCTBridge!) -> URL! { self.bundleURL() } override func bundleURL() -> URL! { RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "js/RNTesterApp.ios") } override func customize(_ rootView: RCTRootView!) { rootView.backgroundColor = .red } } ``` After: ```swift class AppDelegate: RCTAppDelegate { override func sourceURL(for bridge: RCTBridge) -> URL { self.bundleURL() } override func bundleURL() -> URL { RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "js/RNTesterApp.ios") } override func customize(_ rootView: RCTRootView) { rootView.backgroundColor = .red } } ``` ## Changelog: [IOS] [ADDED] - Provide better Swift types for RCTAppDelegate and RCTBridgeDelegate Pull Request resolved: react#42236 Test Plan: In Xcode click the top left square button and look up the generated interface:  Reviewed By: christophpurrer Differential Revision: D52660647 Pulled By: cipolleschi fbshipit-source-id: d4d3c36b3f420b3490145c491cd3781613f4b111
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds nullable type annotations + nullability audit regions (
NS_ASSUME_NONNULL_BEGIN/NS_ASSUME_NONNULL_END) to provide better Swift types.Before:
After:
Changelog:
[IOS] [ADDED] - Provide better Swift types for RCTAppDelegate and RCTBridgeDelegate
Test Plan:
In Xcode click the top left square button and look up the generated interface:
