feat: set Swift active compilation conditions build setting to DEBUG

[okwasniewski]

Summary:

This PR adds cocoapods utility to set SWIFT_ACTIVE_COMPILATION_CONDITIONS to DEBUG, which is set to this value by default (when generating a new native Xcode project).

This allows to use the #if DEBUG compilator directive in Swift to work out of the box, without any changes on user's side:

overridefunc bundleURL()->URL?{#if DEBUGRCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot:"index")#elseBundle.main.url(forResource:"main", withExtension:"jsbundle")#endif}

Changelog:

[IOS] [ADDED] - Set SWIFT_ACTIVE_COMPILATION_CONDITIONS to DEBUG

Test Plan:

Run bundle exec pod install and check if the active compilation flags are populated:

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	16,803,066	-435,494
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,190,312	-410,683
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: b41a33e
Branch: main

[okwasniewski]

Hey @cipolleschi, anything I can do to help you get this one merged?

[cipolleschi]

Sorry, I completely missed this PR. 😭

The changes look good. Could you add a test in utils-test.rb file to verify that the build settings is actually added? In this way we can make sure not to miss changes in the set_swift_compilation_conditions method

[okwasniewski]

@cipolleschi I've refactored the method to set_build_setting which accepts necessary arguments to set proper build settings. This method can remove set_use_hermes_build_setting and set_node_modules_user_settings methods (less code to maintain). I've also changed the tests to only test the utility

[cipolleschi]

Great job, thanks for refactoring!

[cipolleschi]

/rebase - this command rebase the pr on top of main automatically

[okwasniewski]

Hey @cipolleschi, is there anything more we need to get done in order to merge this PR?

[cipolleschi]

/rebase - this comment automatically rebase on top of main

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi merged this pull request in 756f89a.

[github-actions]

This pull request was successfully merged by @okwasniewski in 756f89a.

^{When will my fix make it into a release? | How to file a pick request?}