Skip to content

added version specific websites #3459 - #4234

Closed
udnisap wants to merge 3 commits into
react:masterfrom
udnisap:master
Closed

added version specific websites #3459#4234
udnisap wants to merge 3 commits into
react:masterfrom
udnisap:master

Conversation

@udnisap

Copy link
Copy Markdown
Contributor

I only implemented the version specific docs. What are we going to do with the default docs and how to navigate between docs?

@facebook-github-bot

Copy link
Copy Markdown
Contributor

By analyzing the blame information on this pull request, we identified @vjeux and @spicyj to be potential reviewers.

@facebook-github-botfacebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Nov 19, 2015
@udnisapudnisap changed the title added version specific docs #3459added version specific websites #3459Nov 19, 2015
@vjeux

Copy link
Copy Markdown
Contributor

cc @foghina, @frantic

@udnisap

Copy link
Copy Markdown
ContributorAuthor

This is as described in #3459
cc @ide@mkonicek@dabit3

@mkonicek

Copy link
Copy Markdown
Contributor

Cool! How did you test this?

Comment threadwebsite/publish.sh Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the value of VERSION if we're on master?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on branch 0.17-stable locally and this returns v0.3.11.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry it should have been git describe --abbrev=0 --tags

@udnisap

Copy link
Copy Markdown
ContributorAuthor

I sent initially to get some feedback as there were some clarifications.
I didnt test the whole flow. I tested by commenting out part of the shell script (website/publish.sh) and running in my local.

I commented out the git rebase as well. I got an error on this. Do we need this??

Since there are docs in the current gh-pages branch this will have it. We might have to cleanup the repo and have a index manually. I can run this and send a PR to gh-pages

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@udnisap updated the pull request.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@udnisap updated the pull request.

1 similar comment
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@udnisap updated the pull request.

@udnisap

Copy link
Copy Markdown
ContributorAuthor

Is the bot having some issues? I did not update the pull request for a while

@satya164

Copy link
Copy Markdown
Contributor

@udnisap Yeah. Ignore the bot.

@mkonicek

Copy link
Copy Markdown
Contributor

git describe returns the version of git for me so I don't see how this code can work. Are you still interested in working on this?

@bestander

Copy link
Copy Markdown
Contributor

Thanks for the contribution, @udnisap.
I am taking control of this feature today and I like your intention.

I'll close this PR though because the work will be coming from the internal codebase and will require some more back and forward review process.
It affects the web server file structure after all.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@udnisap@facebook-github-bot@vjeux@mkonicek@satya164@bestander