Skip to content

[RN][iOS] Fix race condition between A11yManager and UIManager - #42382

Merged
blakef merged 1 commit into
0.73-stablefrom
cipolleschi/fix_new_arch_release
Jan 25, 2024
Merged

[RN][iOS] Fix race condition between A11yManager and UIManager#42382
blakef merged 1 commit into
0.73-stablefrom
cipolleschi/fix_new_arch_release

Conversation

@cipolleschi

@cipolleschicipolleschi commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

Summary:

Community reported a race condition when 0.73 apps are built in Release mode. What happens is that there is a deadlock between the accessibility manager and the UIManager.

This PR fixes the deadlock by moving the accessibility manager lazy initialization.

Changelog:

[Internal] - Fixed deadlock at startup

Test Plan:

Tested in a 0.73 app

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 19, 2024
@cipolleschi
cipolleschi changed the base branch from main to 0.73-stableJanuary 19, 2024 12:55
@analysis-bot

analysis-bot commented Jan 19, 2024

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,499,846-8,298,965
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a9,754,365-10,431,642
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: fd0ca4d
Branch: main

@cipolleschi
cipolleschi marked this pull request as ready for review January 19, 2024 15:40
@cipolleschi
cipolleschiforce-pushed the cipolleschi/fix_new_arch_release branch from 38abcf3 to f39f34eCompareJanuary 19, 2024 15:51
@blakef
blakef merged commit e476db2 into 0.73-stableJan 25, 2024
@blakef
blakef deleted the cipolleschi/fix_new_arch_release branch January 25, 2024 14:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cipolleschi@analysis-bot@blakef@facebook-github-bot