Uh oh!
There was an error while loading. Please reload this page.
[Android] Update bridge to handle long values - #43158
Closed
ryanlntn wants to merge 2 commits into
Closed
Conversation
analysis-bot
commented
Feb 22, 2024
Base commit: 6549216 |
NickGerleman
commented
Feb 27, 2024
Contributor
LGTM |
facebook-github-bot
commented
Feb 27, 2024
Contributor
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Mar 5, 2024
Contributor
@NickGerleman merged this pull request in 0dc5c5f. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This adds support for 64 bit integer (long) values to the Android bridge. Per the wide gamut color RFC Android encodes wide gamut colors as long values so we need to update the bridge to support 64 bit integers as well since these classes will soon receive those values from native.
Changelog:
[ANDROID] [ADDED] - Update bridge to handle long values
Test Plan:
I added tests where I could for long types and truncation. I would like to add tests for ReadableNativeArray and ReadableNativeMap but I'm not sure how to go about mocking HybridData.