Uh oh!
There was an error while loading. Please reload this page.
Allow moving SyncCallback - #43268
Closed
javache wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Mar 1, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54381734 |
facebook-github-bot
commented
Mar 1, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54381734 |
facebook-github-bot
commented
Mar 4, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54381734 |
javache added a commit
to javache/react-native
that referenced
this pull request
Mar 4, 2024
Summary: We previously restricted all copies and moves of SyncCallback, but that led to unsafe calling paths being added instead to AsyncCallback. Instead, allowing moving of SyncCallback, and document the need for the caller to invoke it safely, so can we remove the unsafe path from AsyncCallback. Changelog: [General][Changed] Allow moving SyncCallback for advanced use-cases Reviewed By: christophpurrer Differential Revision: D54381734
javache added a commit
to javache/react-native
that referenced
this pull request
Mar 4, 2024
Summary: We previously restricted all copies and moves of SyncCallback, but that led to unsafe calling paths being added instead to AsyncCallback. Instead, allowing moving of SyncCallback, and document the need for the caller to invoke it safely, so can we remove the unsafe path from AsyncCallback. Changelog: [General][Changed] Allow moving SyncCallback for advanced use-cases Reviewed By: christophpurrer Differential Revision: D54381734
Summary: We previously restricted all copies and moves of SyncCallback, but that led to unsafe calling paths being added instead to AsyncCallback. Instead, allowing moving of SyncCallback, and document the need for the caller to invoke it safely, so can we remove the unsafe path from AsyncCallback. Changelog: [General][Changed] Allow moving SyncCallback for advanced use-cases Reviewed By: christophpurrer Differential Revision: D54381734
facebook-github-bot
commented
Mar 4, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D54381734 |
analysis-bot
commented
Mar 4, 2024
Base commit: f5c8bc1 |
facebook-github-bot
commented
Mar 4, 2024
Contributor
This pull request has been merged in 43c55e9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We previously restricted all copies and moves of SyncCallback, but that led to unsafe calling paths being added instead to AsyncCallback. Instead, allowing moving of SyncCallback, and document the need for the caller to invoke it safely, so can we remove the unsafe path from AsyncCallback.
Changelog: [General][Changed] Allow moving SyncCallback for advanced use-cases
Differential Revision: D54381734