Skip to content

Allow importing RCTAppDelegate in Swift - #43339

Closed
okwasniewski wants to merge 3 commits into
react:mainfrom
okwasniewski:fix/appdelegate-swift
Closed

Allow importing RCTAppDelegate in Swift#43339
okwasniewski wants to merge 3 commits into
react:mainfrom
okwasniewski:fix/appdelegate-swift

Conversation

@okwasniewski

Copy link
Copy Markdown
Contributor

Summary:

This PR fixes importing RCTAppDelegate, cleans up the imports, and properly sets the background color for bridgeless mode when using RCTRootViewFactory.

The issue with importing to Swift was that RCTTurboModuleManager has C++ in headers which caused Swift to error out.

Changelog:

[IOS] [FIXED] - Allow importing RCTAppDelegate in Swift
[INTERNAL] [REMOVED] - Remove unnecessary imports in AppDelegate
[INTERNAL] [FIXED] - Properly set background color for bridgeless

Test Plan:

  • CI Green
  • Check if background color is correct

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Mar 6, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a18,008,347-16
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a21,366,891+8
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: 1c69100
Branch: main

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Mar 6, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cipolleschi merged this pull request in 7c95369.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.p: CallstackPartner: CallstackPartnerShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@okwasniewski@facebook-github-bot@analysis-bot@cipolleschi