Skip to content

[RN][iOS][0.72] Fix flipper for Xcode 15.3 - #43344

Merged
alfonsocj merged 1 commit into
0.72-stablefrom
cipolleschi/fix-flipper-072
Mar 7, 2024
Merged

[RN][iOS][0.72] Fix flipper for Xcode 15.3#43344
alfonsocj merged 1 commit into
0.72-stablefrom
cipolleschi/fix-flipper-072

Conversation

@cipolleschi

@cipolleschicipolleschi commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Summary

Following #43335, we implemented the fix suggested here.

The rationale of applying this fix rather then releasing a new version of Flipper is because we will have to release Flipper 0.248.0, and the latest flipper version on Cocoapods is 0.233.0 (15 versions behind).

Plus, we have to port the fix to 0.73 and 0.71 and bumping Flipper there would be a major pain and it might require more time and introduce other bugs we don't want.

Changelog

[iOS][Fixed] - Make 0.72 build with Xcode 15.3

Test Plan

Tested locally + CircleCI is green

@cipolleschi
cipolleschi changed the base branch from main to 0.72-stableMarch 6, 2024 14:02
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 6, 2024
@cipolleschi
cipolleschi marked this pull request as ready for review March 6, 2024 14:03
@cipolleschi
cipolleschiforce-pushed the cipolleschi/fix-flipper-072 branch 2 times, most recently from afcfb08 to 7feff1dCompareMarch 6, 2024 14:30
@analysis-bot

analysis-bot commented Mar 6, 2024

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,492,847-9,511,508
androidhermesarmeabi-v7a7810754n/a
androidhermesx868962934n/a
androidhermesx86_648824181n/a
androidjscarm64-v8a9,151,784-12,211,018
androidjscarmeabi-v7a8341411n/a
androidjscx869205069n/a
androidjscx86_649463742n/a

Base commit: 3ed0ff3
Branch: main

@cipolleschi
cipolleschiforce-pushed the cipolleschi/fix-flipper-072 branch from 7feff1d to f5f11e7CompareMarch 6, 2024 15:32
Comment threadpackages/react-native/scripts/cocoapods/utils.rb Outdated
Comment threadpackages/react-native/scripts/react_native_pods.rb Outdated
Comment threadpackages/react-native/scripts/cocoapods/utils.rb Outdated
@cipolleschi
cipolleschiforce-pushed the cipolleschi/fix-flipper-072 branch 2 times, most recently from 8212c73 to 0f37f20CompareMarch 6, 2024 19:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cipolleschi@analysis-bot@hosseintalebi@alfonsocj@facebook-github-bot