Skip to content

Add overridable hooks for bridgeless creation - #43402

Closed
Kudo wants to merge 1 commit into
react:0.74-stablefrom
Kudo:@kudo/bridgeless-rctdelegate-hook
Closed

Add overridable hooks for bridgeless creation#43402
Kudo wants to merge 1 commit into
react:0.74-stablefrom
Kudo:@kudo/bridgeless-rctdelegate-hook

Conversation

@Kudo

@KudoKudo commented Mar 9, 2024

Copy link
Copy Markdown
Contributor

Summary:

add overridable hooks for RCTHost and RCTSurfaceHostingProxyRootView. this are required for expo's pluggable system to serve expo-dev-client and expo-updates integration.

this pr introduces new createSurfaceViewWithReactHost:moduleName:initProps: and changes createReactHost for returning an instance rather than mutating member variables.

this pr is based on 0.74-stable only since on main there's ec928d7 which is good enough for the use case.

Changelog:

[IOS] [ADDED] - Add overridable hooks for bridgeless creation in RCTAppDelegate

Test Plan:

ci passed

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner labels Mar 9, 2024
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a17,816,397-237,088
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a21,174,775-233,154
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: e2157f0
Branch: main

@huntie

Copy link
Copy Markdown
Collaborator

Thanks @Kudo. We were able to merge all of #43325 instead :).

@huntiehuntie closed this Mar 11, 2024
@Kudo
Kudo deleted the @kudo/bridgeless-rctdelegate-hook branch March 11, 2024 11:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ContributorA React Native contributor.p: ExpoPartner: ExpoPartnerPick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Kudo@analysis-bot@huntie@facebook-github-bot