Skip to content

Fix/image methods mock in jest setup#43497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
delphinebugner wants to merge 8 commits into from
Closed

Fix/image methods mock in jest setup #43497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f06ac66
Fix(Image.resolveAssetSource) do not mock function in tests
Mar 14, 2024
2ec89e0
Fix(Image.getSize) do not mock JS in test & check something is returned
Mar 14, 2024
8664cb3
Fix(Image.getSizeWithHeaders) add missing native mock & ensure JS wor…
Mar 14, 2024
ae793bd
Fix(Image.prefetch) do not mock JS in test & check native call
Mar 14, 2024
6839cd7
Fix(Image.prefetchWithMetadata) add missing native mock & do not mock…
Mar 14, 2024
ab5ee39
Fix(Image.queryCache) add miising native mock & do not mock JS in test
Mar 14, 2024
9c330ca
Refacto(Image) simplify return in mock
Mar 14, 2024
9a6ee7c
Fix(image-test) add explicit mock to avoid test order dependancy
Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions packages/react-native/Libraries/Image/__tests__/Image-test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,8 @@

import type {ElementRef} from 'react';

import NativeImageLoaderAndroid from '../NativeImageLoaderAndroid';
import NativeImageLoaderIOS from '../NativeImageLoaderIOS';
import {act, create} from 'react-test-renderer';

const render = require('../../../jest/renderer');
Expand DownExpand Up@@ -291,4 +293,62 @@ describe('<Image />', () => {
expect(secondInstance).toBe(null);
expect(imageInstancesFromCallback.size).toBe(0);
});

it('should resolve asset source even when Image module is mocked', async () => {
jest.mock('../Image');
const resolvedSource = Image.resolveAssetSource({uri: 'foo-bar.jpg'});
expect(resolvedSource).toEqual({uri: 'foo-bar.jpg'});
});

it('should compute image size even when Image module is mocked', async () => {
jest.mock('../Image');
const mockOnGetSizeSuccess = jest.fn((width, height) => undefined);
const mockSuccessCallback = (width: number, height: number) =>
mockOnGetSizeSuccess(width, height);

await Image.getSize('foo-bar.jpg', mockSuccessCallback);
await jest.runAllTicks();

expect(mockOnGetSizeSuccess).toHaveBeenCalledWith(320, 240);

await Image.getSizeWithHeaders(
'foo-bar.jpg',
{header: 'foo'},
mockSuccessCallback,
);

expect(mockOnGetSizeSuccess).toHaveBeenCalledWith(333, 222);
});

it('should call native prefetch methods when calling JS prefetch methods', async () => {
jest.mock('../Image');
await Image.prefetch('foo-bar.jpg');
expect(NativeImageLoaderIOS.prefetchImage).toHaveBeenCalledWith(
'foo-bar.jpg',
);
expect(NativeImageLoaderAndroid.prefetchImage).toHaveBeenCalledWith(
'foo-bar.jpg',
);

await Image.prefetchWithMetadata('foo-bar.jpg', 'foo-queryRootName');
expect(NativeImageLoaderIOS.prefetchImageWithMetadata).toHaveBeenCalledWith(
'foo-bar.jpg',
'foo-queryRootName',
0,
);
expect(NativeImageLoaderAndroid.prefetchImage).toHaveBeenCalledWith(
'foo-bar.jpg',
);
});

it('should call native queryCache method when JS queryCache method is called', async () => {
jest.mock('../Image');
await Image.queryCache(['foo-bar.jpg']);
expect(NativeImageLoaderIOS.queryCache).toHaveBeenCalledWith([
'foo-bar.jpg',
]);
expect(NativeImageLoaderIOS.queryCache).toHaveBeenCalledWith([
'foo-bar.jpg',
]);
});
});
19 changes: 8 additions & 11 deletions packages/react-native/jest/setup.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,17 +112,9 @@ jest
Constants: {},
},
}))
.mock('../Libraries/Image/Image', () => {
const Image = mockComponent('../Libraries/Image/Image');
Image.getSize = jest.fn();
Image.getSizeWithHeaders = jest.fn();
Image.prefetch = jest.fn();
Image.prefetchWithMetadata = jest.fn();
Image.queryCache = jest.fn();
Image.resolveAssetSource = jest.fn();

return Image;
})
.mock('../Libraries/Image/Image', () =>
mockComponent('../Libraries/Image/Image'),
)
.mock('../Libraries/Text/Text', () =>
mockComponent('../Libraries/Text/Text', MockNativeMethods),
)
Expand DownExpand Up@@ -261,7 +253,12 @@ jest
},
ImageLoader: {
getSize: jest.fn(url => Promise.resolve([320, 240])),
getSizeWithHeaders: jest.fn((url, headers) =>
Promise.resolve({height: 222, width: 333}),
),
prefetchImage: jest.fn(),
prefetchImageWithMetadata: jest.fn(),
queryCache: jest.fn(),
},
ImageViewManager: {
getSize: jest.fn((uri, success) =>
Expand Down