Skip to content

Migrate back to chromium-edge-launcher since Windows fix was merged - #43562

Closed
motiz88 wants to merge 1 commit into
react:mainfrom
motiz88:export-D55087731
Closed

Migrate back to chromium-edge-launcher since Windows fix was merged#43562
motiz88 wants to merge 1 commit into
react:mainfrom
motiz88:export-D55087731

Conversation

@motiz88

Copy link
Copy Markdown
Contributor

Summary:
A resubmission of D55013623 (Pull Request resolved: #43524) with a fix for the internal .flowconfig issue that got the initial diff reverted.


The Windows fix was merged and published. We no longer need to use the fork.

Changelog:

[INTERNAL] [FIXED] - Fix experimental debugger launch flow with Edge on Windows

Differential Revision: D55087731

Summary:
A resubmission of D55013623 (Pull Request resolved: react#43524) with a fix for the internal `.flowconfig` issue that got the initial diff reverted.
---
The [Windows fix](cezaraugusto/chromium-edge-launcher#1) was merged and published. We no longer need to use the fork.
## Changelog:
[INTERNAL] [FIXED] - Fix experimental debugger launch flow with Edge on Windows
Differential Revision: D55087731
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 19, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55087731

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a18,125,890-1
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a21,491,251+0
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: ed4a4a4
Branch: main

@github-actions

Copy link
Copy Markdown

This pull request was successfully merged by @motiz88 in 1ae379c.

When will my fix make it into a release? | Upcoming Releases

@github-actionsgithub-actionsBot added the Merged This PR has been merged. label Mar 20, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@motiz88@facebook-github-bot@analysis-bot